Make development workflow risk-based and verification proportionate
This commit is contained in:
@@ -8,7 +8,7 @@ supersedes:
|
||||
|
||||
# Replace the custom workflow engine with a skill-led workflow
|
||||
|
||||
> The legacy-runtime retention and pilot-before-retirement prerequisite below are superseded by [ADR 0007](0007-archive-legacy-workflows-05SEP2026.md). The skill-led workflow and its outstanding validation requirements remain in force.
|
||||
> The legacy-runtime retention and pilot-before-retirement prerequisite below are superseded by [ADR 0007](0007-archive-legacy-workflows-05SEP2026.md). The approval, disposable-data, review, verification, and record-commit policies are superseded by [ADR 0008](0008-risk-based-development-workflow-07OCT2026.md). The skill-led architecture and outstanding validation obligations remain in force; interpret scenario expectations under the current policy.
|
||||
|
||||
## Context
|
||||
|
||||
|
||||
@@ -0,0 +1,11 @@
|
||||
# Use risk-based development workflow gates
|
||||
|
||||
On 07OCT2026, JB approved replacing routine plan-approval pauses and repeated full verification with risk-based automation. Clear work proceeds from a short recorded plan; unresolved product/design choices and meaningful risk retain human gates. This supersedes the categorical plan approval, migration approval, commit-per-gate, two-reviewer, and repeat-full-suite policies in [ADR 0006](0006-skill-led-development-workflow-04SEP2026.md) and its [implementation plan](../workflow/skill-led-development-workflow-plan.md).
|
||||
|
||||
A standing repository policy may authorize schema changes and reset/reseed for named, verified disposable environments. Pre-production alone grants no authority; valuable/shared data, production access, external compatibility, and uncertain targets remain protected. Prefer direct changes over speculative compatibility or rollback machinery when the actual preservation contract permits rebuilding.
|
||||
|
||||
Use focused checks while developing, one independent read-only reviewer covering standards and specification, targeted follow-up on bounded fixes, and one full required suite after remediation. Reuse evidence only while its inputs remain applicable; failures and broader changes still require appropriate reruns. Keep tests complete for meaningful behavior and credible failures rather than exhaustive permutations at every layer. Stricter repository/CI/hook requirements remain binding until explicitly revised.
|
||||
|
||||
Preserve worktrees, scoped authorization, non-trivial UI direction approval, real interface validation, mutator exclusion, pinned review evidence, recoverable records, and safe local integration. Batch record updates into meaningful commits rather than requiring initial, per-gate, and closure commits. Keep the existing checkpoint heading contract and archived engines; add no replacement extension or hook runtime changes.
|
||||
|
||||
The prior twelve-scenario and three-pilot validation obligation remains open in [todos](../todos.md#replace-workflow-with-a-skill-based-orchestrator), with expected decisions interpreted under this superseding policy. Focused policy walkthroughs for this revision are not claims that those execution scenarios or pilots passed.
|
||||
+1
-1
@@ -62,7 +62,7 @@ Slice 1 found two Nono 0.74 limitations while building behavioral policy proofs.
|
||||
|
||||
## Replace `workflow` with a skill-based orchestrator
|
||||
|
||||
The strict `workflow` extension repeatedly failed before implementation because planner output and persisted state-machine constraints were too brittle for adaptive subagent orchestration. Implement the repository-managed `develop-workflow` skill under [ADR 0006](adr/0006-skill-led-development-workflow-04SEP2026.md), where the parent owns the plan, task tree, isolated worktree, explicit approval gates, verification, and independent review while launching bounded subagents directly. Preserve file ownership, reviewer independence, and resumable repository evidence while preferring native Pi primitives. Keep this TODO open until all twelve fresh-session scenarios and three real-change pilots pass. The legacy implementations were archived separately with explicit approval to waive the retirement prerequisite under [ADR 0007](adr/0007-archive-legacy-workflows-05SEP2026.md); archival does not establish validation success.
|
||||
The repository-managed `develop-workflow` skill replaces the brittle legacy engine under [ADR 0006](adr/0006-skill-led-development-workflow-04SEP2026.md), with risk-based automation now defined by [ADR 0008](adr/0008-risk-based-development-workflow-07OCT2026.md). Validate the parent-owned plan, isolated worktree, scoped approval boundaries, proportionate verification, independent review, ownership, and recoverable evidence through native Pi primitives. Keep this TODO open until all twelve fresh-session scenarios and three real-change pilots pass, interpreting old scenario expectations under the superseding policy: clear routine work is autonomous, declared disposable targets use standing authority, one reviewer covers both axes, and valid verification evidence is reused. Policy walkthroughs are not execution-pilot evidence. The legacy implementations were archived separately with explicit approval to waive the retirement prerequisite under [ADR 0007](adr/0007-archive-legacy-workflows-05SEP2026.md); archival does not establish validation success.
|
||||
|
||||
## Support finished-session resume for Claude CLI subagents
|
||||
|
||||
|
||||
@@ -1,6 +1,8 @@
|
||||
# Skill-led development workflow plan
|
||||
|
||||
**Status:** Accepted
|
||||
**Status:** Historical accepted plan; policy partially superseded
|
||||
|
||||
> [ADR 0008](../adr/0008-risk-based-development-workflow-07OCT2026.md) supersedes categorical plan/migration gates, mandatory initial/per-gate/closure commits, two-reviewer defaults, and repeated full verification below. Use the current [develop-workflow skill](../../skills/develop/develop-workflow/SKILL.md) for execution. [ADR 0007](../adr/0007-archive-legacy-workflows-05SEP2026.md) already superseded the pilot-before-archival prerequisite. The twelve scenarios and three real-change pilots remain outstanding, evaluated against current policy rather than obsolete gate expectations.
|
||||
|
||||
**Date:** 03SEP2026
|
||||
**Working skill name:** `develop-workflow`
|
||||
|
||||
@@ -0,0 +1,80 @@
|
||||
# Risk-based workflow automation record
|
||||
|
||||
## Status
|
||||
|
||||
- Status: active
|
||||
- Current phase: independent review
|
||||
- Next safe action: review the pinned policy diff and four bounded scenarios.
|
||||
|
||||
## Request and scope
|
||||
|
||||
- Request: reduce routine human interaction and redundant testing, especially for replaceable pre-production data.
|
||||
- In scope: develop-workflow skill and references/template; code-review skill; ADR and historical pointers; validation evidence and existing TODO alignment.
|
||||
- Out of scope: extension runtime/config changes, global instructions, database access, archived engines, checkpoint format changes, replacement of outstanding twelve-scenario/three-pilot validation.
|
||||
|
||||
## Git identity
|
||||
|
||||
- Source branch: main
|
||||
- Base commit: 284fdd638d1f2c790290491e0cfe2802880cec25
|
||||
- Feature branch: feature/workflow-automation
|
||||
- Worktree: /home/jb/code/harness-tools/.worktrees/workflow-automation
|
||||
- Omitted source changes: none; source checkout clean.
|
||||
|
||||
## Acceptance criteria
|
||||
|
||||
- [ ] Routine work proceeds from a recorded plan without an approval pause; substantive choices and protected actions remain gated.
|
||||
- [ ] Disposable-data policy requires named authorized targets, identity checks, scope and reproducible reset/reseed; pre-production alone grants nothing.
|
||||
- [ ] Focused tests and review precede one final full verification boundary; valid evidence can be reused and invalidated evidence is rerun.
|
||||
- [ ] One non-author reviewer covers standards and specification; targeted fixes do not force fresh full reviews.
|
||||
- [ ] Records remain recoverable with existing heading contract; no initial/per-gate/closure commit ceremony is mandatory.
|
||||
- [ ] UI direction, real interface validation, worktree isolation, honest results and safe integration remain intact.
|
||||
- [ ] No new extension, dependency, runtime behavior or user-level policy change.
|
||||
|
||||
## Approved implementation plan and gates
|
||||
|
||||
- Plan/specification source: user-approved /tmp/pi-present/develop-workflow-automation-review.md and the acceptance criteria above.
|
||||
- Exact plan: revise workflow and supporting references, consolidate review policy in code-review, retain checkpoint heading schema, add ADR 0008 and supersession pointers, run focused checks and scenario walkthroughs, obtain one independent review, run final full suite/static checks, commit and integrate locally.
|
||||
- Plan approval: user said "approved, let's proceed and implement this plan." on 07OCT2026. This explicitly authorizes the risk-based policy and its use for this revision; no redundant re-approval requested.
|
||||
- UI classification and direction approval: documentation-only skill behavior; no product UI change.
|
||||
- Risk decisions and scope: no database/environment declared disposable by this change; no dependency, security-posture, production, publishing or deployment changes. Existing external native-hooks default config directory is absent; no installed policy inferred or modified.
|
||||
|
||||
## Ownership
|
||||
|
||||
- Parent agent owns all edits under skills/develop/develop-workflow/, skills/develop/code-review/SKILL.md, docs/adr/0008-risk-based-development-workflow-07OCT2026.md, supersession pointers in ADR 0006 and the accepted workflow plan, docs/todos.md, and this record.
|
||||
- Independent reviewer owns no files and cannot remediate. No mutating child assignments.
|
||||
|
||||
## Verification matrix
|
||||
|
||||
| Surface | Command or method | Exit code | Outcome |
|
||||
| --- | --- | --- | --- |
|
||||
| Checkpoint compatibility | node --test skills/develop/develop-workflow/tests/checkpoint-record.test.mjs | 0 | 13/13 passed; existing schema retained |
|
||||
| Policy consistency | Node validateRecord on template/record, Python local-link validation, git diff --check | 0 | Both heading contracts valid; 18 links across 9 policy files resolve; whitespace clean. No prose snapshot tests added. |
|
||||
| Scenarios | routine feature, disposable/protected data, targeted review fix/shared-code change, non-trivial UI | pending | Bounded policy walkthroughs, not full execution pilots |
|
||||
| Final repository suite | bun run test | pending | Run after review fixes |
|
||||
| Final static check | bun run typecheck | pending | Run at final boundary |
|
||||
|
||||
## Review
|
||||
|
||||
- Base and product HEAD: pending
|
||||
- Clean status and tree hash: pending
|
||||
- Commit list: pending
|
||||
- Exact diff command: git diff --binary --full-index --find-renames <base>...<product-head> --
|
||||
- SHA-256: pending
|
||||
- Mutator identities: parent agent only
|
||||
- Reviewer identity, digest confirmation, standards and specification verdicts: pending
|
||||
- Findings and remediation: pending
|
||||
- Before/after reviewer Git evidence: pending
|
||||
|
||||
## Integration and rollback
|
||||
|
||||
- Synchronization and re-verification: git fetch origin completed with exit 0; origin/main and source main both remain 284fdd638d1f2c790290491e0cfe2802880cec25. No rebase delta.
|
||||
- Fast-forward result: pending
|
||||
- Product and evidence commits: pending
|
||||
- Reachability and cleanup: pending
|
||||
- Rollback strategy: revert the focused policy commit; no data or runtime migration.
|
||||
|
||||
## Checkpoints and blockers
|
||||
|
||||
- Last committed valid checkpoint: none yet; initial durable record written before product edits; batch commits per approved policy.
|
||||
- Blockers: none
|
||||
- Exact next safe action: obtain independent review and scenario walkthroughs; then run final full suite and typecheck.
|
||||
Reference in New Issue
Block a user