fix(skills): address develop workflow review

This commit is contained in:
jb
2026-09-04 10:47:04 -04:00
parent 1bab01799c
commit 1e213db45a
4 changed files with 26 additions and 41 deletions
+11 -9
View File
@@ -15,17 +15,21 @@ Choose the smallest sufficient path before mutation:
- **Light:** make one obvious low-risk edit requiring at most two steps. Inspect, edit, run focused checks, and summarize. Record why this is safe when near the boundary.
- **Full:** use the phases below for three or more steps, multiple files or modules, ambiguity, architecture, dependencies, migrations, security implications, non-trivial UI, or meaningful regression risk.
Promote light work to full before editing when discovery reveals meaningful scope or risk. Apply risk gates to every path.
Promote light work to full before editing when discovery reveals meaningful scope or risk.
**Complete when:** observed scope and risk justify the selected path.
## Risk gates for every path
Ask just in time before adding, removing, or materially upgrading dependencies; schema/data migration; production or live-database access; public API or compatibility breaks; destructive Git/filesystem actions outside the narrowly proven final cleanup; force push or shared-history rewrite; non-fast-forward integration; conflict resolution that changes approved behavior; material scope or acceptance expansion; security-posture changes; publishing; or deployment.
Present concrete evidence, scope the authorization, and mark one option recommended with its reason. Checkpoint the decision before acting. Treat approval as specific to that action; ask again when later evidence broadens it. Promote light work to full before editing when meaningful risk appears.
## 1. Preflight and isolate
For the full path, require Git worktrees, a writable repository record, `ask_user`, Git-capable independent reviewers, and target-interface validation when UI applies. Stop before product mutation when a mandatory capability is unavailable. In print or JSON mode, emit the pending gate or validation instructions and stop.
For the full path, require Git worktrees, a writable repository record, `ask_user`, Git-capable independent reviewers, and target-interface validation when UI applies. Stop before product mutation when a mandatory capability is unavailable. Let task tools degrade to the retained record and let `artifact-presenter` degrade to reporting the exact artifact path; neither optional convenience may bypass a gate. In print or JSON mode, emit the pending gate or validation instructions and stop.
Read repository instructions, relevant docs/ADRs/tests, and Git state. Capture the source branch and exact base commit. Create `./.worktrees/<feature>` on a descriptive feature branch. Treat collisions, unmerged paths, unexpected ownership, and an unignored worktree directory as blockers. For a dirty source checkout, list omitted changes and obtain explicit approval before proceeding.
Use explicit `cd <worktree> && ...` or `git -C <worktree> ...`; prove the top-level path before every shell mutation. Prepare a unique record from [`assets/workflow-record.md`](assets/workflow-record.md) and publish it atomically with the checkpoint helper in [evidence and recovery](references/evidence-and-recovery.md). Create the task tree, run applicable documentation checks, and commit the initial record before product mutation. Use the helper for every later meaningful update.
Read repository instructions, relevant docs/ADRs/tests, and Git state. Follow [Git and integration](references/git-and-integration.md) to capture source evidence, resolve dirty-source approval, and establish the isolated branch/worktree. Prepare a unique record from [`assets/workflow-record.md`](assets/workflow-record.md) and publish it with the helper in [evidence and recovery](references/evidence-and-recovery.md). Create the available live progress view, run applicable documentation checks, and commit the initial record before product mutation.
**Complete when:** worktree identity is proven and the initial record commit names the next safe action.
@@ -64,11 +68,9 @@ Retain candidates on a dedicated throwaway branch and record its commit. Present
## 5. Implement owned slices
State exclusive file ownership before parallel mutation. Serialize by default; parallelize only disjoint low-integration paths. Give each implementer the approved plan, decisions, owned paths, acceptance criteria, test seam, allowed commands, and deadline. Tell workers to stop at the deadline and leave commits, integration, user interaction, and mutation delegation to the parent.
State one owner and exclusive paths for every mutating assignment. Serialize by default; parallelize only disjoint low-integration paths. Give each implementer the approved plan, decisions, acceptance criteria, test seam, allowed commands, and deadline. Tell workers to stop at the deadline and leave commits, integration, user interaction, and mutation delegation to the parent.
Capture branch, HEAD, status, changed paths, and a patch artifact before and after every mutating assignment. Freeze all mutation on unexpected commits, out-of-ownership paths, deadline expiry, missing delivery, or unknown child liveness. Follow the recovery choices in [evidence and recovery](references/evidence-and-recovery.md); never retry mutating work until the previous child is proven terminal.
Use TDD at agreed seams where practical. Run focused tests after behavioral slices. Inspect each returned diff and repository state before marking it complete.
Follow [assignment evidence and recovery](references/evidence-and-recovery.md#assignment-evidence) before accepting, retrying, or reassigning mutation. Use TDD at agreed seams where practical. Run focused tests after behavioral slices. Inspect each returned diff and repository state before marking it complete.
**Complete when:** every acceptance criterion has intentional owned code and test evidence.