feat(skills): add develop workflow
This commit is contained in:
@@ -0,0 +1,33 @@
|
||||
# Independent review and remediation
|
||||
|
||||
## Identity and capability
|
||||
|
||||
Exclude every identity that authored or mutated the reviewed diff. Record reviewer display name, profile, child ID, and session ID when available. When stable identity is unavailable, exclude the entire ambiguous profile/run. Keep reviewers read-only and separate for:
|
||||
|
||||
- **Standards:** repository instructions and documented conventions.
|
||||
- **Specification:** the approved workflow record and linked source plan/spec.
|
||||
|
||||
Use Git-capable reviewer profiles with repository read access and no declared `write` or `edit` tools. Shell access can still mutate; capture status, tree, HEAD, and changed paths before and after review. Any mutation invalidates the verdict and marks that identity as a mutator.
|
||||
|
||||
## Review brief
|
||||
|
||||
Generate the brief in the parent. Include:
|
||||
|
||||
- pinned base and product HEAD;
|
||||
- clean status and product tree hash;
|
||||
- commit list;
|
||||
- exact `git diff --binary --full-index --find-renames <base>...<product-head> --` command;
|
||||
- SHA-256 of those exact bytes;
|
||||
- approved record/specification sources;
|
||||
- repository standards sources;
|
||||
- all excluded mutator identities.
|
||||
|
||||
Launch standards and specification reviewers through separate direct subagent calls. Avoid wrapped parallel launch until its delivery defect is proven fixed. Require each reviewer to regenerate the pinned diff, confirm its digest before review, remain read-only, and bind every finding to file/hunk evidence and severity. Treat a missing result or digest mismatch as no verdict.
|
||||
|
||||
Approval binds to base, product HEAD, clean status, tree hash, and diff digest. Permit a later closure commit outside that fingerprint only after proving it changes the workflow record alone.
|
||||
|
||||
## Findings and remediation
|
||||
|
||||
Validate findings against repository evidence. Send accepted fixes to an original implementer or another non-reviewer, never the reviewer. Preserve exclusive path ownership and assignment evidence. Rerun affected checks and the full required suite, create focused commits, and generate a new fingerprint.
|
||||
|
||||
Launch fresh independent reviewers for the changed diff. Escalate after two unsuccessful remediation cycles or whenever a finding requires material scope, acceptance, ownership, verification, or architecture changes; return to plan approval before further production mutation.
|
||||
Reference in New Issue
Block a user