docs: record Bash cwd review approval

This commit is contained in:
jb
2026-09-04 17:38:00 -04:00
parent 42dd6efdf3
commit e5a2e53a94
+8 -8
View File
@@ -3,8 +3,8 @@
## Status
- Status: active
- Current phase: 7. Fresh independent review
- Next safe action: obtain fresh standards and specification review of the remediated pinned diff.
- Current phase: 8. Integrate locally
- Next safe action: verify the clean source checkout and fast-forward `main` to the approved feature branch.
## Request and scope
@@ -68,10 +68,10 @@
- Exact diff command: `git diff --binary --full-index --find-renames 7e7cfdb5cb0e1a1218b9a2c8250267d5099637fc...e1c5c55c151fc167eadf56531658482c437b1e61 --`
- SHA-256: `b2471221a44d2e507789fad70152059ed42e76807c6af32f1151b95bb498614c`
- Mutator identities: parent Pi session `01a06e08-8d07-76a7-a116-d7e3baf55b87`
- Standards reviewer identity, digest confirmation, and verdict: cycle 1 `bash-cwd-standards`, scout child session `01a06e2f-665e-7acc-a2cd-98f976a13b43`, digest confirmed, FAIL; fresh cycle 2 pending.
- Specification reviewer identity, digest confirmation, and verdict: cycle 1 `bash-cwd-specification`, scout child session `01a06e2f-b262-77f1-9aef-d5c964cb33b6`, subagent `8ae886b2`, digest confirmed, FAIL; fresh cycle 2 pending.
- Standards reviewer identity, digest confirmation, and verdict: cycle 1 `bash-cwd-standards`, scout child session `01a06e2f-665e-7acc-a2cd-98f976a13b43`, digest confirmed, FAIL. Cycle 2's first identity failed with a provider WebSocket error and issued no verdict. Replacement `bash-cwd-standards-cycle-2-retry`, scout child session `01a06e48-b629-7ad2-bd65-445ad6b8d2ea`, independently regenerated the digest and returned PASS with no findings.
- Specification reviewer identity, digest confirmation, and verdict: cycle 1 `bash-cwd-specification`, scout child session `01a06e2f-b262-77f1-9aef-d5c964cb33b6`, subagent `8ae886b2`, digest confirmed, FAIL. Cycle 2 `bash-cwd-specification-cycle-2` independently confirmed the digest and returned PASS with no findings.
- Findings and remediation cycles: Pi 0.85.0 includes a separate upstream `ctx.cwd` correction but its public package imports undeclared `@earendil-works/pi-server`, causing `ERR_MODULE_NOT_FOUND`; the user selected a repository-owned override instead. During implementation, a direct live call with an extra `cwd` field still printed the primary checkout, proving Pi's schema/executor silently ignore the requested per-call directory and the first local design addressed the wrong seam. Review cycle 1 accepted three findings: preserve configured `shellPath` and `shellCommandPrefix` when recreating Pi's built-in definition; make retirement contingent on equivalent validated per-call cwd; and label npm installation as post-publication. The parent implementer loaded trusted Pi settings at execution, added a realistic custom-shell/prefix regression, and corrected package guidance.
- Before/after reviewer Git evidence: both reviewers reported clean `feature/honor-bash-worktree-cwd` state, product HEAD `328faa0`, product tree `6b858045b91298c91f55aedd848c3a02432edafb`, and the complete changed-path set before and after their read-only reviews; current review-pin HEAD remained `3cf354b`.
- Before/after reviewer Git evidence: cycle 1 reviewers reported clean `feature/honor-bash-worktree-cwd` state, product HEAD `328faa0`, product tree `6b858045b91298c91f55aedd848c3a02432edafb`, and the complete changed-path set before and after their read-only reviews. Cycle 2 passing reviewers reported clean current review-pin HEAD `42dd6ef`, product HEAD `e1c5c55`, product tree `496022b109fd53b728dc898bf470f87c00129a11`, matching digest, and unchanged paths/status before and after review.
## Integration and rollback
@@ -83,6 +83,6 @@
## Checkpoints and blockers
- Last committed valid checkpoint: remediation commit `e1c5c55`
- Blockers: fresh standards and specification review verdicts are pending.
- Exact next safe action: commit this fresh review pin and launch two new read-only reviewer identities against the recorded digest.
- Last committed valid checkpoint: fresh review pin `42dd6ef`
- Blockers: none.
- Exact next safe action: commit the review approvals, run the pre-integration Git gate, and fast-forward clean local `main`.