docs: approve local Bash cwd override
This commit is contained in:
@@ -2,9 +2,9 @@
|
|||||||
|
|
||||||
## Status
|
## Status
|
||||||
|
|
||||||
- Status: waiting
|
- Status: active
|
||||||
- Current phase: 3. Design and obtain plan approval
|
- Current phase: 5. Implement owned slices
|
||||||
- Next safe action: present the revised local-override plan and obtain explicit approval before further product mutation.
|
- Next safe action: implement the approved `@jbcode/pi-bash-cwd` package and turn the retained red reproduction into its focused regression test.
|
||||||
|
|
||||||
## Request and scope
|
## Request and scope
|
||||||
|
|
||||||
@@ -34,7 +34,7 @@
|
|||||||
|
|
||||||
- Plan/specification source: user request, `docs/todos.md`, and upstream Pi 0.84.4/0.85.0 source under `/srv/data/opensrc/repos/github.com/earendil-works/pi/`.
|
- Plan/specification source: user request, `docs/todos.md`, and upstream Pi 0.84.4/0.85.0 source under `/srv/data/opensrc/repos/github.com/earendil-works/pi/`.
|
||||||
- Exact plan: pending revised approval. Proposed: (1) create `extensions/bash-cwd` as a publishable `@jbcode/pi-bash-cwd` package; (2) override `bash` by preserving the host's built-in schema, metadata, rendering, and execution behavior while constructing the delegated built-in tool from the live `ctx.cwd`; (3) move the red regression into the package and cover hidden-worktree root, nested package, and fail-before-sentinel cases; (4) add the package to workspace/package checks and root test execution; (5) document installation and compatibility, remove the resolved Bash cwd TODO, annotate historical workaround text, and add a separate TODO for removing the local override after a usable upstream release; (6) run focused package tests, packaging checks, typecheck, and the full repository suite.
|
- Exact plan: pending revised approval. Proposed: (1) create `extensions/bash-cwd` as a publishable `@jbcode/pi-bash-cwd` package; (2) override `bash` by preserving the host's built-in schema, metadata, rendering, and execution behavior while constructing the delegated built-in tool from the live `ctx.cwd`; (3) move the red regression into the package and cover hidden-worktree root, nested package, and fail-before-sentinel cases; (4) add the package to workspace/package checks and root test execution; (5) document installation and compatibility, remove the resolved Bash cwd TODO, annotate historical workaround text, and add a separate TODO for removing the local override after a usable upstream release; (6) run focused package tests, packaging checks, typecheck, and the full repository suite.
|
||||||
- Plan approval: pending after the Pi 0.85.0 blocker forced replanning. The user selected `local_override` and then `publishable_package` through `ask_user` on 04SEP2026.
|
- Plan approval: approved by the user through `ask_user` on 04SEP2026 after selecting `local_override` and `publishable_package`.
|
||||||
- UI classification and direction approval: non-UI; no prototype gate applies.
|
- UI classification and direction approval: non-UI; no prototype gate applies.
|
||||||
- Risk decisions and scope: the approved Pi dependency upgrade was abandoned and fully restored after Pi 0.85.0 failed to load. No new dependency will be added. The new package remains repository-only and will not be installed, published, or added to the active global Pi environment in this task.
|
- Risk decisions and scope: the approved Pi dependency upgrade was abandoned and fully restored after Pi 0.85.0 failed to load. No new dependency will be added. The new package remains repository-only and will not be installed, published, or added to the active global Pi environment in this task.
|
||||||
|
|
||||||
@@ -44,7 +44,7 @@
|
|||||||
| --- | --- | --- | --- | --- | --- |
|
| --- | --- | --- | --- | --- | --- |
|
||||||
| Workflow setup and research | parent Pi session `01a06e08-8d07-76a7-a116-d7e3baf55b87` | 15 minutes | workflow record only | Before: clean `main` at `7e7cfdb`; after: clean feature worktree at `5f853dc` | Complete |
|
| Workflow setup and research | parent Pi session `01a06e08-8d07-76a7-a116-d7e3baf55b87` | 15 minutes | workflow record only | Before: clean `main` at `7e7cfdb`; after: clean feature worktree at `5f853dc` | Complete |
|
||||||
| Initial dependency-plan implementation | parent Pi session `01a06e08-8d07-76a7-a116-d7e3baf55b87` | 15 minutes | `package.json`, `bun.lock`, focused test, workflow record | Before: clean feature worktree at `9d68d5f`; after: Pi 0.85.0 upgrade restored; focused red test retained unstaged | Paused and replanned after upstream packaging blocker |
|
| Initial dependency-plan implementation | parent Pi session `01a06e08-8d07-76a7-a116-d7e3baf55b87` | 15 minutes | `package.json`, `bun.lock`, focused test, workflow record | Before: clean feature worktree at `9d68d5f`; after: Pi 0.85.0 upgrade restored; focused red test retained unstaged | Paused and replanned after upstream packaging blocker |
|
||||||
| Local override implementation | parent Pi session `01a06e08-8d07-76a7-a116-d7e3baf55b87` | 15 minutes | `extensions/bash-cwd/**`, `scripts/bash-cwd.test.mjs` removal, `package.json`, `scripts/package-workspaces.test.mjs`, `README.md`, `docs/todos.md`, `docs/workflow/skill-led-development-workflow-plan.md`, workflow record | Before: feature worktree at `9d68d5f` with inspected red-test changes | Pending approval |
|
| Local override implementation | parent Pi session `01a06e08-8d07-76a7-a116-d7e3baf55b87` | 15 minutes | `extensions/bash-cwd/**`, `scripts/bash-cwd.test.mjs` removal, `package.json`, `scripts/package-workspaces.test.mjs`, `README.md`, `docs/todos.md`, `docs/workflow/skill-led-development-workflow-plan.md`, workflow record | Before: feature worktree at `070ba3d` with inspected red-test changes | In progress |
|
||||||
|
|
||||||
## Verification matrix
|
## Verification matrix
|
||||||
|
|
||||||
@@ -80,6 +80,6 @@
|
|||||||
|
|
||||||
## Checkpoints and blockers
|
## Checkpoints and blockers
|
||||||
|
|
||||||
- Last committed valid checkpoint: initial record commit `5f853dc`
|
- Last committed valid checkpoint: revised-plan record commit `070ba3d`
|
||||||
- Blockers: revised exact-plan approval.
|
- Blockers: none.
|
||||||
- Exact next safe action: present this revised record and ask the user to approve or reject the local-override implementation plan.
|
- Exact next safe action: commit this approval checkpoint, then implement the approved local override.
|
||||||
|
|||||||
Reference in New Issue
Block a user