Files
harness-tools/docs/workflow/archive-workflows-record.md
T

6.9 KiB

Archive legacy workflows

Status

  • Status: complete
  • Current phase: closure
  • Next safe action: no product work remains; retain the separate skill-validation TODO.

Request and scope

Archive both extensions/workflow and extensions/_workflows under __archived/extensions/. Preserve source and tests as historical reference, not supported runnable packages. Keep develop-workflow, historical documentation, live Pi configuration, existing worktrees, and skill validation evidence intact.

Git identity

  • Source branch: main
  • Base commit: fee0d44e2d
  • Feature branch: feature/archive-workflows
  • Worktree: /srv/data/code/jb-pi/harness-tools/.worktrees/archive-workflows
  • Omitted source changes: none; source was clean.

Acceptance criteria

  • Both implementations and their tests are retained in the archive.
  • Active workspace inventory, lockfile, and root test commands no longer reference them.
  • Current docs explain the archive and explicit pilot-prerequisite override; skill validation remains open.
  • Active checks pass or failures are reported with evidence; independent reviewers approve the pinned diff.

Approved implementation plan and gates

  1. Move tracked files for both implementations to __archived/extensions/, preserving historical code unchanged. Add an archive README explaining historical relative imports and how to recover runnable sources from Git. Fix the moved workflow README's repository documentation links.
  2. Remove the obsolete workspace exclusion and legacy test globs from package.json; update workspace inventory assertions and only legacy workspace entries in bun.lock. No third-party version or dependency changes. The existing TypeScript include already excludes archives.
  3. Update root README, current package documentation, retirement TODO, and ADR 0006 with an explicit pointer to a small retirement ADR. Keep separate scenario/pilot validation TODO open. Preserve historical plans and ADR content rather than mass-rewriting old paths.
  4. Verify focused package/link tests, root typecheck, and full bun run test. There are no root lint/build scripts. Check archived file preservation and absence of active imports. No UI change, installation, publishing, host configuration, or production access.
  5. Commit verified work; fetch/rebase main, reverify any changed tree, obtain separate standards and specification reviews of the exact binary diff, fast-forward local main, commit closure metadata, and safely remove only this worktree/branch. Rollback is a focused revert of the archival product commit.
  • Scope approval: user selected Archive both.
  • Retirement gate: user selected Archive now, explicitly overriding the deferred three-pilot prerequisite. This does not claim pilot success.
  • Plan approval: user selected Approve after Orca presented the complete plan.

Ownership

Parent agent owns all mutations listed above, including this record and new archival README/ADR. No subagent owns files. Mutating implementation deadline: 15 minutes; stop and checkpoint if exceeded. Reviewers are read-only and distinct from the parent.

Verification matrix

Initial checks: bun run test:packages and bun run test:links exited 0; bun run typecheck and bun run test exited 1 because the new worktree lacked workspace dependencies, including effect. Full tests stopped at test:node; this is not a successful full run. git diff --check passed. All 62 archived tracked files are retained; every file except the deliberately updated README is byte-identical to the base.

Additional gate: user approved Restore locked dependencies after the missing-dependency failure. Permit bun install --frozen-lockfile in this isolated worktree only, with no dependency-version changes, then rerun verification. This narrows the original no-installation constraint; host Pi configuration remains untouched.

The approved bun install --frozen-lockfile && bun run typecheck && bun run test rerun exited 0. All stages of the root test script executed successfully. No dependency versions changed; the only lockfile changes remove the legacy workspace. Existing exact source caches for effect@4.0.0-beta.101 and @effect/platform-node@4.0.0-beta.101 were confirmed under /srv/data/opensrc. Archive preservation and whitespace checks passed. No UI changes require application validation.

Review

First review binding: base fee0d44e2d, product 45d6a41a39, tree e6d974aa49. Commits: 5b1e771, ea05b2f, eb52030, 45d6a41. Exact diff command: git diff --binary --full-index --find-renames fee0d44e2ddd7a982e94ebf99117f69bb9bae78e...45d6a41a39454b968392be72301884a460725366 --. SHA-256: 6c8ede8b38d9a718886b9374f0ea572e6662ea113b1d7354e71506f5b5ecbca0. Clean status, HEAD, and tree were unchanged before/after both reviews.

Specification reviewer archive-specification (claim-verifier, session 01a0749b-2ee1-7616-ac4f-e3f46db30922) confirmed digest and approved with no findings. Standards reviewer archive-standards (claim-verifier, session not exposed) confirmed digest and rejected two low documentation issues: stale current locations in docs/npm-packages.md, and this record still describing product commit/pinning as future work. Parent accepted and corrected both. Parent is the only mutator; reviewers own no files.

Final review binding: same base, product 8d3552bc92, tree 240ce43471. Add remediation commit 8d3552b to the first commit list. Exact command: git diff --binary --full-index --find-renames fee0d44e2ddd7a982e94ebf99117f69bb9bae78e...8d3552bc926ba70af4ec7c2b23a01c6dbd9e5eec --. SHA-256: b10026bce1fd5f60567c8cded5df7646af6a3ee4f971940df2f01bbb4a1cbdc6.

Standards reviewer archive-standards-final (claim-verifier, session 01a0749e-1b8d-7bd9-949c-e660b1f16c05) and specification reviewer archive-specification-final (claim-verifier, session 01a0749e-65ad-7baf-8c5d-b9a9c98ae087) both confirmed the final digest and approved with zero findings. Parent verified unchanged clean status, HEAD, tree, and digest after review. bun run typecheck && bun run test exited 0 again after remediation.

Integration and rollback

Fetch of origin/main exited 0. Remote commit 7e7cfdb5cb is an ancestor of local main/base fee0d44e2ddd7a982e94ebf99117f69bb9bae78e; no new upstream tree to incorporate. Local main was still clean at the exact base and fast-forwarded successfully to reviewed product 8d3552b. This record is the only file changed by the closure commit. Rollback via focused revert of product/remediation commits. Cleanup is limited to this workflow-owned worktree and feature branch after clean-state and product/closure reachability checks; no push, publication, or host configuration changes.

Checkpoints and blockers

None. Initial helper invocation rejected noncanonical section names before creating a record; corrected headings and retried successfully. No tool defect observed.