6.2 KiB
Archive legacy workflows
Status
- Status: active
- Current phase: independent review
- Next safe action: obtain fresh independent review verdicts for the remediation commit; integrate only after both approve its exact diff.
Request and scope
Archive both extensions/workflow and extensions/_workflows under __archived/extensions/. Preserve source and tests as historical reference, not supported runnable packages. Keep develop-workflow, historical documentation, live Pi configuration, existing worktrees, and skill validation evidence intact.
Git identity
- Source branch: main
- Base commit:
fee0d44e2d - Feature branch: feature/archive-workflows
- Worktree: /srv/data/code/jb-pi/harness-tools/.worktrees/archive-workflows
- Omitted source changes: none; source was clean.
Acceptance criteria
- Both implementations and their tests are retained in the archive.
- Active workspace inventory, lockfile, and root test commands no longer reference them.
- Current docs explain the archive and explicit pilot-prerequisite override; skill validation remains open.
- Active checks pass or failures are reported with evidence; independent reviewers approve the pinned diff.
Approved implementation plan and gates
- Move tracked files for both implementations to
__archived/extensions/, preserving historical code unchanged. Add an archive README explaining historical relative imports and how to recover runnable sources from Git. Fix the moved workflow README's repository documentation links. - Remove the obsolete workspace exclusion and legacy test globs from
package.json; update workspace inventory assertions and only legacy workspace entries inbun.lock. No third-party version or dependency changes. The existing TypeScript include already excludes archives. - Update root README, current package documentation, retirement TODO, and ADR 0006 with an explicit pointer to a small retirement ADR. Keep separate scenario/pilot validation TODO open. Preserve historical plans and ADR content rather than mass-rewriting old paths.
- Verify focused package/link tests, root typecheck, and full
bun run test. There are no root lint/build scripts. Check archived file preservation and absence of active imports. No UI change, installation, publishing, host configuration, or production access. - Commit verified work; fetch/rebase main, reverify any changed tree, obtain separate standards and specification reviews of the exact binary diff, fast-forward local main, commit closure metadata, and safely remove only this worktree/branch. Rollback is a focused revert of the archival product commit.
- Scope approval: user selected Archive both.
- Retirement gate: user selected Archive now, explicitly overriding the deferred three-pilot prerequisite. This does not claim pilot success.
- Plan approval: user selected Approve after Orca presented the complete plan.
Ownership
Parent agent owns all mutations listed above, including this record and new archival README/ADR. No subagent owns files. Mutating implementation deadline: 15 minutes; stop and checkpoint if exceeded. Reviewers are read-only and distinct from the parent.
Verification matrix
Initial checks: bun run test:packages and bun run test:links exited 0; bun run typecheck and bun run test exited 1 because the new worktree lacked workspace dependencies, including effect. Full tests stopped at test:node; this is not a successful full run. git diff --check passed. All 62 archived tracked files are retained; every file except the deliberately updated README is byte-identical to the base.
Additional gate: user approved Restore locked dependencies after the missing-dependency failure. Permit bun install --frozen-lockfile in this isolated worktree only, with no dependency-version changes, then rerun verification. This narrows the original no-installation constraint; host Pi configuration remains untouched.
The approved bun install --frozen-lockfile && bun run typecheck && bun run test rerun exited 0. All stages of the root test script executed successfully. No dependency versions changed; the only lockfile changes remove the legacy workspace. Existing exact source caches for effect@4.0.0-beta.101 and @effect/platform-node@4.0.0-beta.101 were confirmed under /srv/data/opensrc. Archive preservation and whitespace checks passed. No UI changes require application validation.
Review
First review binding: base fee0d44e2d, product 45d6a41a39, tree e6d974aa49. Commits: 5b1e771, ea05b2f, eb52030, 45d6a41. Exact diff command: git diff --binary --full-index --find-renames fee0d44e2ddd7a982e94ebf99117f69bb9bae78e...45d6a41a39454b968392be72301884a460725366 --. SHA-256: 6c8ede8b38d9a718886b9374f0ea572e6662ea113b1d7354e71506f5b5ecbca0. Clean status, HEAD, and tree were unchanged before/after both reviews.
Specification reviewer archive-specification (claim-verifier, session 01a0749b-2ee1-7616-ac4f-e3f46db30922) confirmed digest and approved with no findings. Standards reviewer archive-standards (claim-verifier, session not exposed) confirmed digest and rejected two low documentation issues: stale current locations in docs/npm-packages.md, and this record still describing product commit/pinning as future work. Parent accepted and corrected both. Parent is the only mutator; reviewers own no files.
Fresh review follows the remediation commit. Its exact immutable HEAD/tree and binary-diff digest are supplied directly to both reviewers and will be recorded in the metadata-only closure once approved, avoiding a self-referential commit/digest in the product record. No product integration is authorized by the first review.
Integration and rollback
Fetch of origin/main exited 0. Remote commit 7e7cfdb5cb is an ancestor of local main/base fee0d44e2ddd7a982e94ebf99117f69bb9bae78e; no new upstream tree to incorporate. Pending local fast-forward after review; rollback via focused revert.
Checkpoints and blockers
None. Initial helper invocation rejected noncanonical section names before creating a record; corrected headings and retried successfully. No tool defect observed.