From 03b4799bc68aaa612b7a37ebd95164ac777a1b21 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Sun, 30 Nov 2025 01:58:04 +0000 Subject: [PATCH] test: harden TerminalManager non-zero exit assertion --- .../src/server/terminal-mcp/terminal-manager.test.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/server/src/server/terminal-mcp/terminal-manager.test.ts b/packages/server/src/server/terminal-mcp/terminal-manager.test.ts index b9f218f69..7e9b88c68 100644 --- a/packages/server/src/server/terminal-mcp/terminal-manager.test.ts +++ b/packages/server/src/server/terminal-mcp/terminal-manager.test.ts @@ -10,6 +10,12 @@ function stripAnsi(value: string): string { return value.replace(ANSI_ESCAPE_REGEX, ""); } +function expectMissingPathMessage(output: string, missingPath: string): void { + const normalized = stripAnsi(output).toLowerCase(); + expect(normalized).toContain(missingPath.toLowerCase()); + expect(normalized).toMatch(/cannot access|no such file|not found/); +} + describe("TerminalManager - Command Execution", () => { let manager: TerminalManager; @@ -59,12 +65,9 @@ describe("TerminalManager - Command Execution", () => { 5000 ); - const normalizedOutput = stripAnsi(result.output).toLowerCase(); - expect(result.isDead).toBe(true); expect(result.exitCode).not.toBe(0); - expect(normalizedOutput).toContain("nonexistent-directory-test"); - expect(normalizedOutput).toMatch(/cannot access|no such file|not found/); + expectMissingPathMessage(result.output, "nonexistent-directory-test"); }); it("should handle directory changes in command", async () => {