feat(app): switch sidebar Group by from the command center (#3063)

Switching the sidebar between Project and Status grouping takes three
clicks today: open the display preferences menu, open Grouping, pick the
mode. It is the only sidebar preference with no fast path.

Typing "group" in the command center now offers a single entry that
switches to the mode you are not in, so it reads "Group by status" while
grouped by project and the reverse once you are in status mode. With
two modes a "cycle grouping" label would not say where you land, and an
entry that reads the same in both states looks like it does nothing.

The entry is query-only, so the default Cmd-K list is unchanged. It does
not clear the focus restore element, because it navigates nowhere and
focus has to return to whatever you were typing in.

The contribution is built by a pure function in root-contributions.ts so
its branches can be unit tested, mirroring workspace-contributions.ts.
The registration subscribes to groupMode with a narrow selector to avoid
re-registering every root action when host filters are reconciled.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Christoph Leiter
2026-08-11 14:35:10 +00:00
committed by GitHub
co-authored by Claude Opus 5
parent b7ca1f7502
commit 07044136c8
13 changed files with 226 additions and 0 deletions
@@ -0,0 +1,58 @@
import { expect, test, type Page } from "../support/fixtures";
import { gotoAppShell } from "../support/helpers/app";
import { openCommandCenter } from "../support/helpers/command-center";
import { seedWorkspace } from "../support/helpers/seed-client";
const GROUP_BY_STATUS = "Group by status";
const GROUP_BY_PROJECT = "Group by project";
// Result rows carry no testID of their own, so the entries are addressed by their visible label.
async function runGroupingEntry(page: Page, label: string, absent: string): Promise<void> {
const panel = await openCommandCenter(page);
await panel.getByTestId("command-center-input").fill("group");
const entry = panel.getByText(label, { exact: true });
await expect(entry).toBeVisible({ timeout: 30_000 });
// The entry always names the mode you are not in, so its opposite must never be listed.
await expect(panel.getByText(absent, { exact: true })).toHaveCount(0);
await entry.click();
await expect(page.getByTestId("command-center-panel")).not.toBeVisible({ timeout: 30_000 });
}
test.describe("Command center sidebar grouping", () => {
test.describe.configure({ timeout: 120_000 });
test("flips sidebar grouping and persists the choice across a reload", async ({ page }) => {
const seeded = await seedWorkspace({ repoPrefix: "command-center-grouping-" });
try {
await gotoAppShell(page);
const projectList = page.getByTestId("sidebar-project-workspace-list-scroll");
const statusList = page.getByTestId("sidebar-status-list-scroll");
await expect(projectList).toBeVisible({ timeout: 30_000 });
// Query-only: the grouping entry stays out of the default empty-query list.
const panel = await openCommandCenter(page);
await expect(panel.getByText(GROUP_BY_STATUS, { exact: true })).toHaveCount(0);
await expect(panel.getByText(GROUP_BY_PROJECT, { exact: true })).toHaveCount(0);
await page.keyboard.press("Escape");
await expect(panel).not.toBeVisible({ timeout: 30_000 });
await runGroupingEntry(page, GROUP_BY_STATUS, GROUP_BY_PROJECT);
await expect(statusList).toBeVisible({ timeout: 30_000 });
await expect(projectList).toHaveCount(0);
// The only assertion that catches a flip which never reached persisted storage.
await page.reload();
await expect(statusList).toBeVisible({ timeout: 30_000 });
// Grouping persists, so the run must leave the sidebar back in project mode.
await runGroupingEntry(page, GROUP_BY_PROJECT, GROUP_BY_STATUS);
await expect(projectList).toBeVisible({ timeout: 30_000 });
await expect(statusList).toHaveCount(0);
} finally {
await seeded.cleanup().catch(() => undefined);
}
});
});
@@ -0,0 +1,76 @@
import { describe, expect, it } from "vitest";
import type { SidebarGroupMode } from "@/stores/sidebar-view-store";
import type { CommandCenterIconProps } from "./contributions";
import { buildGroupingContribution, type GroupingCommandCenterSource } from "./root-contributions";
function ProjectIcon(_props: CommandCenterIconProps) {
return null;
}
function StatusIcon(_props: CommandCenterIconProps) {
return null;
}
function source(groupMode: SidebarGroupMode): {
value: GroupingCommandCenterSource;
applied: SidebarGroupMode[];
} {
const applied: SidebarGroupMode[] = [];
return {
value: {
groupMode,
labels: {
section: "Actions",
groupByProject: "Group by project",
groupByStatus: "Group by status",
},
icons: { project: ProjectIcon, status: StatusIcon },
setGroupMode: (mode) => applied.push(mode),
},
applied,
};
}
describe("grouping command center contribution", () => {
it("offers status while grouped by project", () => {
const fixture = source("project");
const contribution = buildGroupingContribution(fixture.value);
expect(contribution.presentation).toMatchObject({
title: "Group by status",
icon: StatusIcon,
});
contribution.run();
expect(fixture.applied).toEqual(["status"]);
});
it("offers project while grouped by status", () => {
const fixture = source("status");
const contribution = buildGroupingContribution(fixture.value);
expect(contribution.presentation).toMatchObject({
title: "Group by project",
icon: ProjectIcon,
});
contribution.run();
expect(fixture.applied).toEqual(["project"]);
});
it("keeps a stable id across both modes so the registry tiebreak never moves", () => {
expect(buildGroupingContribution(source("project").value).id).toBe(
buildGroupingContribution(source("status").value).id,
);
});
it("stays out of the default empty-query list", () => {
for (const mode of ["project", "status"] as const) {
const contribution = buildGroupingContribution(source(mode).value);
expect(contribution.visibility).toBe("query");
expect(contribution.group).toBe("actions");
// 6 is keyboard-shortcuts and 7 belongs to the workspace actions in #3013.
expect(contribution.rank).toBe(8);
}
});
});
@@ -0,0 +1,39 @@
import type { SidebarGroupMode } from "@/stores/sidebar-view-store";
import type { CommandCenterContribution, CommandCenterIcon } from "./contributions";
export interface GroupingCommandCenterSource {
groupMode: SidebarGroupMode;
labels: {
section: string;
groupByProject: string;
groupByStatus: string;
};
icons: {
project?: CommandCenterIcon;
status?: CommandCenterIcon;
};
setGroupMode(mode: SidebarGroupMode): void;
}
// One entry that always names the mode you are not in, so it can never read as a no-op.
export function buildGroupingContribution(
source: GroupingCommandCenterSource,
): CommandCenterContribution {
// Collapse into nextGroupMode() from sidebar-view-store once #2504 lands.
const target: SidebarGroupMode = source.groupMode === "project" ? "status" : "project";
return {
id: "sidebar-grouping",
group: "actions",
groupRank: 0,
rank: 8,
keywords: ["group", "grouping", "sort", "sidebar", "project", "status"],
visibility: "query",
run: () => source.setGroupMode(target),
presentation: {
kind: "action",
title: target === "status" ? source.labels.groupByStatus : source.labels.groupByProject,
sectionTitle: source.labels.section,
icon: target === "status" ? source.icons.status : source.icons.project,
},
};
}
@@ -3,6 +3,8 @@ import { router, type Href } from "expo-router";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { import {
CalendarClock, CalendarClock,
CircleDashed,
Folder,
FolderPlus, FolderPlus,
History, History,
Home, Home,
@@ -18,6 +20,7 @@ import { keyboardActionDispatcher } from "@/keyboard/keyboard-action-dispatcher"
import { useKeyboardShortcutsAvailable } from "@/keyboard/availability"; import { useKeyboardShortcutsAvailable } from "@/keyboard/availability";
import { resolveShortcutKeysForAction } from "@/keyboard/keyboard-shortcuts"; import { resolveShortcutKeysForAction } from "@/keyboard/keyboard-shortcuts";
import { useKeyboardShortcutsStore } from "@/stores/keyboard-shortcuts-store"; import { useKeyboardShortcutsStore } from "@/stores/keyboard-shortcuts-store";
import { useSidebarViewStore } from "@/stores/sidebar-view-store";
import { clearCommandCenterFocusRestoreElement } from "@/utils/command-center-focus-restore"; import { clearCommandCenterFocusRestoreElement } from "@/utils/command-center-focus-restore";
import { import {
buildOpenProjectRoute, buildOpenProjectRoute,
@@ -28,6 +31,7 @@ import {
import { getShortcutOs } from "@/utils/shortcut-platform"; import { getShortcutOs } from "@/utils/shortcut-platform";
import type { CommandCenterContribution, CommandCenterIconProps } from "./contributions"; import type { CommandCenterContribution, CommandCenterIconProps } from "./contributions";
import { useCommandCenterActions } from "./provider"; import { useCommandCenterActions } from "./provider";
import { buildGroupingContribution } from "./root-contributions";
const ThemedPlus = withUnistyles(Plus, (theme) => ({ color: theme.colors.foregroundMuted })); const ThemedPlus = withUnistyles(Plus, (theme) => ({ color: theme.colors.foregroundMuted }));
const ThemedFolderPlus = withUnistyles(FolderPlus, (theme) => ({ const ThemedFolderPlus = withUnistyles(FolderPlus, (theme) => ({
@@ -46,6 +50,10 @@ const ThemedSettings = withUnistyles(Settings, (theme) => ({
color: theme.colors.foregroundMuted, color: theme.colors.foregroundMuted,
})); }));
const ThemedHome = withUnistyles(Home, (theme) => ({ color: theme.colors.foregroundMuted })); const ThemedHome = withUnistyles(Home, (theme) => ({ color: theme.colors.foregroundMuted }));
const ThemedFolder = withUnistyles(Folder, (theme) => ({ color: theme.colors.foregroundMuted }));
const ThemedCircleDashed = withUnistyles(CircleDashed, (theme) => ({
color: theme.colors.foregroundMuted,
}));
function PlusIcon({ size }: CommandCenterIconProps) { function PlusIcon({ size }: CommandCenterIconProps) {
return <ThemedPlus size={size} strokeWidth={2.4} />; return <ThemedPlus size={size} strokeWidth={2.4} />;
@@ -75,6 +83,14 @@ function HomeIcon({ size }: CommandCenterIconProps) {
return <ThemedHome size={size} strokeWidth={2.2} />; return <ThemedHome size={size} strokeWidth={2.2} />;
} }
function FolderIcon({ size }: CommandCenterIconProps) {
return <ThemedFolder size={size} strokeWidth={2.2} />;
}
function CircleDashedIcon({ size }: CommandCenterIconProps) {
return <ThemedCircleDashed size={size} strokeWidth={2.2} />;
}
export function CommandCenterRootActions() { export function CommandCenterRootActions() {
const { t } = useTranslation(); const { t } = useTranslation();
const { overrides } = useKeyboardShortcutOverrides(); const { overrides } = useKeyboardShortcutOverrides();
@@ -85,6 +101,10 @@ export function CommandCenterRootActions() {
const sessionsRoute = useMemo<Href>(() => buildSessionsRoute(), []); const sessionsRoute = useMemo<Href>(() => buildSessionsRoute(), []);
const schedulesRoute = useMemo<Href>(() => buildSchedulesRoute(), []); const schedulesRoute = useMemo<Href>(() => buildSchedulesRoute(), []);
const setShortcutsDialogOpen = useKeyboardShortcutsStore((state) => state.setShortcutsDialogOpen); const setShortcutsDialogOpen = useKeyboardShortcutsStore((state) => state.setShortcutsDialogOpen);
// Narrow selector on purpose: a whole-store subscription would re-register every root action
// each time host filters are reconciled.
const groupMode = useSidebarViewStore((state) => state.groupMode);
const setGroupMode = useSidebarViewStore((state) => state.setGroupMode);
const shortcutPlatform = useMemo( const shortcutPlatform = useMemo(
() => ({ isMac: getShortcutOs() === "mac", isDesktop: getIsElectronRuntime() }), () => ({ isMac: getShortcutOs() === "mac", isDesktop: getIsElectronRuntime() }),
[], [],
@@ -229,13 +249,28 @@ export function CommandCenterRootActions() {
}); });
} }
availableActions.push(
buildGroupingContribution({
groupMode,
labels: {
section: t("shell.commandCenter.actions"),
groupByProject: t("shell.commandCenter.groupByProject"),
groupByStatus: t("shell.commandCenter.groupByStatus"),
},
icons: { project: FolderIcon, status: CircleDashedIcon },
setGroupMode,
}),
);
return availableActions; return availableActions;
}, [ }, [
groupMode,
homeRoute, homeRoute,
openAddProject, openAddProject,
overrides, overrides,
schedulesRoute, schedulesRoute,
sessionsRoute, sessionsRoute,
setGroupMode,
setShortcutsDialogOpen, setShortcutsDialogOpen,
settingsRoute, settingsRoute,
shortcutPlatform, shortcutPlatform,
+2
View File
@@ -65,6 +65,8 @@ export const ar: TranslationResources = {
newAgent: "وكيل جديد", newAgent: "وكيل جديد",
addProject: "إضافة مشروع", addProject: "إضافة مشروع",
home: "بيت", home: "بيت",
groupByProject: "تجميع حسب المشروع",
groupByStatus: "تجميع حسب الحالة",
modelGroupLabel: "النموذج", modelGroupLabel: "النموذج",
modelSearchKeywords: "تبديل النموذج تغيير النموذج تعيين النموذج اختيار النموذج", modelSearchKeywords: "تبديل النموذج تغيير النموذج تعيين النموذج اختيار النموذج",
thinkingGroupLabel: "التفكير", thinkingGroupLabel: "التفكير",
+2
View File
@@ -63,6 +63,8 @@ export const en = {
newAgent: "New agent", newAgent: "New agent",
addProject: "Add project", addProject: "Add project",
home: "Home", home: "Home",
groupByProject: "Group by project",
groupByStatus: "Group by status",
modelGroupLabel: "Model", modelGroupLabel: "Model",
modelSearchKeywords: "switch model change model set model select model", modelSearchKeywords: "switch model change model set model select model",
thinkingGroupLabel: "Thinking", thinkingGroupLabel: "Thinking",
+2
View File
@@ -65,6 +65,8 @@ export const es: TranslationResources = {
newAgent: "Nuevo agente", newAgent: "Nuevo agente",
addProject: "Agregar proyecto", addProject: "Agregar proyecto",
home: "Hogar", home: "Hogar",
groupByProject: "Agrupar por proyecto",
groupByStatus: "Agrupar por estado",
modelGroupLabel: "Modelo", modelGroupLabel: "Modelo",
modelSearchKeywords: "cambiar modelo modificar modelo establecer modelo seleccionar modelo", modelSearchKeywords: "cambiar modelo modificar modelo establecer modelo seleccionar modelo",
thinkingGroupLabel: "Razonamiento", thinkingGroupLabel: "Razonamiento",
+2
View File
@@ -66,6 +66,8 @@ export const fr: TranslationResources = {
newAgent: "Nouvel agent", newAgent: "Nouvel agent",
addProject: "Ajouter un projet", addProject: "Ajouter un projet",
home: "Maison", home: "Maison",
groupByProject: "Grouper par projet",
groupByStatus: "Grouper par statut",
modelGroupLabel: "Modèle", modelGroupLabel: "Modèle",
modelSearchKeywords: modelSearchKeywords:
"changer de modèle modifier le modèle définir le modèle sélectionner le modèle", "changer de modèle modifier le modèle définir le modèle sélectionner le modèle",
+2
View File
@@ -65,6 +65,8 @@ export const ja: TranslationResources = {
newAgent: "新しいエージェント", newAgent: "新しいエージェント",
addProject: "プロジェクトを追加", addProject: "プロジェクトを追加",
home: "ホーム", home: "ホーム",
groupByProject: "プロジェクトでグループ化",
groupByStatus: "ステータスでグループ化",
modelGroupLabel: "モデル", modelGroupLabel: "モデル",
modelSearchKeywords: "モデルを切り替え モデルを変更 モデルを設定 モデルを選択", modelSearchKeywords: "モデルを切り替え モデルを変更 モデルを設定 モデルを選択",
thinkingGroupLabel: "思考", thinkingGroupLabel: "思考",
+2
View File
@@ -65,6 +65,8 @@ export const ko: TranslationResources = {
newAgent: "새 에이전트", newAgent: "새 에이전트",
addProject: "프로젝트 추가", addProject: "프로젝트 추가",
home: "홈", home: "홈",
groupByProject: "프로젝트별 그룹화",
groupByStatus: "상태별 그룹화",
modelGroupLabel: "모델", modelGroupLabel: "모델",
modelSearchKeywords: "모델 전환 모델 변경 모델 설정 모델 선택", modelSearchKeywords: "모델 전환 모델 변경 모델 설정 모델 선택",
thinkingGroupLabel: "추론", thinkingGroupLabel: "추론",
+2
View File
@@ -65,6 +65,8 @@ export const ptBR: TranslationResources = {
newAgent: "Novo agente", newAgent: "Novo agente",
addProject: "Adicionar projeto", addProject: "Adicionar projeto",
home: "Início", home: "Início",
groupByProject: "Agrupar por projeto",
groupByStatus: "Agrupar por status",
modelGroupLabel: "Modelo", modelGroupLabel: "Modelo",
modelSearchKeywords: "trocar modelo mudar modelo definir modelo selecionar modelo", modelSearchKeywords: "trocar modelo mudar modelo definir modelo selecionar modelo",
thinkingGroupLabel: "Raciocínio", thinkingGroupLabel: "Raciocínio",
+2
View File
@@ -65,6 +65,8 @@ export const ru: TranslationResources = {
newAgent: "Новый агент", newAgent: "Новый агент",
addProject: "Добавить проект", addProject: "Добавить проект",
home: "Дом", home: "Дом",
groupByProject: "Группировать по проекту",
groupByStatus: "Группировать по статусу",
modelGroupLabel: "Модель", modelGroupLabel: "Модель",
modelSearchKeywords: "сменить модель изменить модель выбрать модель установить модель", modelSearchKeywords: "сменить модель изменить модель выбрать модель установить модель",
thinkingGroupLabel: "Мышление", thinkingGroupLabel: "Мышление",
+2
View File
@@ -65,6 +65,8 @@ export const zhCN: TranslationResources = {
newAgent: "新建 Agent", newAgent: "新建 Agent",
addProject: "添加 project", addProject: "添加 project",
home: "首页", home: "首页",
groupByProject: "按项目分组",
groupByStatus: "按状态分组",
modelGroupLabel: "模型", modelGroupLabel: "模型",
modelSearchKeywords: "切换模型 更改模型 设置模型 选择模型", modelSearchKeywords: "切换模型 更改模型 设置模型 选择模型",
thinkingGroupLabel: "思考", thinkingGroupLabel: "思考",