[codex] Centralize subprocess env boundaries (#585)
* Centralize subprocess env boundaries * Remove env boundary static audit test * Tighten env boundary process launches * Fix Windows native process launches * Inline provider env pass-throughs
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
import { describe, expect, test, vi } from "vitest";
|
||||
|
||||
import {
|
||||
applyProviderEnv,
|
||||
createProviderEnv,
|
||||
migrateProviderSettings,
|
||||
ProviderOverrideSchema,
|
||||
resolveProviderCommandPrefix,
|
||||
@@ -55,7 +55,7 @@ describe("resolveProviderCommandPrefix", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("applyProviderEnv", () => {
|
||||
describe("createProviderEnv", () => {
|
||||
test("merges provider env overrides", () => {
|
||||
const base = {
|
||||
PATH: "/usr/bin",
|
||||
@@ -68,7 +68,7 @@ describe("applyProviderEnv", () => {
|
||||
},
|
||||
};
|
||||
|
||||
const env = applyProviderEnv(base, runtime);
|
||||
const env = createProviderEnv({ baseEnv: base, runtimeSettings: runtime });
|
||||
|
||||
expect(env.PATH).toBe("/usr/bin");
|
||||
expect(env.HOME).toBe("/custom/home");
|
||||
@@ -80,7 +80,7 @@ describe("applyProviderEnv", () => {
|
||||
const base = { PATH: "/usr/bin" };
|
||||
const runtime: ProviderRuntimeSettings = { env: { PATH: "/custom/path" } };
|
||||
|
||||
const env = applyProviderEnv(base, runtime);
|
||||
const env = createProviderEnv({ baseEnv: base, runtimeSettings: runtime });
|
||||
|
||||
expect(env.PATH).toBe("/custom/path");
|
||||
});
|
||||
@@ -95,7 +95,7 @@ describe("applyProviderEnv", () => {
|
||||
CLAUDE_CODE_ENABLE_SDK_FILE_CHECKPOINTING: "true",
|
||||
};
|
||||
|
||||
const env = applyProviderEnv(base);
|
||||
const env = createProviderEnv({ baseEnv: base });
|
||||
|
||||
expect(env.PATH).toBe("/usr/bin");
|
||||
expect(env.CLAUDECODE).toBeUndefined();
|
||||
|
||||
Reference in New Issue
Block a user