Add server-side validation for working directory existence

- Validate cwd exists before creating agent in session.ts
- Show error message when directory doesn't exist
- Add client-side warning display in new.tsx
- Block form submission for non-existent directories
- Add daemon e2e test for non-existent cwd validation
- Add createAgentExpectFail helper in daemon-client.ts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Mohamed Boudra
2025-12-27 05:10:59 +00:00
co-authored by Claude Opus 4.5
parent 95c821a4c6
commit 1e9d8bf075
4 changed files with 102 additions and 1 deletions
+26
View File
@@ -244,6 +244,9 @@ export default function DraftAgentScreen() {
const isNonGitDirectory =
repoRequestStatus === "error" &&
/not in a git repository/i.test(repoRequestError?.message ?? "");
const isDirectoryNotExists =
repoRequestStatus === "error" &&
/does not exist|no such file or directory|ENOENT/i.test(repoRequestError?.message ?? "");
const repoInfoStatus: "idle" | "loading" | "ready" | "error" = !shouldInspectRepo
? "idle"
: repoAvailabilityError
@@ -490,6 +493,10 @@ export default function DraftAgentScreen() {
setErrorMessage("Working directory is required");
throw new Error("Working directory is required");
}
if (isDirectoryNotExists) {
setErrorMessage("Working directory does not exist on the selected host");
throw new Error("Working directory does not exist on the selected host");
}
if (!trimmedPrompt) {
setErrorMessage("Initial prompt is required");
throw new Error("Initial prompt is required");
@@ -562,6 +569,7 @@ export default function DraftAgentScreen() {
createNewBranch,
createWorktree,
gitBlockingError,
isDirectoryNotExists,
isLoading,
isNonGitDirectory,
modeOptions,
@@ -692,6 +700,13 @@ export default function DraftAgentScreen() {
wrapInContainer={false}
renderTrigger={renderDropdownTrigger}
/>
{isDirectoryNotExists && (
<View style={styles.warningContainer}>
<Text style={styles.warningText}>
Directory does not exist on the selected host
</Text>
</View>
)}
{renderConfigRow({
label: "Agent",
value: `${providerDefinitions.find((p) => p.id === selectedProvider)?.label ?? selectedProvider} · ${selectedModel || "auto"}`,
@@ -1037,6 +1052,17 @@ const styles = StyleSheet.create((theme) => ({
color: theme.colors.destructiveForeground,
fontSize: theme.fontSize.sm,
},
warningContainer: {
paddingHorizontal: theme.spacing[3],
paddingVertical: theme.spacing[2],
borderRadius: theme.borderRadius.md,
backgroundColor: theme.colors.palette.yellow[400],
},
warningText: {
color: "#000000",
fontSize: theme.fontSize.sm,
fontWeight: theme.fontWeight.semibold,
},
hostBadge: {
flexDirection: "row",
alignItems: "center",