Make workspace IDs opaque, independent of the filesystem path (#1503)
* Make workspace IDs opaque, independent of the filesystem path Workspace IDs were the resolved checkout/worktree path, so code could treat an ID as a path: prefix matching, deriving directories from it, falling back to a path when a lookup missed. IDs are now opaque - compared only by exact equality and never used as a path. Anything path-shaped resolves the workspace record first and reads its cwd. New workspaces get a generated `wks_` ID; existing path-shaped IDs are read from disk and never regenerated, so there is no migration and no change to the wire or persisted schemas. Groundwork for running multiple workspaces in a single directory. * Keep attachment scope key stable and align refetch test The attachment scope key keeps `workspace=` instead of `wsid=` so existing persisted drafts are not orphaned; the rename was cosmetic. The SDK refetch test no longer asserts a filter, matching refetch fetching one page and selecting by id client-side. * Fix live agent updates in directories without a registered workspace The opaque-ID work removed buildProjectPlacementForCwd's directory fallback, so an agent running in a folder with no registered workspace (e.g. a fresh non-git dir) produced a null placement. forwardAgentUpdate then threw "Workspace not found", the error was swallowed by its catch, and no agent_update was emitted — live model/thinking switches and status updates silently stopped. Caught by the live-preferences e2e suite. The fallback builds a directory-scoped project placement keyed by the path. That key is a project grouping key (non-git projects group by path), not a workspace id, so it stays within the opaque-id rule. * Always run server worktree archive, even without a resolved workspace Archiving bailed out entirely when the workspace was not found in the client store, so a race or stale state could make "archive" do nothing server-side with only a console.warn. The server archive is keyed by worktreePath, which is always available, so it now runs regardless; only the optimistic client-side updates (keyed by workspace id) are gated on the workspace being resolved. * Expect a directory-scoped placement for unregistered agent dirs This unit test asserted the no-placement behavior reverted in the live agent-update fix, which had broken live model/thinking switching. Update it to expect the directory-scoped placement now emitted for an agent in a directory with no registered workspace. * Fix opaque workspace routing in app E2E * Preserve workspace IDs during partial bootstrap * Fix archive flows for opaque workspace IDs * Stop treating opaque workspace IDs as filesystem paths Workspace IDs are opaque (wks_<hex>), but several call sites still passed the id where a directory was expected, which broke those flows for opaque IDs. The branch switcher sent the id as a cwd to branch/stash/checkout git operations, and server archive/reconcile cleanup keyed git-watch and subscription teardown by id, leaking that state. Git and filesystem operations now take the workspace directory; the opaque id is used only for identity and cache keys. Archive/reconcile cleanup routes through a single teardownArchivedWorkspace helper that keeps the key split explicit: runtime store by id, git watch and subscription by cwd. Path-derived grouping keys are renamed to directory keys, and the helpers are split into workspace-identity and workspace-directory so the id-vs-path boundary is obvious.
This commit is contained in:
@@ -230,9 +230,7 @@ describe("translation resources", () => {
|
||||
expect(en.workspace.browser.unavailable.title).toBe("Browser is desktop-only");
|
||||
expect(en.workspace.browser.controls.enterUrl).toBe("Enter URL");
|
||||
expect(en.workspace.terminal.hostDisconnected).toBe("Host is not connected");
|
||||
expect(en.panels.file.executionDirectoryMissing).toBe(
|
||||
"Workspace execution directory not found.",
|
||||
);
|
||||
expect(en.panels.file.directoryMissing).toBe("Workspace directory not found.");
|
||||
});
|
||||
|
||||
it("includes workspace Git and review keys for the Batch 4B migration", () => {
|
||||
|
||||
@@ -1292,7 +1292,7 @@ export const ar: TranslationResources = {
|
||||
creatingAgent: "وكيل الخلق",
|
||||
},
|
||||
file: {
|
||||
executionDirectoryMissing: "لم يتم العثور على دليل تنفيذ Workspace.",
|
||||
directoryMissing: "لم يتم العثور على دليل Workspace.",
|
||||
loading: "جارٍ تحميل الملف...",
|
||||
noPreview: "لا تتوفر معاينة",
|
||||
binaryPreviewUnavailable: "المعاينة الثنائية غير متاحة",
|
||||
|
||||
@@ -1298,7 +1298,7 @@ export const en = {
|
||||
creatingAgent: "Creating agent",
|
||||
},
|
||||
file: {
|
||||
executionDirectoryMissing: "Workspace execution directory not found.",
|
||||
directoryMissing: "Workspace directory not found.",
|
||||
loading: "Loading file...",
|
||||
noPreview: "No preview available",
|
||||
binaryPreviewUnavailable: "Binary preview unavailable",
|
||||
|
||||
@@ -1327,7 +1327,7 @@ export const es: TranslationResources = {
|
||||
creatingAgent: "Agente creador",
|
||||
},
|
||||
file: {
|
||||
executionDirectoryMissing: "No se encontró el directorio de ejecución deWorkspace.",
|
||||
directoryMissing: "No se encontró el directorio de Workspace.",
|
||||
loading: "Cargando archivo...",
|
||||
noPreview: "No hay vista previa disponible",
|
||||
binaryPreviewUnavailable: "Vista previa binaria no disponible",
|
||||
|
||||
@@ -1330,7 +1330,7 @@ export const fr: TranslationResources = {
|
||||
creatingAgent: "Agent créateur",
|
||||
},
|
||||
file: {
|
||||
executionDirectoryMissing: "Répertoire d'exécutionWorkspaceintrouvable.",
|
||||
directoryMissing: "Répertoire Workspace introuvable.",
|
||||
loading: "Chargement du fichier...",
|
||||
noPreview: "Aucun aperçu disponible",
|
||||
binaryPreviewUnavailable: "Aperçu binaire indisponible",
|
||||
|
||||
@@ -1319,7 +1319,7 @@ export const ru: TranslationResources = {
|
||||
creatingAgent: "Создание агента",
|
||||
},
|
||||
file: {
|
||||
executionDirectoryMissing: "Каталог выполнения Workspace не найден.",
|
||||
directoryMissing: "Каталог Workspace не найден.",
|
||||
loading: "Загрузка файла...",
|
||||
noPreview: "Предварительный просмотр недоступен",
|
||||
binaryPreviewUnavailable: "Предварительный просмотр двоичного файла недоступен.",
|
||||
|
||||
@@ -1275,7 +1275,7 @@ export const zhCN: TranslationResources = {
|
||||
creatingAgent: "正在创建 Agent",
|
||||
},
|
||||
file: {
|
||||
executionDirectoryMissing: "未找到 workspace 执行目录。",
|
||||
directoryMissing: "未找到 workspace 目录。",
|
||||
loading: "正在加载文件...",
|
||||
noPreview: "没有可用预览",
|
||||
binaryPreviewUnavailable: "二进制预览不可用",
|
||||
|
||||
Reference in New Issue
Block a user