refactor: implement agent cancellation and deletion with UI controls

Add cancel button during agent runs, real-time mode toggle in all states, and agent deletion via long-press action sheet. Server now handles cancel_agent_request and delete_agent_request messages, cleaning up agent state and notifying clients.
This commit is contained in:
Mohamed Boudra
2025-11-15 18:13:04 +01:00
parent 66b465a132
commit 2a02f41182
6 changed files with 461 additions and 95 deletions
+22
View File
@@ -293,6 +293,11 @@ export const DeleteConversationRequestMessageSchema = z.object({
conversationId: z.string(),
});
export const DeleteAgentRequestMessageSchema = z.object({
type: z.literal("delete_agent_request"),
agentId: z.string(),
});
export const SetRealtimeModeMessageSchema = z.object({
type: z.literal("set_realtime_mode"),
enabled: z.boolean(),
@@ -338,6 +343,11 @@ export const RefreshAgentRequestMessageSchema = z.object({
requestId: z.string().optional(),
});
export const CancelAgentRequestMessageSchema = z.object({
type: z.literal("cancel_agent_request"),
agentId: z.string(),
});
export const ListPersistedAgentsRequestMessageSchema = z.object({
type: z.literal("list_persisted_agents_request"),
provider: AgentProviderSchema.optional(),
@@ -406,12 +416,14 @@ export const SessionInboundMessageSchema = z.discriminatedUnion("type", [
LoadConversationRequestMessageSchema,
ListConversationsRequestMessageSchema,
DeleteConversationRequestMessageSchema,
DeleteAgentRequestMessageSchema,
SetRealtimeModeMessageSchema,
SendAgentMessageSchema,
SendAgentAudioSchema,
CreateAgentRequestMessageSchema,
ResumeAgentRequestMessageSchema,
RefreshAgentRequestMessageSchema,
CancelAgentRequestMessageSchema,
InitializeAgentRequestMessageSchema,
SetAgentModeMessageSchema,
AgentPermissionResponseMessageSchema,
@@ -593,6 +605,13 @@ export const AgentPermissionResolvedMessageSchema = z.object({
}),
});
export const AgentDeletedMessageSchema = z.object({
type: z.literal("agent_deleted"),
payload: z.object({
agentId: z.string(),
}),
});
const PersistedAgentDescriptorPayloadSchema = z.object({
provider: AgentProviderSchema,
sessionId: z.string(),
@@ -649,6 +668,7 @@ export const SessionOutboundMessageSchema = z.discriminatedUnion("type", [
DeleteConversationResponseMessageSchema,
AgentPermissionRequestMessageSchema,
AgentPermissionResolvedMessageSchema,
AgentDeletedMessageSchema,
ListPersistedAgentsResponseSchema,
GitDiffResponseSchema,
FileExplorerResponseSchema,
@@ -677,6 +697,7 @@ export type ListConversationsResponseMessage = z.infer<typeof ListConversationsR
export type DeleteConversationResponseMessage = z.infer<typeof DeleteConversationResponseMessageSchema>;
export type AgentPermissionRequestMessage = z.infer<typeof AgentPermissionRequestMessageSchema>;
export type AgentPermissionResolvedMessage = z.infer<typeof AgentPermissionResolvedMessageSchema>;
export type AgentDeletedMessage = z.infer<typeof AgentDeletedMessageSchema>;
export type ListPersistedAgentsResponseMessage = z.infer<typeof ListPersistedAgentsResponseSchema>;
// Type exports for payload types
@@ -689,6 +710,7 @@ export type SendAgentMessage = z.infer<typeof SendAgentMessageSchema>;
export type SendAgentAudio = z.infer<typeof SendAgentAudioSchema>;
export type CreateAgentRequestMessage = z.infer<typeof CreateAgentRequestMessageSchema>;
export type ResumeAgentRequestMessage = z.infer<typeof ResumeAgentRequestMessageSchema>;
export type DeleteAgentRequestMessage = z.infer<typeof DeleteAgentRequestMessageSchema>;
export type ListPersistedAgentsRequestMessage = z.infer<typeof ListPersistedAgentsRequestMessageSchema>;
export type InitializeAgentRequestMessage = z.infer<typeof InitializeAgentRequestMessageSchema>;
export type SetAgentModeMessage = z.infer<typeof SetAgentModeMessageSchema>;
+56
View File
@@ -529,6 +529,10 @@ export class Session {
await this.handleDeleteConversation(msg.conversationId);
break;
case "delete_agent_request":
await this.handleDeleteAgentRequest(msg.agentId);
break;
case "set_realtime_mode":
this.handleSetRealtimeMode(msg.enabled);
break;
@@ -558,6 +562,10 @@ export class Session {
await this.handleRefreshAgentRequest(msg);
break;
case "cancel_agent_request":
await this.handleCancelAgentRequest(msg.agentId);
break;
case "initialize_agent_request":
await this.handleInitializeAgentRequest(msg.agentId, msg.requestId);
break;
@@ -685,6 +693,38 @@ export class Session {
}
}
private async handleDeleteAgentRequest(agentId: string): Promise<void> {
console.log(
`[Session ${this.clientId}] Deleting agent ${agentId} from registry`
);
try {
await this.agentManager.closeAgent(agentId);
} catch (error: any) {
console.warn(
`[Session ${this.clientId}] Failed to close agent ${agentId} during delete:`,
error
);
}
try {
await this.agentRegistry.remove(agentId);
} catch (error: any) {
console.error(
`[Session ${this.clientId}] Failed to remove agent ${agentId} from registry:`,
error
);
}
this.agentTitleCache.delete(agentId);
this.emit({
type: "agent_deleted",
payload: {
agentId,
},
});
}
/**
* Handle realtime mode toggle
*/
@@ -1053,6 +1093,22 @@ export class Session {
}
}
private async handleCancelAgentRequest(agentId: string): Promise<void> {
console.log(
`[Session ${this.clientId}] Cancel request received for agent ${agentId}`
);
try {
await this.interruptAgentIfRunning(agentId);
} catch (error) {
this.handleAgentRunError(
agentId,
error,
"Failed to cancel running agent on request"
);
}
}
private async buildAgentSessionConfig(
config: AgentSessionConfig,
worktreeName?: string