jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Keep workspaces responsive across app-wide routes (#2791)

Browse Source 
* perf(app): retain inactive workspace screens

App-wide routes cleared the active workspace selection, which removed the retained workspace deck from the React tree and made returning rebuild every panel. Keep mounted deck entries inactive across those routes and suspend inactive panel subscriptions so state is preserved without background work.

* perf(app): suspend remaining inactive queries

Retained composers and commit diff panels still subscribed through query hooks that did not receive panel activity. Propagate the existing activity gate so app-wide routes leave those hidden surfaces dormant.

* refactor(app): separate panel activity from connectivity

A hidden retained panel is still connected to its host. Keep connectivity truthful, pause work inside query and stream owners, and preserve terminal emulator identity while its stream is detached.

* test(app): target active retained controls

* fix(app): retain compact and terminal route content

* fix(app): hide inactive workspace overlays
This commit is contained in:
Mohamed Boudra
2026-08-02 14:32:17 +02:00
committed by GitHub
parent 26bdb1d171
commit 2b474f7df9
17 changed files with 355 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app/e2e/browser/new-workspace-codex-mode-preferences.spec.ts
+16 -14
View File
@@ -88,7 +88,7 @@ async function readCodexModePreference(page: Page): Promise<unknown> {
}
async function selectMode(page: Page, label: string): Promise<void> {
const modeControl = page.getByTestId("mode-control").first();
const modeControl = page.getByRole("button", { name: /^Select agent mode \(/ });
await expect(modeControl).toBeVisible({ timeout: 30_000 });
await modeControl.click();
@@ -169,12 +169,14 @@ test.describe("New workspace Codex mode preferences", () => {
projectDisplayName: seeded.projectDisplayName,
});
await expect(page.getByTestId("mode-control").first()).toContainText("Default permissions", {
timeout: 30_000,
});
await expect(
page.getByRole("button", { name: "Select agent mode (Default permissions)" }),
).toBeVisible({ timeout: 30_000 });
await expectThinkingOptionsFit(page);
await selectMode(page, "Full access");
await expect(page.getByTestId("mode-control").first()).toContainText("Full access");
await expect(
page.getByRole("button", { name: "Select agent mode (Full access)" }),
).toBeVisible();
await submitNewWorkspacePrompt(page, "Keep Codex full access selected globally.");
const createAgentRequest = await createAgentRecorder.waitForCreateAgentRequest();
@@ -210,14 +212,14 @@ test.describe("New workspace Codex mode preferences", () => {
workspaceId: seeded.workspaceId,
agentId: agent.id,
});
await expect(page.getByTestId("mode-control").first()).toContainText("Default permissions", {
timeout: 30_000,
});
await expect(
page.getByRole("button", { name: "Select agent mode (Default permissions)" }),
).toBeVisible({ timeout: 30_000 });
await selectMode(page, "Full access");
await expect(page.getByTestId("mode-control").first()).toContainText("Full access", {
timeout: 30_000,
});
await expect(
page.getByRole("button", { name: "Select agent mode (Full access)" }),
).toBeVisible({ timeout: 30_000 });
await openGlobalNewWorkspaceComposer(page);
await selectNewWorkspaceProject(page, {
@@ -225,9 +227,9 @@ test.describe("New workspace Codex mode preferences", () => {
projectDisplayName: seeded.projectDisplayName,
});
await expect(page.getByTestId("mode-control").first()).toContainText("Full access", {
timeout: 30_000,
});
await expect(
page.getByRole("button", { name: "Select agent mode (Full access)" }),
).toBeVisible({ timeout: 30_000 });
} finally {
await seeded.cleanup();
}