Keep browser sign-ins across tabs and restarts (#2089)

* feat(desktop): share persistent browser data across tabs

Keep browser sign-ins and site storage across tabs and app restarts, with a Settings action to clear the shared profile.

* fix(settings): prevent duplicate browser data clears

* fix(desktop): complete browser data cleanup

Clear legacy per-tab profiles after upgrades and localize the browser data settings in every supported language.

* fix(desktop): close browser profile cleanup races
This commit is contained in:
Mohamed Boudra
2026-07-16 00:40:24 +08:00
committed by GitHub
parent 9423b091b9
commit 328361667f
32 changed files with 1413 additions and 148 deletions
@@ -0,0 +1,80 @@
import { useCallback, useRef, useState } from "react";
import { Text, View } from "react-native";
import { useTranslation } from "react-i18next";
import { Button } from "@/components/ui/button";
import { useToast } from "@/contexts/toast-context";
import { getDesktopHost } from "@/desktop/host";
import { SettingsSection } from "@/screens/settings/settings-section";
import { useBrowserStore } from "@/stores/browser-store";
import { settingsStyles } from "@/styles/settings";
import { confirmDialog } from "@/utils/confirm-dialog";
export function BrowserDataSection() {
const { t } = useTranslation();
const toast = useToast();
const clearInFlightRef = useRef(false);
const [isClearing, setIsClearing] = useState(false);
const handleClear = useCallback(async () => {
if (clearInFlightRef.current) {
return;
}
clearInFlightRef.current = true;
setIsClearing(true);
try {
const confirmed = await confirmDialog({
title: t("settings.general.browserData.confirmTitle"),
message: t("settings.general.browserData.confirmMessage"),
confirmLabel: t("settings.general.browserData.clear"),
cancelLabel: t("common.actions.cancel"),
destructive: true,
});
if (!confirmed) {
return;
}
const clearProfile = getDesktopHost()?.browser?.clearProfile;
if (!clearProfile) {
throw new Error("Electron browser profile bridge is unavailable");
}
await clearProfile(Object.keys(useBrowserStore.getState().browsersById));
toast.show(t("settings.general.browserData.success"), { variant: "success" });
} catch {
toast.error(t("settings.general.browserData.error"));
} finally {
clearInFlightRef.current = false;
setIsClearing(false);
}
}, [t, toast]);
const clearButtonLabel = isClearing
? t("settings.general.browserData.clearing")
: t("settings.general.browserData.clear");
return (
<SettingsSection title={t("settings.general.browserData.title")}>
<View style={settingsStyles.card}>
<View style={settingsStyles.row}>
<View style={settingsStyles.rowContent}>
<Text style={settingsStyles.rowTitle}>
{t("settings.general.browserData.siteData")}
</Text>
<Text style={settingsStyles.rowHint}>
{t("settings.general.browserData.description")}
</Text>
</View>
<Button
variant="destructive"
size="sm"
loading={isClearing}
disabled={isClearing}
onPress={handleClear}
>
{clearButtonLabel}
</Button>
</View>
</View>
</SettingsSection>
);
}