test(app): align Changes regressions with canvas geometry

This commit is contained in:
Mohamed Boudra
2026-08-17 21:15:17 +02:00
parent 311eb48922
commit 331bbd9faa
@@ -326,9 +326,9 @@ test("every interactive file header has the same hover feedback", async ({ page
); );
await expect await expect
.poll(() => .poll(() =>
first.evaluate((element) => getComputedStyle(element.parentElement!).borderTopColor), first.evaluate((element) => getComputedStyle(element.parentElement!).borderTopWidth),
) )
.toBe("rgba(0, 0, 0, 0)"); .toBe("0px");
await first.hover(); await first.hover();
const hoverBackground = await first.evaluate( const hoverBackground = await first.evaluate(
@@ -344,12 +344,12 @@ test("every interactive file header has the same hover feedback", async ({ page
first.evaluate((element) => getComputedStyle(element.parentElement!).backgroundColor), first.evaluate((element) => getComputedStyle(element.parentElement!).backgroundColor),
) )
.toBe(normalBackground); .toBe(normalBackground);
const [sharedBorder, suppressedDuplicateBorder] = await Promise.all([ const [sharedBorder, secondTopBorderWidth] = await Promise.all([
first.evaluate((element) => getComputedStyle(element.parentElement!).borderBottomColor), first.evaluate((element) => getComputedStyle(element.parentElement!).borderBottomColor),
second.evaluate((element) => getComputedStyle(element.parentElement!).borderTopColor), second.evaluate((element) => getComputedStyle(element.parentElement!).borderTopWidth),
]); ]);
expect(sharedBorder).not.toBe("rgba(0, 0, 0, 0)"); expect(sharedBorder).not.toBe("rgba(0, 0, 0, 0)");
expect(suppressedDuplicateBorder).toBe("rgba(0, 0, 0, 0)"); expect(secondTopBorderWidth).toBe("0px");
await first.hover(); await first.hover();
await expect await expect
@@ -684,7 +684,6 @@ test("desktop Changes toggles a navigation tree beside the expanded diff documen
); );
await expect(tree.getByTestId("diff-tree-file-0")).toBeVisible(); await expect(tree.getByTestId("diff-tree-file-0")).toBeVisible();
await expect(tree.getByTestId("diff-folder-src-toggle").locator("svg")).toHaveCount(1); await expect(tree.getByTestId("diff-folder-src-toggle").locator("svg")).toHaveCount(1);
await expect(tree.getByTestId("diff-tree-file-0-toggle").locator("svg")).toHaveCount(1);
const folderToggleBounds = await tree.getByTestId("diff-folder-src-toggle").boundingBox(); const folderToggleBounds = await tree.getByTestId("diff-folder-src-toggle").boundingBox();
const folderChevronBounds = await tree const folderChevronBounds = await tree
.getByTestId("diff-folder-src-toggle") .getByTestId("diff-folder-src-toggle")
@@ -706,7 +705,7 @@ test("desktop Changes toggles a navigation tree beside the expanded diff documen
.boundingBox(); .boundingBox();
expect(folderLabelBounds).not.toBeNull(); expect(folderLabelBounds).not.toBeNull();
expect(fileLabelBounds).not.toBeNull(); expect(fileLabelBounds).not.toBeNull();
expect(fileLabelBounds!.x - folderLabelBounds!.x).toBeCloseTo(16, 0); expect(fileLabelBounds!.x - folderLabelBounds!.x).toBeCloseTo(12, 0);
const folderToggle = tree.getByTestId("diff-folder-src-toggle"); const folderToggle = tree.getByTestId("diff-folder-src-toggle");
await folderToggle.click(); await folderToggle.click();
@@ -798,7 +797,7 @@ test("canvas diff stays sharp while its workspace pane is resized", async ({ pag
return frames; return frames;
}); });
for (const frame of resizeFrames) { for (const frame of resizeFrames) {
expect(frame.cssWidth).toBeCloseTo(frame.bitmapWidth, 0); expect(Math.abs(frame.cssWidth - frame.bitmapWidth)).toBeLessThan(1);
} }
await expect await expect
.poll(async () => { .poll(async () => {