fix(app): validate persisted client state (#3289)

* fix(app): validate persisted client state

Persisted replica data could satisfy TypeScript through an assertion while missing fields required by renderers. Treat every AsyncStorage value as untrusted input, clear values that fail strict schemas, and version the replica DTO so incompatible caches cannot hydrate.

* fix(app): preserve validated legacy state

* fix(app): preserve validated preferences

Preserve supported legacy location fields and every shipped theme while keeping unknown persisted fields rejected. Align browser test seeds with the current preference shape so strict validation exercises the intended provider.

* fix(app): migrate legacy agent preferences

Released clients stored host/location fields and per-provider thinkingOptionId together. Migrate those exact strict bytes into current preferences without admitting unknown fields.

* fix(app): preserve drafts with legacy reviews

Accept the exact strict shape released for workspace review attachments so migration can discard that obsolete attachment without clearing every persisted draft.

packages/app/src/contexts/sidebar-callout-context.tsx

@@ -13,9 +13,9 @@ import { useStableEvent } from "@/hooks/use-stable-event";
 import {
   clearSidebarCallouts,
   createSidebarCalloutState,
+  DismissedCalloutKeysSchema,
   dismissSidebarCallout,
   loadDismissedCalloutKeys,
-  parseDismissedCalloutKeys,
   selectActiveSidebarCallout,
   serializeDismissedCalloutKeys,
   showSidebarCallout,
@@ -24,6 +24,7 @@ import {
   type SidebarCalloutState,
   unregisterSidebarCallout,
 } from "./sidebar-callout-state";
+import { readValidatedJson } from "@/storage/validated-storage";
 
 export type { SidebarCalloutOptions } from "./sidebar-callout-state";
 
@@ -62,8 +63,12 @@ export function SidebarCalloutProvider({ children }: { children: ReactNode }) {
     async function loadDismissedKeys(): Promise<void> {
       let dismissedKeys: ReadonlySet<string>;
       try {
-        const value = await AsyncStorage.getItem(DISMISSED_CALLOUTS_STORAGE_KEY);
-        dismissedKeys = parseDismissedCalloutKeys(value);
+        const value = await readValidatedJson(
+          AsyncStorage,
+          DISMISSED_CALLOUTS_STORAGE_KEY,
+          DismissedCalloutKeysSchema,
+        );
+        dismissedKeys = new Set(value ?? []);
       } catch (error) {
         console.error("[SidebarCallouts] Failed to load dismissed callouts", error);
         dismissedKeys = stateRef.current.dismissedKeys;

packages/app/src/contexts/sidebar-callout-state.test.ts

@@ -4,7 +4,6 @@ import {
   createSidebarCalloutState,
   dismissSidebarCallout,
   loadDismissedCalloutKeys,
-  parseDismissedCalloutKeys,
   selectActiveSidebarCallout,
   serializeDismissedCalloutKeys,
   showSidebarCallout,
@@ -118,12 +117,6 @@ describe("sidebar callout state", () => {
     expect(selectActiveSidebarCallout(state)?.title).toBe("Update available");
   });
 
-  it("parses stored dismissal keys defensively", () => {
-    expect(parseDismissedCalloutKeys(JSON.stringify(["a", 4, "b"]))).toEqual(new Set(["a", "b"]));
-    expect(parseDismissedCalloutKeys("{")).toEqual(new Set());
-    expect(parseDismissedCalloutKeys(JSON.stringify({ key: "a" }))).toEqual(new Set());
-  });
-
   it("clears visible callouts without dropping dismissal state", () => {
     let state = loadDismissedCalloutKeys(createSidebarCalloutState(), new Set(["dismissed"]));
     state = showSidebarCallout(state, { id: "visible", title: "Visible" }).state;

packages/app/src/contexts/sidebar-callout-state.ts

@@ -1,4 +1,5 @@
 import type { ReactNode } from "react";
+import { z } from "zod";
 import type { SidebarCalloutAction, SidebarCalloutVariant } from "@/components/sidebar-callout";
 
 export interface SidebarCalloutOptions {
@@ -44,21 +45,7 @@ export function normalizeDismissalKey(key: string | null | undefined): string |
   return trimmed ? trimmed : null;
 }
 
-export function parseDismissedCalloutKeys(value: string | null): Set<string> {
-  if (!value) {
-    return new Set();
-  }
-
-  try {
-    const parsed = JSON.parse(value) as unknown;
-    if (!Array.isArray(parsed)) {
-      return new Set();
-    }
-    return new Set(parsed.filter((entry): entry is string => typeof entry === "string"));
-  } catch {
-    return new Set();
-  }
-}
+export const DismissedCalloutKeysSchema = z.array(z.string());
 
 export function serializeDismissedCalloutKeys(keys: ReadonlySet<string>): string {
   return JSON.stringify([...keys]);