Extract worktree setup callout policy (#878)

2026-05-10 07:44:44 +00:00
parent 5e64a1340c
commit 3f6b84899a
4 changed files with 211 additions and 332 deletions
@@ -0,0 +1,103 @@
+import { describe, expect, it } from "vitest";
+import {
+  buildWorktreeSetupCalloutPolicy,
+  selectActiveGitWorkspaceProject,
+  shouldShowWorktreeSetupCallout,
+  type WorktreeSetupWorkspaceInput,
+} from "./worktree-setup-callout-policy";
+
+function gitWorkspace(
+  overrides: Partial<WorktreeSetupWorkspaceInput> = {},
+): WorktreeSetupWorkspaceInput {
+  return {
+    projectId: "project-1",
+    projectKind: "git",
+    projectRootPath: "/repo/project-1",
+    project: { checkout: { mainRepoRoot: "/repo/main-project-1" } },
+    ...overrides,
+  };
+}
+
+describe("selectActiveGitWorkspaceProject", () => {
+  it("selects the active git workspace project from checkout metadata", () => {
+    expect(selectActiveGitWorkspaceProject("server-1", gitWorkspace())).toEqual({
+      serverId: "server-1",
+      projectKey: "project-1",
+      repoRoot: "/repo/main-project-1",
+    });
+  });
+
+  it("falls back to the workspace project root when checkout metadata has no main root", () => {
+    expect(
+      selectActiveGitWorkspaceProject(
+        "server-1",
+        gitWorkspace({ project: { checkout: { mainRepoRoot: null } } }),
+      ),
+    ).toEqual({
+      serverId: "server-1",
+      projectKey: "project-1",
+      repoRoot: "/repo/project-1",
+    });
+  });
+
+  it("ignores non-git workspaces and blank project coordinates", () => {
+    expect(
+      selectActiveGitWorkspaceProject("server-1", gitWorkspace({ projectKind: "local" })),
+    ).toBe(null);
+    expect(selectActiveGitWorkspaceProject("server-1", gitWorkspace({ projectId: " " }))).toBe(
+      null,
+    );
+    expect(
+      selectActiveGitWorkspaceProject(
+        "server-1",
+        gitWorkspace({ projectRootPath: " ", project: null }),
+      ),
+    ).toBe(null);
+  });
+});
+
+describe("shouldShowWorktreeSetupCallout", () => {
+  it("shows the callout when paseo config was read and setup commands are missing", () => {
+    expect(shouldShowWorktreeSetupCallout({ ok: true, config: {} })).toBe(true);
+    expect(shouldShowWorktreeSetupCallout({ ok: true, config: null })).toBe(true);
+  });
+
+  it("does not show the callout when setup commands are present", () => {
+    expect(
+      shouldShowWorktreeSetupCallout({ ok: true, config: { worktree: { setup: "npm install" } } }),
+    ).toBe(false);
+    expect(
+      shouldShowWorktreeSetupCallout({
+        ok: true,
+        config: { worktree: { setup: [" ", "npm install"] } },
+      }),
+    ).toBe(false);
+  });
+
+  it("does not show the callout when reading paseo config fails or has not completed", () => {
+    expect(shouldShowWorktreeSetupCallout(undefined)).toBe(false);
+    expect(shouldShowWorktreeSetupCallout({ ok: false })).toBe(false);
+  });
+});
+
+describe("buildWorktreeSetupCalloutPolicy", () => {
+  it("builds the stable sidebar callout identity and action route", () => {
+    expect(
+      buildWorktreeSetupCalloutPolicy({
+        serverId: "server-1",
+        projectKey: "project-1",
+        repoRoot: "/repo/project-1",
+      }),
+    ).toEqual({
+      id: "worktree-setup-missing:project-1",
+      dismissalKey: "worktree-setup-missing:project-1",
+      priority: 100,
+      title: "Set up worktree scripts",
+      description:
+        "Add setup commands so new worktrees can install dependencies and prepare themselves automatically.",
+      actionLabel: "Open project settings",
+      projectSettingsRoute: "/settings/projects/project-1",
+      testID: "worktree-setup-callout-project-1",
+    });
+  });
+});