schedule: add paseo schedule update to edit schedules in place (#694)
* schedule: add `paseo schedule update` to edit schedules in place Editing a schedule today requires delete+recreate, losing run history and the schedule id. This adds an additive RPC and CLI command that patches name, prompt, cadence, new-agent target fields, max-runs, and expires-in without touching runs or in-flight executions. nextRunAt is recomputed only when the cadence actually changes. * schedule(cli): share cadence flag parser between create and update Both paths were turning --every/--cron into a ScheduleCadence with near-identical code. Extract `parseCadenceFromFlags` so the literals and the exclusivity check live in one place; create wraps it to require a value, update lets it stay optional.
This commit is contained in:
@@ -9,6 +9,7 @@ import { runPauseCommand } from "./pause.js";
|
|||||||
import { runResumeCommand } from "./resume.js";
|
import { runResumeCommand } from "./resume.js";
|
||||||
import { runDeleteCommand } from "./delete.js";
|
import { runDeleteCommand } from "./delete.js";
|
||||||
import { runRunOnceCommand } from "./run-once.js";
|
import { runRunOnceCommand } from "./run-once.js";
|
||||||
|
import { runUpdateCommand } from "./update.js";
|
||||||
|
|
||||||
export function createScheduleCommand(): Command {
|
export function createScheduleCommand(): Command {
|
||||||
const schedule = new Command("schedule").description("Manage recurring schedules");
|
const schedule = new Command("schedule").description("Manage recurring schedules");
|
||||||
@@ -74,5 +75,27 @@ export function createScheduleCommand(): Command {
|
|||||||
.argument("<id>", "Schedule ID"),
|
.argument("<id>", "Schedule ID"),
|
||||||
).action(withOutput(runRunOnceCommand));
|
).action(withOutput(runRunOnceCommand));
|
||||||
|
|
||||||
|
addJsonAndDaemonHostOptions(
|
||||||
|
schedule
|
||||||
|
.command("update")
|
||||||
|
.description("Update an existing schedule in place")
|
||||||
|
.argument("<id>", "Schedule ID")
|
||||||
|
.option("--every <duration>", "Switch to fixed interval cadence (for example: 5m, 1h)")
|
||||||
|
.option("--cron <expr>", "Switch to cron cadence expression")
|
||||||
|
.option("--name <name>", "Rename the schedule (empty string clears the name)")
|
||||||
|
.option("--prompt <text>", "Replace the schedule prompt")
|
||||||
|
.option(
|
||||||
|
"--provider <provider>",
|
||||||
|
"New agent provider, or provider/model (only for new-agent target)",
|
||||||
|
)
|
||||||
|
.option("--model <model>", "New agent model (only for new-agent target)")
|
||||||
|
.option("--mode <mode>", "New agent provider mode (only for new-agent target)")
|
||||||
|
.option("--cwd <path>", "New working directory (only for new-agent target)")
|
||||||
|
.option("--max-runs <n>", "Set or change maximum number of runs")
|
||||||
|
.option("--no-max-runs", "Clear the max-runs limit")
|
||||||
|
.option("--expires-in <duration>", "Set or change time to live for the schedule")
|
||||||
|
.option("--no-expires-in", "Clear the expiration"),
|
||||||
|
).action(withOutput(runUpdateCommand));
|
||||||
|
|
||||||
return schedule;
|
return schedule;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
|
import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
|
||||||
|
|
||||||
import { parseScheduleCreateInput } from "./shared.js";
|
import { parseScheduleCreateInput, parseScheduleUpdateInput } from "./shared.js";
|
||||||
|
|
||||||
const baseOptions = {
|
const baseOptions = {
|
||||||
prompt: "do the thing",
|
prompt: "do the thing",
|
||||||
@@ -106,3 +106,127 @@ describe("parseScheduleCreateInput first-run timing", () => {
|
|||||||
);
|
);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("parseScheduleUpdateInput", () => {
|
||||||
|
test("rejects calls with no fields to update", () => {
|
||||||
|
expect(() => parseScheduleUpdateInput({ id: "abc" })).toThrow(
|
||||||
|
expect.objectContaining({ code: "NO_UPDATES" }),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("parses prompt and name updates", () => {
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", prompt: " hello ", name: " named " })).toEqual(
|
||||||
|
{
|
||||||
|
id: "abc",
|
||||||
|
name: "named",
|
||||||
|
prompt: "hello",
|
||||||
|
},
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("name set to empty string clears the name", () => {
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", name: "" })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
name: null,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("rejects empty prompt", () => {
|
||||||
|
expect(() => parseScheduleUpdateInput({ id: "abc", prompt: " " })).toThrow(
|
||||||
|
expect.objectContaining({ code: "INVALID_PROMPT" }),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("parses --every cadence", () => {
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", every: "5m" })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
cadence: { type: "every", everyMs: 5 * 60_000 },
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("parses --cron cadence", () => {
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", cron: "30 9 * * *" })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
cadence: { type: "cron", expression: "30 9 * * *" },
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("rejects passing both --every and --cron", () => {
|
||||||
|
expect(() => parseScheduleUpdateInput({ id: "abc", every: "5m", cron: "0 9 * * *" })).toThrow(
|
||||||
|
expect.objectContaining({ code: "INVALID_CADENCE" }),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("parses provider/model shorthand and explicit mode", () => {
|
||||||
|
expect(
|
||||||
|
parseScheduleUpdateInput({
|
||||||
|
id: "abc",
|
||||||
|
provider: "codex/gpt-5",
|
||||||
|
mode: "full-access",
|
||||||
|
cwd: "/tmp/proj",
|
||||||
|
}),
|
||||||
|
).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
newAgentConfig: {
|
||||||
|
provider: "codex",
|
||||||
|
model: "gpt-5",
|
||||||
|
modeId: "full-access",
|
||||||
|
cwd: "/tmp/proj",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("--mode with empty value clears the modeId", () => {
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", mode: "" })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
newAgentConfig: { modeId: null },
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("rejects empty --cwd", () => {
|
||||||
|
expect(() => parseScheduleUpdateInput({ id: "abc", cwd: " " })).toThrow(
|
||||||
|
expect.objectContaining({ code: "INVALID_CWD" }),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("--max-runs sets a positive integer; --no-max-runs clears", () => {
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", maxRuns: "3" })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
maxRuns: 3,
|
||||||
|
});
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", clearMaxRuns: true })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
maxRuns: null,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("rejects passing both --max-runs and --no-max-runs", () => {
|
||||||
|
expect(() => parseScheduleUpdateInput({ id: "abc", maxRuns: "3", clearMaxRuns: true })).toThrow(
|
||||||
|
expect.objectContaining({ code: "CONFLICTING_MAX_RUNS" }),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("--expires-in computes an absolute timestamp; --no-expires-in clears", () => {
|
||||||
|
vi.useFakeTimers();
|
||||||
|
vi.setSystemTime(new Date("2026-01-01T00:00:00.000Z"));
|
||||||
|
try {
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", expiresIn: "1h" })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
expiresAt: "2026-01-01T01:00:00.000Z",
|
||||||
|
});
|
||||||
|
} finally {
|
||||||
|
vi.useRealTimers();
|
||||||
|
}
|
||||||
|
|
||||||
|
expect(parseScheduleUpdateInput({ id: "abc", clearExpires: true })).toEqual({
|
||||||
|
id: "abc",
|
||||||
|
expiresAt: null,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("rejects passing both --expires-in and --no-expires-in", () => {
|
||||||
|
expect(() =>
|
||||||
|
parseScheduleUpdateInput({ id: "abc", expiresIn: "1h", clearExpires: true }),
|
||||||
|
).toThrow(expect.objectContaining({ code: "CONFLICTING_EXPIRES" }));
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -7,6 +7,8 @@ import type {
|
|||||||
ScheduleListItem,
|
ScheduleListItem,
|
||||||
ScheduleRecord,
|
ScheduleRecord,
|
||||||
ScheduleTarget,
|
ScheduleTarget,
|
||||||
|
UpdateScheduleInput,
|
||||||
|
UpdateScheduleNewAgentConfig,
|
||||||
} from "./types.js";
|
} from "./types.js";
|
||||||
import { parseDuration } from "../../utils/duration.js";
|
import { parseDuration } from "../../utils/duration.js";
|
||||||
import { resolveProviderAndModel } from "../../utils/provider-model.js";
|
import { resolveProviderAndModel } from "../../utils/provider-model.js";
|
||||||
@@ -145,18 +147,14 @@ export function parseScheduleCreateInput(options: {
|
|||||||
} satisfies CommandError;
|
} satisfies CommandError;
|
||||||
}
|
}
|
||||||
|
|
||||||
const cadenceCount = Number(options.every !== undefined) + Number(options.cron !== undefined);
|
const cadence = parseCadenceFromFlags(options.every, options.cron);
|
||||||
if (cadenceCount !== 1) {
|
if (!cadence) {
|
||||||
throw {
|
throw {
|
||||||
code: "INVALID_CADENCE",
|
code: "INVALID_CADENCE",
|
||||||
message: "Specify exactly one of --every or --cron",
|
message: "Specify exactly one of --every or --cron",
|
||||||
} satisfies CommandError;
|
} satisfies CommandError;
|
||||||
}
|
}
|
||||||
|
|
||||||
const cadence: ScheduleCadence = options.every
|
|
||||||
? { type: "every", everyMs: parseDuration(options.every) }
|
|
||||||
: { type: "cron", expression: options.cron!.trim() };
|
|
||||||
|
|
||||||
const cwdInput = options.cwd?.trim();
|
const cwdInput = options.cwd?.trim();
|
||||||
if (options.host !== undefined && !cwdInput) {
|
if (options.host !== undefined && !cwdInput) {
|
||||||
throw {
|
throw {
|
||||||
@@ -230,6 +228,167 @@ function resolveRunOnCreate(
|
|||||||
return runNow ?? cadenceType === "every";
|
return runNow ?? cadenceType === "every";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export interface ScheduleUpdateOptionsInput {
|
||||||
|
id: string;
|
||||||
|
every?: string;
|
||||||
|
cron?: string;
|
||||||
|
name?: string;
|
||||||
|
prompt?: string;
|
||||||
|
provider?: string;
|
||||||
|
model?: string;
|
||||||
|
mode?: string;
|
||||||
|
cwd?: string;
|
||||||
|
maxRuns?: string;
|
||||||
|
expiresIn?: string;
|
||||||
|
clearMaxRuns?: boolean;
|
||||||
|
clearExpires?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function parseScheduleUpdateInput(options: ScheduleUpdateOptionsInput): UpdateScheduleInput {
|
||||||
|
const id = options.id.trim();
|
||||||
|
if (!id) {
|
||||||
|
throw {
|
||||||
|
code: "INVALID_SCHEDULE_ID",
|
||||||
|
message: "Schedule id cannot be empty",
|
||||||
|
} satisfies CommandError;
|
||||||
|
}
|
||||||
|
|
||||||
|
const cadence = parseCadenceFromFlags(options.every, options.cron);
|
||||||
|
const newAgentConfig = buildNewAgentConfigPatch(options);
|
||||||
|
const maxRuns = parseUpdateMaxRuns(options);
|
||||||
|
const expiresAt = parseUpdateExpiresAt(options);
|
||||||
|
const name = parseUpdateName(options);
|
||||||
|
const prompt = parseUpdatePrompt(options);
|
||||||
|
|
||||||
|
if (
|
||||||
|
name === undefined &&
|
||||||
|
prompt === undefined &&
|
||||||
|
cadence === undefined &&
|
||||||
|
newAgentConfig === undefined &&
|
||||||
|
maxRuns === undefined &&
|
||||||
|
expiresAt === undefined
|
||||||
|
) {
|
||||||
|
throw {
|
||||||
|
code: "NO_UPDATES",
|
||||||
|
message: "Specify at least one field to update",
|
||||||
|
} satisfies CommandError;
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
id,
|
||||||
|
...(name !== undefined ? { name } : {}),
|
||||||
|
...(prompt !== undefined ? { prompt } : {}),
|
||||||
|
...(cadence !== undefined ? { cadence } : {}),
|
||||||
|
...(newAgentConfig !== undefined ? { newAgentConfig } : {}),
|
||||||
|
...(maxRuns !== undefined ? { maxRuns } : {}),
|
||||||
|
...(expiresAt !== undefined ? { expiresAt } : {}),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function parseCadenceFromFlags(
|
||||||
|
every: string | undefined,
|
||||||
|
cron: string | undefined,
|
||||||
|
): ScheduleCadence | undefined {
|
||||||
|
if (every !== undefined && cron !== undefined) {
|
||||||
|
throw {
|
||||||
|
code: "INVALID_CADENCE",
|
||||||
|
message: "Specify at most one of --every or --cron",
|
||||||
|
} satisfies CommandError;
|
||||||
|
}
|
||||||
|
if (every !== undefined) {
|
||||||
|
return { type: "every", everyMs: parseDuration(every) };
|
||||||
|
}
|
||||||
|
if (cron !== undefined) {
|
||||||
|
return { type: "cron", expression: cron.trim() };
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
function parseUpdateMaxRuns(options: ScheduleUpdateOptionsInput): number | null | undefined {
|
||||||
|
if (options.maxRuns !== undefined && options.clearMaxRuns) {
|
||||||
|
throw {
|
||||||
|
code: "CONFLICTING_MAX_RUNS",
|
||||||
|
message: "Use either --max-runs <n> or --no-max-runs, not both",
|
||||||
|
} satisfies CommandError;
|
||||||
|
}
|
||||||
|
if (options.clearMaxRuns) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
if (options.maxRuns !== undefined) {
|
||||||
|
return parsePositiveInt(options.maxRuns, "--max-runs");
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
function parseUpdateExpiresAt(options: ScheduleUpdateOptionsInput): string | null | undefined {
|
||||||
|
if (options.expiresIn !== undefined && options.clearExpires) {
|
||||||
|
throw {
|
||||||
|
code: "CONFLICTING_EXPIRES",
|
||||||
|
message: "Use either --expires-in <duration> or --no-expires-in, not both",
|
||||||
|
} satisfies CommandError;
|
||||||
|
}
|
||||||
|
if (options.clearExpires) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
if (options.expiresIn !== undefined) {
|
||||||
|
return new Date(Date.now() + parseDuration(options.expiresIn)).toISOString();
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
function parseUpdateName(options: ScheduleUpdateOptionsInput): string | null | undefined {
|
||||||
|
if (options.name === undefined) {
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
const trimmed = options.name.trim();
|
||||||
|
return trimmed.length > 0 ? trimmed : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function parseUpdatePrompt(options: ScheduleUpdateOptionsInput): string | undefined {
|
||||||
|
if (options.prompt === undefined) {
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
const trimmed = options.prompt.trim();
|
||||||
|
if (!trimmed) {
|
||||||
|
throw {
|
||||||
|
code: "INVALID_PROMPT",
|
||||||
|
message: "--prompt cannot be empty",
|
||||||
|
} satisfies CommandError;
|
||||||
|
}
|
||||||
|
return trimmed;
|
||||||
|
}
|
||||||
|
|
||||||
|
function buildNewAgentConfigPatch(
|
||||||
|
options: ScheduleUpdateOptionsInput,
|
||||||
|
): UpdateScheduleNewAgentConfig | undefined {
|
||||||
|
const patch: UpdateScheduleNewAgentConfig = {};
|
||||||
|
if (options.provider !== undefined || options.model !== undefined) {
|
||||||
|
const resolved = resolveProviderAndModel({
|
||||||
|
provider: options.provider,
|
||||||
|
model: options.model,
|
||||||
|
});
|
||||||
|
patch.provider = resolved.provider;
|
||||||
|
if (resolved.model !== undefined) {
|
||||||
|
patch.model = resolved.model;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (options.mode !== undefined) {
|
||||||
|
const trimmed = options.mode.trim();
|
||||||
|
patch.modeId = trimmed.length > 0 ? trimmed : null;
|
||||||
|
}
|
||||||
|
if (options.cwd !== undefined) {
|
||||||
|
const trimmed = options.cwd.trim();
|
||||||
|
if (!trimmed) {
|
||||||
|
throw {
|
||||||
|
code: "INVALID_CWD",
|
||||||
|
message: "--cwd cannot be empty",
|
||||||
|
} satisfies CommandError;
|
||||||
|
}
|
||||||
|
patch.cwd = trimmed;
|
||||||
|
}
|
||||||
|
return Object.keys(patch).length > 0 ? patch : undefined;
|
||||||
|
}
|
||||||
|
|
||||||
function parsePositiveInt(value: string, flag: string): number {
|
function parsePositiveInt(value: string, flag: string): number {
|
||||||
const parsed = Number.parseInt(value, 10);
|
const parsed = Number.parseInt(value, 10);
|
||||||
if (!Number.isInteger(parsed) || parsed <= 0) {
|
if (!Number.isInteger(parsed) || parsed <= 0) {
|
||||||
|
|||||||
@@ -136,6 +136,29 @@ export interface ScheduleRunOncePayload {
|
|||||||
error: string | null;
|
error: string | null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export interface UpdateScheduleNewAgentConfig {
|
||||||
|
provider?: string;
|
||||||
|
model?: string | null;
|
||||||
|
modeId?: string | null;
|
||||||
|
cwd?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface UpdateScheduleInput {
|
||||||
|
id: string;
|
||||||
|
name?: string | null;
|
||||||
|
prompt?: string;
|
||||||
|
cadence?: ScheduleCadence;
|
||||||
|
newAgentConfig?: UpdateScheduleNewAgentConfig;
|
||||||
|
maxRuns?: number | null;
|
||||||
|
expiresAt?: string | null;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface ScheduleUpdatePayload {
|
||||||
|
requestId: string;
|
||||||
|
schedule: ScheduleRecord | null;
|
||||||
|
error: string | null;
|
||||||
|
}
|
||||||
|
|
||||||
export interface ScheduleDaemonClient {
|
export interface ScheduleDaemonClient {
|
||||||
scheduleCreate(input: CreateScheduleInput): Promise<ScheduleCreatePayload>;
|
scheduleCreate(input: CreateScheduleInput): Promise<ScheduleCreatePayload>;
|
||||||
scheduleList(): Promise<ScheduleListPayload>;
|
scheduleList(): Promise<ScheduleListPayload>;
|
||||||
@@ -145,5 +168,6 @@ export interface ScheduleDaemonClient {
|
|||||||
scheduleResume(input: { id: string }): Promise<ScheduleResumePayload>;
|
scheduleResume(input: { id: string }): Promise<ScheduleResumePayload>;
|
||||||
scheduleDelete(input: { id: string }): Promise<ScheduleDeletePayload>;
|
scheduleDelete(input: { id: string }): Promise<ScheduleDeletePayload>;
|
||||||
scheduleRunOnce(input: { id: string }): Promise<ScheduleRunOncePayload>;
|
scheduleRunOnce(input: { id: string }): Promise<ScheduleRunOncePayload>;
|
||||||
|
scheduleUpdate(input: UpdateScheduleInput): Promise<ScheduleUpdatePayload>;
|
||||||
close(): Promise<void>;
|
close(): Promise<void>;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,66 @@
|
|||||||
|
import type { Command } from "commander";
|
||||||
|
import type { ListResult } from "../../output/index.js";
|
||||||
|
import {
|
||||||
|
createScheduleInspectRows,
|
||||||
|
createScheduleInspectSchema,
|
||||||
|
type ScheduleInspectRow,
|
||||||
|
} from "./schema.js";
|
||||||
|
import {
|
||||||
|
connectScheduleClient,
|
||||||
|
parseScheduleUpdateInput,
|
||||||
|
toScheduleCommandError,
|
||||||
|
type ScheduleCommandOptions,
|
||||||
|
} from "./shared.js";
|
||||||
|
|
||||||
|
export interface ScheduleUpdateOptions extends ScheduleCommandOptions {
|
||||||
|
every?: string;
|
||||||
|
cron?: string;
|
||||||
|
name?: string;
|
||||||
|
prompt?: string;
|
||||||
|
provider?: string;
|
||||||
|
model?: string;
|
||||||
|
mode?: string;
|
||||||
|
cwd?: string;
|
||||||
|
maxRuns?: string;
|
||||||
|
noMaxRuns?: boolean;
|
||||||
|
expiresIn?: string;
|
||||||
|
noExpiresIn?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function runUpdateCommand(
|
||||||
|
id: string,
|
||||||
|
options: ScheduleUpdateOptions,
|
||||||
|
_command: Command,
|
||||||
|
): Promise<ListResult<ScheduleInspectRow>> {
|
||||||
|
const input = parseScheduleUpdateInput({
|
||||||
|
id,
|
||||||
|
every: options.every,
|
||||||
|
cron: options.cron,
|
||||||
|
name: options.name,
|
||||||
|
prompt: options.prompt,
|
||||||
|
provider: options.provider,
|
||||||
|
model: options.model,
|
||||||
|
mode: options.mode,
|
||||||
|
cwd: options.cwd,
|
||||||
|
maxRuns: options.maxRuns,
|
||||||
|
expiresIn: options.expiresIn,
|
||||||
|
clearMaxRuns: options.noMaxRuns,
|
||||||
|
clearExpires: options.noExpiresIn,
|
||||||
|
});
|
||||||
|
const { client } = await connectScheduleClient(options.host);
|
||||||
|
try {
|
||||||
|
const payload = await client.scheduleUpdate(input);
|
||||||
|
if (payload.error || !payload.schedule) {
|
||||||
|
throw new Error(payload.error ?? `Failed to update schedule: ${id}`);
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
type: "list",
|
||||||
|
data: createScheduleInspectRows(payload.schedule),
|
||||||
|
schema: createScheduleInspectSchema(payload.schedule),
|
||||||
|
};
|
||||||
|
} catch (error) {
|
||||||
|
throw toScheduleCommandError("SCHEDULE_UPDATE_FAILED", "update schedule", error);
|
||||||
|
} finally {
|
||||||
|
await client.close().catch(() => {});
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -392,6 +392,10 @@ type ScheduleRunOncePayload = Extract<
|
|||||||
SessionOutboundMessage,
|
SessionOutboundMessage,
|
||||||
{ type: "schedule/run-once/response" }
|
{ type: "schedule/run-once/response" }
|
||||||
>["payload"];
|
>["payload"];
|
||||||
|
type ScheduleUpdatePayload = Extract<
|
||||||
|
SessionOutboundMessage,
|
||||||
|
{ type: "schedule/update/response" }
|
||||||
|
>["payload"];
|
||||||
export type FetchAgentTimelinePayload = FetchAgentTimelineResponseMessage["payload"];
|
export type FetchAgentTimelinePayload = FetchAgentTimelineResponseMessage["payload"];
|
||||||
|
|
||||||
export type FetchAgentTimelineDirection = FetchAgentTimelinePayload["direction"];
|
export type FetchAgentTimelineDirection = FetchAgentTimelinePayload["direction"];
|
||||||
@@ -552,6 +556,30 @@ export interface InspectScheduleOptions {
|
|||||||
id: string;
|
id: string;
|
||||||
requestId?: string;
|
requestId?: string;
|
||||||
}
|
}
|
||||||
|
export interface UpdateScheduleNewAgentConfig {
|
||||||
|
provider?: string;
|
||||||
|
model?: string | null;
|
||||||
|
modeId?: string | null;
|
||||||
|
cwd?: string;
|
||||||
|
}
|
||||||
|
export interface UpdateScheduleOptions {
|
||||||
|
id: string;
|
||||||
|
name?: string | null;
|
||||||
|
prompt?: string;
|
||||||
|
cadence?:
|
||||||
|
| {
|
||||||
|
type: "every";
|
||||||
|
everyMs: number;
|
||||||
|
}
|
||||||
|
| {
|
||||||
|
type: "cron";
|
||||||
|
expression: string;
|
||||||
|
};
|
||||||
|
newAgentConfig?: UpdateScheduleNewAgentConfig;
|
||||||
|
maxRuns?: number | null;
|
||||||
|
expiresAt?: string | null;
|
||||||
|
requestId?: string;
|
||||||
|
}
|
||||||
type ListAvailableEditorsPayload = ListAvailableEditorsResponseMessage["payload"];
|
type ListAvailableEditorsPayload = ListAvailableEditorsResponseMessage["payload"];
|
||||||
type OpenInEditorPayload = OpenInEditorResponseMessage["payload"];
|
type OpenInEditorPayload = OpenInEditorResponseMessage["payload"];
|
||||||
type OpenProjectPayload = OpenProjectResponseMessage["payload"];
|
type OpenProjectPayload = OpenProjectResponseMessage["payload"];
|
||||||
@@ -3762,6 +3790,24 @@ export class DaemonClient {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async scheduleUpdate(options: UpdateScheduleOptions): Promise<ScheduleUpdatePayload> {
|
||||||
|
return this.sendCorrelatedSessionRequest({
|
||||||
|
requestId: options.requestId,
|
||||||
|
message: {
|
||||||
|
type: "schedule/update",
|
||||||
|
scheduleId: options.id,
|
||||||
|
...(options.name !== undefined ? { name: options.name } : {}),
|
||||||
|
...(options.prompt !== undefined ? { prompt: options.prompt } : {}),
|
||||||
|
...(options.cadence !== undefined ? { cadence: options.cadence } : {}),
|
||||||
|
...(options.newAgentConfig !== undefined ? { newAgentConfig: options.newAgentConfig } : {}),
|
||||||
|
...(options.maxRuns !== undefined ? { maxRuns: options.maxRuns } : {}),
|
||||||
|
...(options.expiresAt !== undefined ? { expiresAt: options.expiresAt } : {}),
|
||||||
|
},
|
||||||
|
responseType: "schedule/update/response",
|
||||||
|
timeout: 10000,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
async loopRun(options: RunLoopOptions): Promise<LoopRunPayload> {
|
async loopRun(options: RunLoopOptions): Promise<LoopRunPayload> {
|
||||||
return this.sendCorrelatedSessionRequest({
|
return this.sendCorrelatedSessionRequest({
|
||||||
requestId: options.requestId,
|
requestId: options.requestId,
|
||||||
|
|||||||
@@ -75,6 +75,25 @@ export const ScheduleRunOnceRequestSchema = z.object({
|
|||||||
scheduleId: z.string(),
|
scheduleId: z.string(),
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const ScheduleUpdateNewAgentConfigSchema = z.object({
|
||||||
|
provider: z.string().trim().min(1).optional(),
|
||||||
|
model: z.string().trim().min(1).nullable().optional(),
|
||||||
|
modeId: z.string().trim().min(1).nullable().optional(),
|
||||||
|
cwd: z.string().trim().min(1).optional(),
|
||||||
|
});
|
||||||
|
|
||||||
|
export const ScheduleUpdateRequestSchema = z.object({
|
||||||
|
type: z.literal("schedule/update"),
|
||||||
|
requestId: z.string(),
|
||||||
|
scheduleId: z.string(),
|
||||||
|
name: z.string().nullable().optional(),
|
||||||
|
prompt: z.string().min(1).optional(),
|
||||||
|
cadence: ScheduleCadenceSchema.optional(),
|
||||||
|
newAgentConfig: ScheduleUpdateNewAgentConfigSchema.optional(),
|
||||||
|
maxRuns: z.number().int().positive().nullable().optional(),
|
||||||
|
expiresAt: z.string().nullable().optional(),
|
||||||
|
});
|
||||||
|
|
||||||
export const ScheduleCreateResponseSchema = z.object({
|
export const ScheduleCreateResponseSchema = z.object({
|
||||||
type: z.literal("schedule/create/response"),
|
type: z.literal("schedule/create/response"),
|
||||||
payload: z.object({
|
payload: z.object({
|
||||||
@@ -146,3 +165,12 @@ export const ScheduleRunOnceResponseSchema = z.object({
|
|||||||
error: z.string().nullable(),
|
error: z.string().nullable(),
|
||||||
}),
|
}),
|
||||||
});
|
});
|
||||||
|
|
||||||
|
export const ScheduleUpdateResponseSchema = z.object({
|
||||||
|
type: z.literal("schedule/update/response"),
|
||||||
|
payload: z.object({
|
||||||
|
requestId: z.string(),
|
||||||
|
schedule: StoredScheduleSchema.nullable(),
|
||||||
|
error: z.string().nullable(),
|
||||||
|
}),
|
||||||
|
});
|
||||||
|
|||||||
@@ -493,6 +493,244 @@ describe("ScheduleService", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("update mutates cadence, prompt, name, and target fields in place", async () => {
|
||||||
|
const service = new ScheduleService({
|
||||||
|
paseoHome: tempDir,
|
||||||
|
logger: createTestLogger(),
|
||||||
|
agentManager: new AgentManager({ logger: createTestLogger() }),
|
||||||
|
agentStorage,
|
||||||
|
now: () => now,
|
||||||
|
runner: async () => ({ agentId: null, output: "ok" }),
|
||||||
|
});
|
||||||
|
|
||||||
|
const created = await service.create({
|
||||||
|
name: "morning",
|
||||||
|
prompt: "first prompt",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: {
|
||||||
|
type: "new-agent",
|
||||||
|
config: { provider: "claude", cwd: tempDir, modeId: "default" },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(created.runs).toEqual([]);
|
||||||
|
|
||||||
|
now = new Date("2026-01-01T00:00:30.000Z");
|
||||||
|
const updated = await service.update({
|
||||||
|
id: created.id,
|
||||||
|
prompt: "second prompt",
|
||||||
|
name: "renamed",
|
||||||
|
cadence: { type: "every", everyMs: 5 * 60_000 },
|
||||||
|
newAgentConfig: {
|
||||||
|
provider: "codex",
|
||||||
|
model: "gpt-5",
|
||||||
|
modeId: "full-access",
|
||||||
|
cwd: "/new/path",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(updated.prompt).toBe("second prompt");
|
||||||
|
expect(updated.name).toBe("renamed");
|
||||||
|
expect(updated.cadence).toEqual({ type: "every", everyMs: 5 * 60_000 });
|
||||||
|
expect(updated.target).toEqual({
|
||||||
|
type: "new-agent",
|
||||||
|
config: {
|
||||||
|
provider: "codex",
|
||||||
|
cwd: "/new/path",
|
||||||
|
model: "gpt-5",
|
||||||
|
modeId: "full-access",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(updated.nextRunAt).toBe("2026-01-01T00:05:30.000Z");
|
||||||
|
expect(updated.updatedAt).toBe("2026-01-01T00:00:30.000Z");
|
||||||
|
expect(updated.createdAt).toBe(created.createdAt);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("update switches between every and cron cadences and recomputes nextRunAt", async () => {
|
||||||
|
const service = new ScheduleService({
|
||||||
|
paseoHome: tempDir,
|
||||||
|
logger: createTestLogger(),
|
||||||
|
agentManager: new AgentManager({ logger: createTestLogger() }),
|
||||||
|
agentStorage,
|
||||||
|
now: () => now,
|
||||||
|
runner: async () => ({ agentId: null, output: "ok" }),
|
||||||
|
});
|
||||||
|
|
||||||
|
const created = await service.create({
|
||||||
|
prompt: "p",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: { type: "new-agent", config: { provider: "claude", cwd: tempDir } },
|
||||||
|
});
|
||||||
|
expect(created.nextRunAt).toBe("2026-01-01T00:00:00.000Z");
|
||||||
|
|
||||||
|
const cron = await service.update({
|
||||||
|
id: created.id,
|
||||||
|
cadence: { type: "cron", expression: "30 9 * * *" },
|
||||||
|
});
|
||||||
|
expect(cron.cadence).toEqual({ type: "cron", expression: "30 9 * * *" });
|
||||||
|
expect(cron.nextRunAt).toBe("2026-01-01T09:30:00.000Z");
|
||||||
|
|
||||||
|
const back = await service.update({
|
||||||
|
id: created.id,
|
||||||
|
cadence: { type: "every", everyMs: 2 * 60_000 },
|
||||||
|
});
|
||||||
|
expect(back.cadence).toEqual({ type: "every", everyMs: 2 * 60_000 });
|
||||||
|
expect(back.nextRunAt).toBe("2026-01-01T00:02:00.000Z");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("update preserves nextRunAt and run history when cadence is unchanged", async () => {
|
||||||
|
const service = new ScheduleService({
|
||||||
|
paseoHome: tempDir,
|
||||||
|
logger: createTestLogger(),
|
||||||
|
agentManager: new AgentManager({ logger: createTestLogger() }),
|
||||||
|
agentStorage,
|
||||||
|
now: () => now,
|
||||||
|
runner: async () => ({ agentId: null, output: "ran" }),
|
||||||
|
});
|
||||||
|
|
||||||
|
const created = await service.create({
|
||||||
|
prompt: "p",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: { type: "new-agent", config: { provider: "claude", cwd: tempDir } },
|
||||||
|
});
|
||||||
|
|
||||||
|
now = new Date("2026-01-01T00:01:00.000Z");
|
||||||
|
await service.tick();
|
||||||
|
const after = await service.inspect(created.id);
|
||||||
|
expect(after.runs).toHaveLength(1);
|
||||||
|
|
||||||
|
now = new Date("2026-01-01T00:01:30.000Z");
|
||||||
|
const updated = await service.update({ id: created.id, prompt: "new prompt" });
|
||||||
|
|
||||||
|
expect(updated.prompt).toBe("new prompt");
|
||||||
|
expect(updated.cadence).toEqual(created.cadence);
|
||||||
|
expect(updated.nextRunAt).toBe(after.nextRunAt);
|
||||||
|
expect(updated.runs).toEqual(after.runs);
|
||||||
|
expect(updated.lastRunAt).toBe(after.lastRunAt);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("update clears the schedule name when given an empty string", async () => {
|
||||||
|
const service = new ScheduleService({
|
||||||
|
paseoHome: tempDir,
|
||||||
|
logger: createTestLogger(),
|
||||||
|
agentManager: new AgentManager({ logger: createTestLogger() }),
|
||||||
|
agentStorage,
|
||||||
|
now: () => now,
|
||||||
|
runner: async () => ({ agentId: null, output: "ok" }),
|
||||||
|
});
|
||||||
|
|
||||||
|
const created = await service.create({
|
||||||
|
name: "named",
|
||||||
|
prompt: "p",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: { type: "new-agent", config: { provider: "claude", cwd: tempDir } },
|
||||||
|
});
|
||||||
|
expect(created.name).toBe("named");
|
||||||
|
|
||||||
|
const cleared = await service.update({ id: created.id, name: "" });
|
||||||
|
expect(cleared.name).toBeNull();
|
||||||
|
|
||||||
|
const renamed = await service.update({ id: created.id, name: "again" });
|
||||||
|
expect(renamed.name).toBe("again");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("update rejects new-agent fields on agent-target schedules", async () => {
|
||||||
|
const service = new ScheduleService({
|
||||||
|
paseoHome: tempDir,
|
||||||
|
logger: createTestLogger(),
|
||||||
|
agentManager: new AgentManager({ logger: createTestLogger() }),
|
||||||
|
agentStorage,
|
||||||
|
now: () => now,
|
||||||
|
runner: async () => ({ agentId: null, output: "ok" }),
|
||||||
|
});
|
||||||
|
|
||||||
|
const created = await service.create({
|
||||||
|
prompt: "agent target",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: { type: "agent", agentId: "00000000-0000-0000-0000-000000000005" },
|
||||||
|
});
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
service.update({
|
||||||
|
id: created.id,
|
||||||
|
newAgentConfig: { provider: "codex" },
|
||||||
|
}),
|
||||||
|
).rejects.toThrow("only valid for new-agent target schedules");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("update changes individual new-agent fields independently", async () => {
|
||||||
|
const service = new ScheduleService({
|
||||||
|
paseoHome: tempDir,
|
||||||
|
logger: createTestLogger(),
|
||||||
|
agentManager: new AgentManager({ logger: createTestLogger() }),
|
||||||
|
agentStorage,
|
||||||
|
now: () => now,
|
||||||
|
runner: async () => ({ agentId: null, output: "ok" }),
|
||||||
|
});
|
||||||
|
|
||||||
|
const created = await service.create({
|
||||||
|
prompt: "p",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: {
|
||||||
|
type: "new-agent",
|
||||||
|
config: { provider: "claude", cwd: tempDir, model: "sonnet", modeId: "default" },
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const modeOnly = await service.update({
|
||||||
|
id: created.id,
|
||||||
|
newAgentConfig: { modeId: "bypassPermissions" },
|
||||||
|
});
|
||||||
|
expect(modeOnly.target).toMatchObject({
|
||||||
|
type: "new-agent",
|
||||||
|
config: {
|
||||||
|
provider: "claude",
|
||||||
|
cwd: tempDir,
|
||||||
|
model: "sonnet",
|
||||||
|
modeId: "bypassPermissions",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const clearModel = await service.update({
|
||||||
|
id: created.id,
|
||||||
|
newAgentConfig: { model: null },
|
||||||
|
});
|
||||||
|
if (clearModel.target.type !== "new-agent") {
|
||||||
|
throw new Error("target type changed unexpectedly");
|
||||||
|
}
|
||||||
|
expect(clearModel.target.config.model).toBeUndefined();
|
||||||
|
expect(clearModel.target.config.modeId).toBe("bypassPermissions");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("update returns a schedule that round-trips through the store", async () => {
|
||||||
|
const service = new ScheduleService({
|
||||||
|
paseoHome: tempDir,
|
||||||
|
logger: createTestLogger(),
|
||||||
|
agentManager: new AgentManager({ logger: createTestLogger() }),
|
||||||
|
agentStorage,
|
||||||
|
now: () => now,
|
||||||
|
runner: async () => ({ agentId: null, output: "ok" }),
|
||||||
|
});
|
||||||
|
|
||||||
|
const created = await service.create({
|
||||||
|
prompt: "p",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: { type: "new-agent", config: { provider: "claude", cwd: tempDir } },
|
||||||
|
});
|
||||||
|
|
||||||
|
await service.update({
|
||||||
|
id: created.id,
|
||||||
|
cadence: { type: "cron", expression: "0 9 * * *" },
|
||||||
|
newAgentConfig: { provider: "codex", modeId: "full-access" },
|
||||||
|
});
|
||||||
|
|
||||||
|
const reloaded = await service.inspect(created.id);
|
||||||
|
expect(reloaded.cadence).toEqual({ type: "cron", expression: "0 9 * * *" });
|
||||||
|
expect(reloaded.target).toEqual({
|
||||||
|
type: "new-agent",
|
||||||
|
config: { provider: "codex", cwd: tempDir, modeId: "full-access" },
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
test("runOnce rejects completed schedules", async () => {
|
test("runOnce rejects completed schedules", async () => {
|
||||||
const service = new ScheduleService({
|
const service = new ScheduleService({
|
||||||
paseoHome: tempDir,
|
paseoHome: tempDir,
|
||||||
|
|||||||
@@ -13,7 +13,10 @@ import type {
|
|||||||
CreateScheduleInput,
|
CreateScheduleInput,
|
||||||
ScheduleExecutionResult,
|
ScheduleExecutionResult,
|
||||||
ScheduleRun,
|
ScheduleRun,
|
||||||
|
ScheduleTarget,
|
||||||
StoredSchedule,
|
StoredSchedule,
|
||||||
|
UpdateScheduleInput,
|
||||||
|
UpdateScheduleNewAgentConfig,
|
||||||
} from "./types.js";
|
} from "./types.js";
|
||||||
|
|
||||||
const SCHEDULE_TICK_INTERVAL_MS = 1000;
|
const SCHEDULE_TICK_INTERVAL_MS = 1000;
|
||||||
@@ -34,6 +37,44 @@ function normalizePrompt(prompt: string): string {
|
|||||||
return trimmed;
|
return trimmed;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function applyNewAgentConfig(
|
||||||
|
target: Extract<ScheduleTarget, { type: "new-agent" }>,
|
||||||
|
patch: UpdateScheduleNewAgentConfig,
|
||||||
|
): Extract<ScheduleTarget, { type: "new-agent" }> {
|
||||||
|
const config = { ...target.config };
|
||||||
|
if (patch.provider !== undefined) {
|
||||||
|
const trimmed = patch.provider.trim();
|
||||||
|
if (!trimmed) {
|
||||||
|
throw new Error("provider cannot be empty");
|
||||||
|
}
|
||||||
|
config.provider = trimmed;
|
||||||
|
}
|
||||||
|
if (patch.cwd !== undefined) {
|
||||||
|
const trimmed = patch.cwd.trim();
|
||||||
|
if (!trimmed) {
|
||||||
|
throw new Error("cwd cannot be empty");
|
||||||
|
}
|
||||||
|
config.cwd = trimmed;
|
||||||
|
}
|
||||||
|
if (patch.model !== undefined) {
|
||||||
|
const trimmed = patch.model?.trim();
|
||||||
|
if (trimmed) {
|
||||||
|
config.model = trimmed;
|
||||||
|
} else {
|
||||||
|
delete config.model;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (patch.modeId !== undefined) {
|
||||||
|
const trimmed = patch.modeId?.trim();
|
||||||
|
if (trimmed) {
|
||||||
|
config.modeId = trimmed;
|
||||||
|
} else {
|
||||||
|
delete config.modeId;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return { ...target, config };
|
||||||
|
}
|
||||||
|
|
||||||
function normalizeMaxRuns(value: number | null | undefined): number | null {
|
function normalizeMaxRuns(value: number | null | undefined): number | null {
|
||||||
if (value == null) {
|
if (value == null) {
|
||||||
return null;
|
return null;
|
||||||
@@ -219,6 +260,46 @@ export class ScheduleService {
|
|||||||
return resumed;
|
return resumed;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async update(input: UpdateScheduleInput): Promise<StoredSchedule> {
|
||||||
|
const schedule = await this.inspect(input.id);
|
||||||
|
const now = this.now();
|
||||||
|
let updated: StoredSchedule = schedule;
|
||||||
|
|
||||||
|
if (input.prompt !== undefined) {
|
||||||
|
updated = { ...updated, prompt: normalizePrompt(input.prompt) };
|
||||||
|
}
|
||||||
|
|
||||||
|
if (input.name !== undefined) {
|
||||||
|
updated = { ...updated, name: trimOptionalName(input.name) };
|
||||||
|
}
|
||||||
|
|
||||||
|
if (input.cadence !== undefined) {
|
||||||
|
validateScheduleCadence(input.cadence);
|
||||||
|
const nextRunAt =
|
||||||
|
updated.status === "active" ? computeNextRunAt(input.cadence, now).toISOString() : null;
|
||||||
|
updated = { ...updated, cadence: input.cadence, nextRunAt };
|
||||||
|
}
|
||||||
|
|
||||||
|
if (input.newAgentConfig !== undefined) {
|
||||||
|
if (updated.target.type !== "new-agent") {
|
||||||
|
throw new Error("new-agent config updates are only valid for new-agent target schedules");
|
||||||
|
}
|
||||||
|
updated = { ...updated, target: applyNewAgentConfig(updated.target, input.newAgentConfig) };
|
||||||
|
}
|
||||||
|
|
||||||
|
if (input.maxRuns !== undefined) {
|
||||||
|
updated = { ...updated, maxRuns: normalizeMaxRuns(input.maxRuns) };
|
||||||
|
}
|
||||||
|
|
||||||
|
if (input.expiresAt !== undefined) {
|
||||||
|
updated = { ...updated, expiresAt: input.expiresAt };
|
||||||
|
}
|
||||||
|
|
||||||
|
updated = { ...updated, updatedAt: now.toISOString() };
|
||||||
|
await this.store.put(updated);
|
||||||
|
return updated;
|
||||||
|
}
|
||||||
|
|
||||||
async delete(id: string): Promise<void> {
|
async delete(id: string): Promise<void> {
|
||||||
await this.store.delete(id);
|
await this.store.delete(id);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -47,6 +47,44 @@ describe("ScheduleStore", () => {
|
|||||||
expect(listed).toEqual([created]);
|
expect(listed).toEqual([created]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("put round-trips an updated schedule to disk", async () => {
|
||||||
|
const created = await store.create({
|
||||||
|
name: "before",
|
||||||
|
prompt: "before",
|
||||||
|
cadence: { type: "every", everyMs: 60_000 },
|
||||||
|
target: {
|
||||||
|
type: "new-agent",
|
||||||
|
config: { provider: "claude", cwd: tempDir },
|
||||||
|
},
|
||||||
|
status: "active",
|
||||||
|
createdAt: "2026-01-01T00:00:00.000Z",
|
||||||
|
updatedAt: "2026-01-01T00:00:00.000Z",
|
||||||
|
nextRunAt: "2026-01-01T00:01:00.000Z",
|
||||||
|
lastRunAt: null,
|
||||||
|
pausedAt: null,
|
||||||
|
expiresAt: null,
|
||||||
|
maxRuns: null,
|
||||||
|
runs: [],
|
||||||
|
});
|
||||||
|
|
||||||
|
const updated = {
|
||||||
|
...created,
|
||||||
|
name: "after",
|
||||||
|
prompt: "after",
|
||||||
|
cadence: { type: "cron" as const, expression: "0 9 * * *" },
|
||||||
|
target: {
|
||||||
|
type: "new-agent" as const,
|
||||||
|
config: { provider: "codex", cwd: "/elsewhere", modeId: "full-access" },
|
||||||
|
},
|
||||||
|
nextRunAt: "2026-01-01T09:00:00.000Z",
|
||||||
|
updatedAt: "2026-01-01T00:00:30.000Z",
|
||||||
|
};
|
||||||
|
await store.put(updated);
|
||||||
|
|
||||||
|
const reloaded = await new ScheduleStore(tempDir).get(created.id);
|
||||||
|
expect(reloaded).toEqual(updated);
|
||||||
|
});
|
||||||
|
|
||||||
test("deletes schedules from disk", async () => {
|
test("deletes schedules from disk", async () => {
|
||||||
const created = await store.create({
|
const created = await store.create({
|
||||||
name: null,
|
name: null,
|
||||||
|
|||||||
@@ -93,6 +93,23 @@ export interface CreateScheduleInput {
|
|||||||
runOnCreate?: boolean | null;
|
runOnCreate?: boolean | null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export interface UpdateScheduleNewAgentConfig {
|
||||||
|
provider?: string;
|
||||||
|
model?: string | null;
|
||||||
|
modeId?: string | null;
|
||||||
|
cwd?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface UpdateScheduleInput {
|
||||||
|
id: string;
|
||||||
|
name?: string | null;
|
||||||
|
prompt?: string;
|
||||||
|
cadence?: ScheduleCadence;
|
||||||
|
newAgentConfig?: UpdateScheduleNewAgentConfig;
|
||||||
|
maxRuns?: number | null;
|
||||||
|
expiresAt?: string | null;
|
||||||
|
}
|
||||||
|
|
||||||
export interface ScheduleExecutionResult {
|
export interface ScheduleExecutionResult {
|
||||||
agentId: string | null;
|
agentId: string | null;
|
||||||
output: string | null;
|
output: string | null;
|
||||||
|
|||||||
@@ -2163,6 +2163,8 @@ export class Session {
|
|||||||
return this.handleScheduleDeleteRequest(msg);
|
return this.handleScheduleDeleteRequest(msg);
|
||||||
case "schedule/run-once":
|
case "schedule/run-once":
|
||||||
return this.handleScheduleRunOnceRequest(msg);
|
return this.handleScheduleRunOnceRequest(msg);
|
||||||
|
case "schedule/update":
|
||||||
|
return this.handleScheduleUpdateRequest(msg);
|
||||||
default:
|
default:
|
||||||
return undefined;
|
return undefined;
|
||||||
}
|
}
|
||||||
@@ -8405,7 +8407,8 @@ export class Session {
|
|||||||
| "schedule/pause"
|
| "schedule/pause"
|
||||||
| "schedule/resume"
|
| "schedule/resume"
|
||||||
| "schedule/delete"
|
| "schedule/delete"
|
||||||
| "schedule/run-once";
|
| "schedule/run-once"
|
||||||
|
| "schedule/update";
|
||||||
}
|
}
|
||||||
>,
|
>,
|
||||||
error: unknown,
|
error: unknown,
|
||||||
@@ -8579,6 +8582,32 @@ export class Session {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private async handleScheduleUpdateRequest(
|
||||||
|
request: Extract<SessionInboundMessage, { type: "schedule/update" }>,
|
||||||
|
): Promise<void> {
|
||||||
|
try {
|
||||||
|
const schedule = await this.scheduleService.update({
|
||||||
|
id: request.scheduleId,
|
||||||
|
...(request.name !== undefined ? { name: request.name } : {}),
|
||||||
|
...(request.prompt !== undefined ? { prompt: request.prompt } : {}),
|
||||||
|
...(request.cadence !== undefined ? { cadence: request.cadence } : {}),
|
||||||
|
...(request.newAgentConfig !== undefined ? { newAgentConfig: request.newAgentConfig } : {}),
|
||||||
|
...(request.maxRuns !== undefined ? { maxRuns: request.maxRuns } : {}),
|
||||||
|
...(request.expiresAt !== undefined ? { expiresAt: request.expiresAt } : {}),
|
||||||
|
});
|
||||||
|
this.emit({
|
||||||
|
type: "schedule/update/response",
|
||||||
|
payload: {
|
||||||
|
requestId: request.requestId,
|
||||||
|
schedule,
|
||||||
|
error: null,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
} catch (error) {
|
||||||
|
this.emitScheduleRpcError(request, error);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
private emitLoopRpcError(
|
private emitLoopRpcError(
|
||||||
request: Extract<
|
request: Extract<
|
||||||
SessionInboundMessage,
|
SessionInboundMessage,
|
||||||
|
|||||||
@@ -29,6 +29,7 @@ import {
|
|||||||
ScheduleResumeRequestSchema,
|
ScheduleResumeRequestSchema,
|
||||||
ScheduleDeleteRequestSchema,
|
ScheduleDeleteRequestSchema,
|
||||||
ScheduleRunOnceRequestSchema,
|
ScheduleRunOnceRequestSchema,
|
||||||
|
ScheduleUpdateRequestSchema,
|
||||||
ScheduleCreateResponseSchema,
|
ScheduleCreateResponseSchema,
|
||||||
ScheduleListResponseSchema,
|
ScheduleListResponseSchema,
|
||||||
ScheduleInspectResponseSchema,
|
ScheduleInspectResponseSchema,
|
||||||
@@ -37,6 +38,7 @@ import {
|
|||||||
ScheduleResumeResponseSchema,
|
ScheduleResumeResponseSchema,
|
||||||
ScheduleDeleteResponseSchema,
|
ScheduleDeleteResponseSchema,
|
||||||
ScheduleRunOnceResponseSchema,
|
ScheduleRunOnceResponseSchema,
|
||||||
|
ScheduleUpdateResponseSchema,
|
||||||
} from "../server/schedule/rpc-schemas.js";
|
} from "../server/schedule/rpc-schemas.js";
|
||||||
import {
|
import {
|
||||||
LoopRunRequestSchema,
|
LoopRunRequestSchema,
|
||||||
@@ -1768,6 +1770,7 @@ export const SessionInboundMessageSchema = z.discriminatedUnion("type", [
|
|||||||
ScheduleResumeRequestSchema,
|
ScheduleResumeRequestSchema,
|
||||||
ScheduleDeleteRequestSchema,
|
ScheduleDeleteRequestSchema,
|
||||||
ScheduleRunOnceRequestSchema,
|
ScheduleRunOnceRequestSchema,
|
||||||
|
ScheduleUpdateRequestSchema,
|
||||||
LoopRunRequestSchema,
|
LoopRunRequestSchema,
|
||||||
LoopListRequestSchema,
|
LoopListRequestSchema,
|
||||||
LoopInspectRequestSchema,
|
LoopInspectRequestSchema,
|
||||||
@@ -3382,6 +3385,7 @@ export const SessionOutboundMessageSchema = z.discriminatedUnion("type", [
|
|||||||
ScheduleResumeResponseSchema,
|
ScheduleResumeResponseSchema,
|
||||||
ScheduleDeleteResponseSchema,
|
ScheduleDeleteResponseSchema,
|
||||||
ScheduleRunOnceResponseSchema,
|
ScheduleRunOnceResponseSchema,
|
||||||
|
ScheduleUpdateResponseSchema,
|
||||||
LoopRunResponseSchema,
|
LoopRunResponseSchema,
|
||||||
LoopListResponseSchema,
|
LoopListResponseSchema,
|
||||||
LoopInspectResponseSchema,
|
LoopInspectResponseSchema,
|
||||||
@@ -3488,6 +3492,7 @@ export type SchedulePauseResponse = z.infer<typeof SchedulePauseResponseSchema>;
|
|||||||
export type ScheduleResumeResponse = z.infer<typeof ScheduleResumeResponseSchema>;
|
export type ScheduleResumeResponse = z.infer<typeof ScheduleResumeResponseSchema>;
|
||||||
export type ScheduleDeleteResponse = z.infer<typeof ScheduleDeleteResponseSchema>;
|
export type ScheduleDeleteResponse = z.infer<typeof ScheduleDeleteResponseSchema>;
|
||||||
export type ScheduleRunOnceResponse = z.infer<typeof ScheduleRunOnceResponseSchema>;
|
export type ScheduleRunOnceResponse = z.infer<typeof ScheduleRunOnceResponseSchema>;
|
||||||
|
export type ScheduleUpdateResponse = z.infer<typeof ScheduleUpdateResponseSchema>;
|
||||||
export type LoopRunResponse = z.infer<typeof LoopRunResponseSchema>;
|
export type LoopRunResponse = z.infer<typeof LoopRunResponseSchema>;
|
||||||
export type LoopListResponse = z.infer<typeof LoopListResponseSchema>;
|
export type LoopListResponse = z.infer<typeof LoopListResponseSchema>;
|
||||||
export type LoopInspectResponse = z.infer<typeof LoopInspectResponseSchema>;
|
export type LoopInspectResponse = z.infer<typeof LoopInspectResponseSchema>;
|
||||||
@@ -3547,6 +3552,7 @@ export type SchedulePauseRequest = z.infer<typeof SchedulePauseRequestSchema>;
|
|||||||
export type ScheduleResumeRequest = z.infer<typeof ScheduleResumeRequestSchema>;
|
export type ScheduleResumeRequest = z.infer<typeof ScheduleResumeRequestSchema>;
|
||||||
export type ScheduleDeleteRequest = z.infer<typeof ScheduleDeleteRequestSchema>;
|
export type ScheduleDeleteRequest = z.infer<typeof ScheduleDeleteRequestSchema>;
|
||||||
export type ScheduleRunOnceRequest = z.infer<typeof ScheduleRunOnceRequestSchema>;
|
export type ScheduleRunOnceRequest = z.infer<typeof ScheduleRunOnceRequestSchema>;
|
||||||
|
export type ScheduleUpdateRequest = z.infer<typeof ScheduleUpdateRequestSchema>;
|
||||||
export type LoopRunRequest = z.infer<typeof LoopRunRequestSchema>;
|
export type LoopRunRequest = z.infer<typeof LoopRunRequestSchema>;
|
||||||
export type LoopListRequest = z.infer<typeof LoopListRequestSchema>;
|
export type LoopListRequest = z.infer<typeof LoopListRequestSchema>;
|
||||||
export type LoopInspectRequest = z.infer<typeof LoopInspectRequestSchema>;
|
export type LoopInspectRequest = z.infer<typeof LoopInspectRequestSchema>;
|
||||||
|
|||||||
Reference in New Issue
Block a user