Manage orchestration skills per host (#3451)

* feat(skills): manage orchestration skills per host Agent skills execute on the daemon host, so their bundle, selection, and filesystem convergence must share that owner. Preserve the existing install semantics while letting every capable client manage the selected host and migrating the legacy desktop preference once. * fix(client): keep skill management internal Keep host skill management on the low-level daemon client used by the app. Do not expose daemon settings or the desktop-only compatibility migration through the shared Paseo API handed to plugins. * fix(e2e): declare skills fixture dependencies Use Playwright's required destructuring form for the test-scoped daemon sandbox fixture so CI can collect the real-host skills suite. * test(skills): use native managed paths Assert fixed skill targets relative to the daemon user's real home with platform-native path joining so the ownership contract holds on Windows and POSIX hosts.
2026-08-18 09:51:46 +02:00
parent eb3591cee8
commit 4108960709
71 changed files with 2225 additions and 2598 deletions
@@ -0,0 +1,72 @@
+/** @vitest-environment jsdom */
+import React, { type ReactNode } from "react";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { renderHook, waitFor } from "@testing-library/react";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { useAgentSkills } from "./use-agent-skills";
+
+const runtime = vi.hoisted(() => ({
+  connected: true,
+  supported: true,
+  clients: new Map<string, { getAgentSkillsStatus: ReturnType<typeof vi.fn> }>(),
+}));
+
+vi.mock("@/runtime/host-features", () => ({
+  useHostFeature: (_serverId: string, feature: string) =>
+    feature === "skillManagement" && runtime.supported,
+}));
+vi.mock("@/runtime/host-runtime", () => ({
+  useHostRuntimeClient: (serverId: string) => runtime.clients.get(serverId) ?? null,
+  useHostRuntimeIsConnected: () => runtime.connected,
+}));
+vi.mock("@/contexts/toast-context", () => ({
+  useToast: () => ({ error: vi.fn() }),
+}));
+
+function wrapper({ children }: { children: ReactNode }) {
+  return (
+    <QueryClientProvider
+      client={new QueryClient({ defaultOptions: { queries: { retry: false } } })}
+    >
+      {children}
+    </QueryClientProvider>
+  );
+}
+
+describe("host agent skills", () => {
+  beforeEach(() => {
+    runtime.connected = true;
+    runtime.supported = true;
+    runtime.clients.clear();
+  });
+
+  it("reads status from the selected host client", async () => {
+    const local = { getAgentSkillsStatus: vi.fn() };
+    const remote = {
+      getAgentSkillsStatus: vi.fn(async () => ({
+        state: "not-installed",
+        ops: [],
+        available: ["paseo"],
+        installed: [],
+        selection: { mode: "all" },
+      })),
+    };
+    runtime.clients.set("local", local);
+    runtime.clients.set("remote", remote);
+
+    const { result } = renderHook(() => useAgentSkills("remote"), { wrapper });
+    await waitFor(() => expect(result.current.status?.available).toEqual(["paseo"]));
+    expect(remote.getAgentSkillsStatus).toHaveBeenCalledOnce();
+    expect(local.getAgentSkillsStatus).not.toHaveBeenCalled();
+  });
+
+  it("does not call an old host without the capability", async () => {
+    runtime.supported = false;
+    const client = { getAgentSkillsStatus: vi.fn() };
+    runtime.clients.set("old-host", client);
+
+    const { result } = renderHook(() => useAgentSkills("old-host"), { wrapper });
+    expect(result.current.supported).toBe(false);
+    expect(client.getAgentSkillsStatus).not.toHaveBeenCalled();
+  });
+});