jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(app): drop getId from workspace stack route

Browse Source 
Expo Router maps getId to React Navigation getId, which reorders an
already-mounted workspace screen on Android native-stack/Fabric. Keep
workspace identity/retention outside the route-level API and leave a
comment warning against re-adding it.
This commit is contained in:
Mohamed Boudra
2026-04-20 10:45:02 +07:00
parent a0169bf7f4
commit 427664dfa7
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app/src/app/_layout.tsx
+8 -8
View File
@@ -815,14 +815,14 @@ function RootStack() {
<Stack.Screen name="settings/[section]" /> <Stack.Screen name="settings/[section]" />
<Stack.Screen name="pair-scan" /> <Stack.Screen name="pair-scan" />
</Stack.Protected> </Stack.Protected>
<Stack.Screen {/*
name="h/[serverId]/workspace/[workspaceId]" Do not add getId or dangerouslySingular back to the workspace route.
getId={({ params }) => { Expo Router maps dangerouslySingular to React Navigation getId, and
const serverId = getRouteParamValue(params?.serverId); getId repeatedly breaks Android native-stack/Fabric by reordering an
const workspaceId = getRouteParamValue(params?.workspaceId); already-mounted workspace screen. Keep workspace identity/retention
return serverId && workspaceId ? `${serverId}:${workspaceId}` : undefined; outside this route-level native-stack API.
}} */}
/> <Stack.Screen name="h/[serverId]/workspace/[workspaceId]" />
<Stack.Screen name="h/[serverId]/agent/[agentId]" options={{ gestureEnabled: false }} /> <Stack.Screen name="h/[serverId]/agent/[agentId]" options={{ gestureEnabled: false }} />
<Stack.Screen name="h/[serverId]/index" /> <Stack.Screen name="h/[serverId]/index" />
<Stack.Screen name="h/[serverId]/sessions" /> <Stack.Screen name="h/[serverId]/sessions" />