Reload daemon configuration without restarting (#3365)

* feat(daemon): reload configuration without restarting

Keep config validation, reloadability classification, override handling, and atomic runtime application inside the daemon so local and remote clients share one authoritative workflow.

* fix(daemon): preserve reload resource ownership

Keep every materialized provider client under daemon-lifetime ownership and classify speech overrides from resolved providers. Restore the complete WebSocket config-store test contract exposed by CI.
This commit is contained in:
Mohamed Boudra
2026-08-14 22:46:32 +02:00
committed by GitHub
parent 75bbca4a1b
commit 4748aad103
36 changed files with 2590 additions and 246 deletions
+59
View File
@@ -1439,6 +1439,65 @@ test("honors explicit getDaemonPairingOffer timeout below the session RPC defaul
await expect(responsePromise).rejects.toThrow("Timeout waiting for message (1500ms)");
});
test("gates config reload on the daemon capability", async () => {
const mock = createMockTransport();
const client = new DaemonClient({
url: "ws://test",
clientId: "clsk_unit_test",
logger: createMockLogger(),
reconnect: { enabled: false },
transportFactory: () => mock.transport,
});
clients.push(client);
const connectPromise = client.connect();
mock.triggerOpen();
await connectPromise;
await expect(client.reloadDaemonConfig("reload-old-host")).rejects.toThrow(
"Update the host to reload daemon configuration.",
);
expect(mock.sent).toEqual([]);
});
test("sends and parses daemon config reload", async () => {
const mock = createMockTransport();
const client = new DaemonClient({
url: "ws://test",
clientId: "clsk_unit_test",
logger: createMockLogger(),
reconnect: { enabled: false },
transportFactory: () => mock.transport,
});
clients.push(client);
const connectPromise = client.connect();
mock.triggerOpen({ features: { daemonConfigReload: true } });
await connectPromise;
const response = client.reloadDaemonConfig("reload-new-host");
expect(parseSentFrame(mock.sent[0])).toEqual({
type: "daemon.config.reload.request",
requestId: "reload-new-host",
});
mock.triggerMessage(
wrapSessionMessage({
type: "daemon.config.reload.response",
payload: {
requestId: "reload-new-host",
appliedPaths: ["daemon.browserTools.enabled"],
restartRequiredPaths: ["daemon.listen"],
overrideControlledPaths: [],
},
}),
);
await expect(response).resolves.toEqual({
requestId: "reload-new-host",
appliedPaths: ["daemon.browserTools.enabled"],
restartRequiredPaths: ["daemon.listen"],
overrideControlledPaths: [],
});
});
test("keeps waitForAgentUpsert initial fetch inside the requested deadline", async () => {
useHeartbeatClock();
const logger = createMockLogger();
+16
View File
@@ -84,6 +84,7 @@ import type {
ProviderUsageListResponseMessage,
DaemonGetStatusResponse,
DaemonGetPairingOfferResponse,
DaemonConfigReloadResponse,
DiagnosticsResponse,
AgentRewindResponseMessage,
ListTerminalsResponse,
@@ -4552,6 +4553,14 @@ export class DaemonClient {
});
}
async reloadDaemonConfig(requestId?: string): Promise<DaemonConfigReloadResponse["payload"]> {
this.requireDaemonConfigReloadSupport();
return this.sendNamespacedCorrelatedSessionRequest({
requestId,
message: { type: "daemon.config.reload.request" },
});
}
async connectHub(hubUrl: string, token: string, requestId?: string) {
this.requireHubRelationshipSupport();
return this.sendCorrelatedSessionRequest({
@@ -5333,6 +5342,13 @@ export class DaemonClient {
}
}
private requireDaemonConfigReloadSupport(): void {
// COMPAT(daemonConfigReload): added in v0.4.0, remove gate after 2027-02-14.
if (this.lastServerInfoMessage?.features?.daemonConfigReload !== true) {
throw new Error("Update the host to reload daemon configuration.");
}
}
private resolveTransportUrlForAttempt(): string {
return this.config.url;
}