Remove unnecessary type assertions across codebase
Add oxlint-tsgolint and configure typescript/no-unnecessary-type-assertion to flag redundant `!` and `as Foo` casts. Type-aware mode is left off by default to keep `npm run lint` fast; the rule sits configured for when we turn type-aware on intentionally. Auto-fix removed ~283 redundant casts; two manual touch-ups: a real tsgolint false positive in split-container.tsx and a stale ChildProcess import after a double-cast collapsed.
This commit is contained in:
@@ -168,9 +168,7 @@ function resolveRegisteredProviderIds(
|
||||
agentManager: AgentManager,
|
||||
providerRegistry: Record<AgentProvider, ProviderDefinition> | null | undefined,
|
||||
): AgentProvider[] {
|
||||
return providerRegistry
|
||||
? (Object.keys(providerRegistry) as AgentProvider[])
|
||||
: agentManager.getRegisteredProviderIds();
|
||||
return providerRegistry ? Object.keys(providerRegistry) : agentManager.getRegisteredProviderIds();
|
||||
}
|
||||
|
||||
interface ProviderSummary {
|
||||
@@ -239,7 +237,7 @@ function resolveScheduleProviderAndModel(params: {
|
||||
const providerInput = params.provider?.trim() || params.defaultProvider;
|
||||
const slashIndex = providerInput.indexOf("/");
|
||||
if (slashIndex === -1) {
|
||||
return { provider: providerInput as AgentProvider };
|
||||
return { provider: providerInput };
|
||||
}
|
||||
|
||||
const provider = providerInput.slice(0, slashIndex).trim();
|
||||
@@ -249,7 +247,7 @@ function resolveScheduleProviderAndModel(params: {
|
||||
}
|
||||
|
||||
return {
|
||||
provider: provider as AgentProvider,
|
||||
provider: provider,
|
||||
model,
|
||||
};
|
||||
}
|
||||
@@ -447,7 +445,7 @@ export async function createAgentMcpServer(options: AgentMcpServerOptions): Prom
|
||||
|
||||
const resolvedProviderModel = resolveScheduleProviderAndModel({
|
||||
provider: params?.provider,
|
||||
defaultProvider: params.provider as AgentProvider,
|
||||
defaultProvider: params.provider,
|
||||
});
|
||||
return {
|
||||
type: "new-agent" as const,
|
||||
|
||||
Reference in New Issue
Block a user