Remove unnecessary type assertions across codebase

Add oxlint-tsgolint and configure typescript/no-unnecessary-type-assertion
to flag redundant `!` and `as Foo` casts. Type-aware mode is left off by
default to keep `npm run lint` fast; the rule sits configured for when we
turn type-aware on intentionally. Auto-fix removed ~283 redundant casts;
two manual touch-ups: a real tsgolint false positive in split-container.tsx
and a stale ChildProcess import after a double-cast collapsed.
This commit is contained in:
Mohamed Boudra
2026-05-05 19:56:26 +07:00
parent 78fe3e4df3
commit 4cd9e76bd2
129 changed files with 409 additions and 323 deletions
+2 -2
View File
@@ -1478,11 +1478,11 @@ function parseCheckoutShortstat(text: string): CheckoutShortstat | null {
let deletions = 0;
const addMatch = trimmed.match(/(\d+)\s+insertion/);
if (addMatch) {
additions = Number.parseInt(addMatch[1]!, 10);
additions = Number.parseInt(addMatch[1], 10);
}
const delMatch = trimmed.match(/(\d+)\s+deletion/);
if (delMatch) {
deletions = Number.parseInt(delMatch[1]!, 10);
deletions = Number.parseInt(delMatch[1], 10);
}
if (additions === 0 && deletions === 0) {
@@ -889,7 +889,7 @@ function pruneDirectoryListCache(): void {
}
while (directoryListCache.size > DIRECTORY_LIST_CACHE_MAX_ENTRIES) {
const oldestKey = directoryListCache.keys().next().value as string | undefined;
const oldestKey = directoryListCache.keys().next().value;
if (!oldestKey) {
return;
}
@@ -910,7 +910,7 @@ function pruneWorkspaceEntryListCache(): void {
}
while (workspaceEntryListCache.size > DIRECTORY_LIST_CACHE_MAX_ENTRIES) {
const oldestKey = workspaceEntryListCache.keys().next().value as string | undefined;
const oldestKey = workspaceEntryListCache.keys().next().value;
if (!oldestKey) {
return;
}
+1 -1
View File
@@ -901,7 +901,7 @@ export async function isPaseoOwnedWorktreeCwd(
};
}
const worktreesRoot = join(paseoHome, "worktrees", parts[0]!);
const worktreesRoot = join(paseoHome, "worktrees", parts[0]);
return {
allowed: true,
...(repoRoot !== undefined ? { repoRoot } : {}),