jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(server): prefer portable project icons

Browse Source 
Project icon discovery could select an ICO that native clients cannot decode even when a renderable SVG or PNG was available. Keep ICO as the final fallback and recognize common sized icon names.
This commit is contained in:
Mohamed Boudra
2026-08-13 19:34:37 +02:00
parent a4b92768d9
commit 52e4060d76
2 changed files with 34 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/utils/project-icon.test.ts
+23 -2
View File
@@ -125,11 +125,11 @@ describe("findProjectIcon", () => {
});
it("prioritizes favicon over logo", async () => {
writeFileSync(join(tempDir, "favicon.ico"), "favicon");
writeFileSync(join(tempDir, "favicon.png"), "favicon");
writeFileSync(join(tempDir, "logo.png"), "logo");
const result = await findProjectIcon(tempDir);
expect(result).toBe(join(tempDir, "favicon.ico"));
expect(result).toBe(join(tempDir, "favicon.png"));
});
it("prioritizes priority dirs over root", async () => {
@@ -180,6 +180,14 @@ describe("findProjectIcon", () => {
expect(result).toBe(join(tempDir, "apple-touch-icon.png"));
});
it("prefers an Apple touch PNG over ICO", async () => {
writeFileSync(join(tempDir, "favicon.ico"), "ico");
writeFileSync(join(tempDir, "apple-touch-icon.png"), "apple icon");
const result = await findProjectIcon(tempDir);
expect(result).toBe(join(tempDir, "apple-touch-icon.png"));
});
it("finds icon-*.png patterns", async () => {
writeFileSync(join(tempDir, "icon-192.png"), "192 icon");
@@ -187,6 +195,19 @@ describe("findProjectIcon", () => {
expect(result).toBe(join(tempDir, "icon-192.png"));
});
it.each([
"favicon-32x32.png",
"apple-touch-icon-180x180.png",
"android-chrome-192x192.png",
"safari-pinned-tab.svg",
"mstile-150x150.png",
])("finds common sized icon %s", async (fileName) => {
writeFileSync(join(tempDir, fileName), "icon");
const result = await findProjectIcon(tempDir);
expect(result).toBe(join(tempDir, fileName));
});
it("handles non-existent directory gracefully", async () => {
const result = await findProjectIcon(join(tempDir, "nonexistent"));
expect(result).toBeNull();