From 52eb307e8c861b74bec12593c8f588788cd6db05 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Fri, 24 Apr 2026 11:42:59 +0700 Subject: [PATCH] Stop logging ACP non-JSON stdout previews --- packages/server/src/server/agent/provider-launch-config.ts | 3 --- packages/server/src/server/agent/providers/acp-agent.test.ts | 2 +- packages/server/src/server/agent/providers/acp-agent.ts | 2 -- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/server/src/server/agent/provider-launch-config.ts b/packages/server/src/server/agent/provider-launch-config.ts index 89e8514af..d933f5184 100644 --- a/packages/server/src/server/agent/provider-launch-config.ts +++ b/packages/server/src/server/agent/provider-launch-config.ts @@ -148,9 +148,6 @@ export function migrateProviderSettings( const nextEntry: ProviderOverride = {}; const command = parsedOld.data.command; if (command?.mode === "append") { - console.warn( - `[Config] Skipping legacy agents.providers.${providerId}.command append mode during provider override migration because it cannot be auto-migrated.`, - ); continue; } if (command?.mode === "replace") { diff --git a/packages/server/src/server/agent/providers/acp-agent.test.ts b/packages/server/src/server/agent/providers/acp-agent.test.ts index a925a50dc..7e8ec5b3d 100644 --- a/packages/server/src/server/agent/providers/acp-agent.test.ts +++ b/packages/server/src/server/agent/providers/acp-agent.test.ts @@ -72,10 +72,10 @@ describe("createLoggedNdJsonStream", () => { expect(logger.warn).toHaveBeenCalledWith( expect.objectContaining({ provider: "gemini", - linePreview: "Please visit the following URL to authorize the application:", }), "ACP agent emitted non-JSON stdout; ignoring line", ); + expect(logger.warn.mock.calls[0]?.[0]).not.toHaveProperty("linePreview"); expect(consoleError).not.toHaveBeenCalled(); await writer.close(); diff --git a/packages/server/src/server/agent/providers/acp-agent.ts b/packages/server/src/server/agent/providers/acp-agent.ts index cd6b72081..4c480c1e5 100644 --- a/packages/server/src/server/agent/providers/acp-agent.ts +++ b/packages/server/src/server/agent/providers/acp-agent.ts @@ -153,8 +153,6 @@ export function createLoggedNdJsonStream( { err: error, provider: options.provider, - linePreview: - trimmedLine.length > 500 ? `${trimmedLine.slice(0, 500)}...` : trimmedLine, }, "ACP agent emitted non-JSON stdout; ignoring line", );