jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Skip unrelated required checks without losing their names (#2542)

Browse Source 
* fix(ci): skip unrelated required checks cleanly

Matrix jobs had to start no-op runners to preserve interpolated required-check names. Static named jobs let GitHub report genuine skipped conclusions while keeping those names stable.

* fix(ci): gate changes to install patching script

* fix(ci): route cross-package test contracts narrowly

* fix(ci): keep routed contracts merge-blocking

* fix(server): exclude nested test utilities from builds

* fix(ci): cover app-owned native and browser domains

* refactor(ci): align tests with runtime domains

Own browser specs, desktop specs, and Electron-only app code by stable directories so PR routing does not depend on filename conventions. Keep desktop integration coverage inside the required desktop check.

* fix(ci): keep routing and desktop suites isolated

The routing regression must run before dependency installation, and desktop Vitest must not collect Playwright-owned specs.

* fix(ci): isolate desktop e2e runtime

* perf(test): isolate Playwright workers

* perf(test): parallelize Playwright within specs

* fix(test): keep Playwright file scheduling

* fix(test): share dynamic Metro fixture

* fix(test): preserve own-host restart fixtures

* fix(ci): preserve routed contracts after rebase

* Stabilize Playwright wheel-scroll assertions
This commit is contained in:
Mohamed Boudra
2026-08-02 00:56:05 +08:00
committed by GitHub
parent 429155b536
commit 5a30affd7f
256 changed files with 2693 additions and 2674 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/terminal/agent-hooks/claude/claude.test.ts
+8 -14
View File
@@ -1,8 +1,7 @@
import { spawnSync } from "node:child_process";
import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { delimiter, dirname, join, resolve } from "node:path";
import { fileURLToPath } from "node:url";
import { delimiter, join } from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import { isPlatform } from "../../../test-utils/platform.js";
import { buildTerminalEnvironment } from "../../terminal.js";
@@ -15,8 +14,6 @@ import {
} from "../provider-registry.js";
const temporaryDirs: string[] = [];
const repositoryRoot = resolve(dirname(fileURLToPath(import.meta.url)), "../../../../../..");
afterEach(() => {
while (temporaryDirs.length > 0) {
const dir = temporaryDirs.pop();
@@ -167,17 +164,14 @@ describe("Claude terminal agent hooks", () => {
},
);
it("keeps provider names out of generic CLI and bootstrap integration points", () => {
const genericFiles = [
join(repositoryRoot, "packages", "cli", "src", "commands", "hooks.ts"),
join(repositoryRoot, "packages", "server", "src", "server", "bootstrap.ts"),
];
it("keeps provider names out of the generic server bootstrap", () => {
const source = readFileSync(
new URL("../../../server/bootstrap.ts", import.meta.url),
"utf8",
).toLowerCase();
for (const filePath of genericFiles) {
const contents = readFileSync(filePath, "utf8").toLowerCase();
for (const providerId of Object.keys(AGENT_HOOK_PROVIDERS)) {
expect(contents).not.toContain(providerId);
}
for (const providerId of Object.keys(AGENT_HOOK_PROVIDERS)) {
expect(source).not.toContain(providerId);
}
});