Skip unrelated required checks without losing their names (#2542)

* fix(ci): skip unrelated required checks cleanly Matrix jobs had to start no-op runners to preserve interpolated required-check names. Static named jobs let GitHub report genuine skipped conclusions while keeping those names stable. * fix(ci): gate changes to install patching script * fix(ci): route cross-package test contracts narrowly * fix(ci): keep routed contracts merge-blocking * fix(server): exclude nested test utilities from builds * fix(ci): cover app-owned native and browser domains * refactor(ci): align tests with runtime domains Own browser specs, desktop specs, and Electron-only app code by stable directories so PR routing does not depend on filename conventions. Keep desktop integration coverage inside the required desktop check. * fix(ci): keep routing and desktop suites isolated The routing regression must run before dependency installation, and desktop Vitest must not collect Playwright-owned specs. * fix(ci): isolate desktop e2e runtime * perf(test): isolate Playwright workers * perf(test): parallelize Playwright within specs * fix(test): keep Playwright file scheduling * fix(test): share dynamic Metro fixture * fix(test): preserve own-host restart fixtures * fix(ci): preserve routed contracts after rebase * Stabilize Playwright wheel-scroll assertions
2026-08-02 00:56:05 +08:00
parent 429155b536
commit 5a30affd7f
256 changed files with 2693 additions and 2674 deletions
@@ -0,0 +1,82 @@
+import assert from "node:assert/strict";
+import { readFile } from "node:fs/promises";
+import { join } from "node:path";
+import test from "node:test";
+
+const repoRoot = join(import.meta.dirname, "..");
+
+function assertNoDirectWorkerLaunch(label, command) {
+  for (const workerEntrypoint of [
+    "src/server/index.ts",
+    "dist/server/server/index.js",
+    "src/server/daemon-worker.ts",
+    "dist/server/server/daemon-worker.js",
+  ]) {
+    assert.ok(
+      !command.includes(workerEntrypoint),
+      `${label} must not launch ${workerEntrypoint} directly: ${command}`,
+    );
+  }
+}
+
+function assertNoSpawnedWorkerEntrypoint(label, source) {
+  assertNoDirectWorkerLaunch(label, source);
+  assert.doesNotMatch(
+    source,
+    /spawn\([^)]*["'`][^"'`]*\.\.\/index\.ts["'`]/s,
+    `${label} must not spawn ../index.ts directly`,
+  );
+}
+
+test("every executable daemon entrypoint enters the supervisor", async () => {
+  const [
+    serverPackageSource,
+    appIsolatedHostDaemon,
+    serverConnectionOfferE2e,
+    desktopRuntimePaths,
+    nixPackage,
+    nixModule,
+  ] = await Promise.all([
+    readFile(join(repoRoot, "packages/server/package.json"), "utf8"),
+    readFile(join(repoRoot, "packages/app/e2e/support/helpers/isolated-host-daemon.ts"), "utf8"),
+    readFile(
+      join(repoRoot, "packages/server/src/server/daemon-e2e/connection-offer.e2e.test.ts"),
+      "utf8",
+    ),
+    readFile(join(repoRoot, "packages/desktop/src/daemon/runtime-paths.ts"), "utf8"),
+    readFile(join(repoRoot, "nix/package.nix"), "utf8"),
+    readFile(join(repoRoot, "nix/module.nix"), "utf8"),
+  ]);
+
+  const serverPackage = JSON.parse(serverPackageSource);
+  const startScript = serverPackage.scripts?.start ?? "";
+  const devScript = serverPackage.scripts?.dev ?? "";
+  const devTsxScript = serverPackage.scripts?.["dev:tsx"] ?? "";
+
+  assert.match(startScript, /dist\/scripts\/supervisor-entrypoint\.js/);
+  assertNoDirectWorkerLaunch("server start script", startScript);
+  assert.match(devScript, /scripts\/dev-runner\.ts/);
+  assertNoDirectWorkerLaunch("server dev script", devScript);
+  assert.match(devTsxScript, /scripts\/dev-runner\.ts/);
+  assertNoDirectWorkerLaunch("server dev:tsx script", devTsxScript);
+
+  assert.match(
+    appIsolatedHostDaemon,
+    /spawn\(tsxBin, \["scripts\/supervisor-entrypoint\.ts", "--dev"\]/,
+  );
+  assertNoSpawnedWorkerEntrypoint("app e2e isolated host daemon", appIsolatedHostDaemon);
+
+  assert.match(serverConnectionOfferE2e, /scripts\/supervisor-entrypoint\.ts/);
+  assertNoSpawnedWorkerEntrypoint("server daemon e2e process launch", serverConnectionOfferE2e);
+
+  assert.match(desktopRuntimePaths, /"dist", "scripts", "supervisor-entrypoint\.js"/);
+  assert.match(desktopRuntimePaths, /"scripts", "supervisor-entrypoint\.ts"/);
+  assertNoDirectWorkerLaunch("desktop runtime paths", desktopRuntimePaths);
+
+  assert.match(nixPackage, /dist\/scripts\/supervisor-entrypoint\.js/);
+  assertNoDirectWorkerLaunch("Nix package wrapper", nixPackage);
+  assert.match(nixPackage, /--set PASEO_NODE_ENV production/);
+  assert.doesNotMatch(nixPackage, /--set(-default)?\s+NODE_ENV\b/);
+  assert.doesNotMatch(nixModule, /\bNODE_ENV\b\s*=/);
+  assert.doesNotMatch(nixModule, /\bPASEO_NODE_ENV\b/);
+});