feat(app): make the New tab launcher keyboard-first

Cmd/Ctrl+T now opens the focused pane's launcher, while explicit target shortcuts bypass the menu. Dispatcher ownership is scoped to the app tree so retained workspaces cannot intercept commands.

packages/app/e2e/browser/launcher-tab.spec.ts

@@ -4,7 +4,8 @@ import {
   assertNewChatTileVisible,
   assertNewTabMenuTriggerVisible,
   assertSingleNewTabButton,
-  pressNewTabShortcut,
+  openNewTabMenuWithShortcut,
+  pressDirectNewTabShortcut,
   clickNewChat,
   clickNewTerminal,
   countTabsOfKind,
@@ -39,12 +40,32 @@ test.afterAll(async () => {
 // ═══════════════════════════════════════════════════════════════════════════
 
 test.describe("Tab creation", () => {
-  test("Cmd+T opens a new agent tab with composer", async ({ page }) => {
+  test("retained inactive workspaces cannot own New tab shortcuts", async ({ page }) => {
     await gotoWorkspace(page, workspace.workspaceId);
+    const workspaceUrl = page.url();
+    const modifier = process.platform === "darwin" ? "Meta" : "Control";
 
-    await pressNewTabShortcut(page);
+    await page.keyboard.press(`${modifier}+Comma`);
+    await expect(page.getByRole("navigation", { name: "Settings" })).toBeVisible();
 
-    await expectComposerVisible(page);
+    await page.keyboard.press(`${modifier}+t`);
+    await expect(page.getByRole("menuitem", { name: /New agent/ })).toHaveCount(0);
+
+    await page.goto(workspaceUrl);
+    await assertNewTabMenuTriggerVisible(page);
+    const countBefore = await countTabsOfKind(page, "draft");
+    await pressDirectNewTabShortcut(page, "a");
+    await expect.poll(() => countTabsOfKind(page, "draft")).toBe(countBefore + 1);
+  });
+
+  test("Cmd+T opens the New tab menu without creating an agent", async ({ page }) => {
+    await gotoWorkspace(page, workspace.workspaceId);
+    const countBefore = await countTabsOfKind(page, "draft");
+
+    await openNewTabMenuWithShortcut(page);
+
+    await expect.poll(() => countTabsOfKind(page, "draft")).toBe(countBefore);
+    await expect(page.getByRole("button", { name: "New tab", expanded: true })).toBeVisible();
   });
 
   test("opening two new tabs creates two draft tabs", async ({ page }) => {
@@ -52,20 +73,45 @@ test.describe("Tab creation", () => {
 
     const countBefore = await countTabsOfKind(page, "draft");
 
-    await pressNewTabShortcut(page);
+    await pressDirectNewTabShortcut(page, "a");
     await expect
       .poll(() => countTabsOfKind(page, "draft"), { timeout: 15_000 })
       .toBe(countBefore + 1);
     const countAfterFirst = await countTabsOfKind(page, "draft");
 
-    // Blur the composer so the second shortcut isn't swallowed by the focused input
-    await page.evaluate(() => (document.activeElement as HTMLElement)?.blur?.());
-    await pressNewTabShortcut(page);
+    await pressDirectNewTabShortcut(page, "a");
     await expect
       .poll(() => countTabsOfKind(page, "draft"), { timeout: 15_000 })
       .toBe(countAfterFirst + 1);
   });
 
+  test("New tab menu exposes shortcuts and supports arrow navigation", async ({ page }) => {
+    await gotoWorkspace(page, workspace.workspaceId);
+    await openNewTabMenuWithShortcut(page);
+
+    const agent = page.getByRole("menuitem", { name: /New agent/ });
+    const terminal = page.getByRole("menuitem", { name: /New terminal/ });
+    const changes = page.getByRole("menuitem", { name: /Changes/ });
+    const files = page.getByRole("menuitem", { name: /Files/ });
+    const shortcutPrefix = process.platform === "darwin" ? /⇧⌘/ : /Ctrl.*Shift/;
+    await expect(agent).toContainText(new RegExp(`${shortcutPrefix.source}.*A`));
+    await expect(terminal).toContainText(new RegExp(`${shortcutPrefix.source}.*T`));
+    await expect(changes).toContainText(new RegExp(`${shortcutPrefix.source}.*C`));
+    await expect(files).toContainText(new RegExp(`${shortcutPrefix.source}.*E`));
+    await expect(agent).toBeFocused();
+
+    await page.keyboard.press("ArrowDown");
+    await expect(terminal).toBeFocused();
+    await page.keyboard.press("ArrowUp");
+    await expect(agent).toBeFocused();
+    await page.keyboard.press("Escape");
+    await expect(page.getByRole("button", { name: "New tab" })).toBeFocused();
+    await expect(page.getByRole("button", { name: "New tab" })).toHaveAttribute(
+      "aria-expanded",
+      "false",
+    );
+  });
+
   test("clicking new agent tab creates a draft tab", async ({ page }) => {
     await gotoWorkspace(page, workspace.workspaceId);
 
@@ -97,6 +143,22 @@ test.describe("Tab creation", () => {
     await assertNewChatTileVisible(page);
     await assertNewTabMenuTriggerVisible(page);
   });
+
+  test("never shades the New tab button", async ({ page }) => {
+    await gotoWorkspace(page, workspace.workspaceId);
+
+    const tabRow = page.getByTestId("workspace-tabs-row").filter({ visible: true }).first();
+    const scrollArea = tabRow.getByTestId("workspace-tabs-scroll");
+    const newTabButtonInScroll = await scrollArea
+      .getByTestId("workspace-new-tab-menu-trigger")
+      .count();
+    const scrollShades = await tabRow
+      .locator('[data-testid^="workspace-tabs-scroll-shade-"]')
+      .count();
+
+    expect(newTabButtonInScroll === 0 || scrollShades === 0).toBe(true);
+    await expect(tabRow.getByTestId("workspace-new-tab-menu-trigger")).toBeVisible();
+  });
 });
 
 // ═══════════════════════════════════════════════════════════════════════════