refactor: tighten canonical tool-call typing and display mapping

packages/app/src/utils/tool-call-display.test.ts

@@ -1,11 +1,15 @@
 import { describe, expect, it } from "vitest";
 
-import { buildToolCallDisplayModel, formatToolCallError } from "./tool-call-display";
+import { buildToolCallDisplayModel } from "./tool-call-display";
 
 describe("tool-call-display", () => {
   it("builds display model from canonical shell detail", () => {
     const display = buildToolCallDisplayModel({
       name: "shell",
+      status: "running",
+      input: { command: "npm test" },
+      output: null,
+      error: null,
       detail: {
         type: "shell",
         command: "npm test",
@@ -13,7 +17,6 @@ describe("tool-call-display", () => {
     });
 
     expect(display).toEqual({
-      kind: "execute",
       displayName: "Shell",
       summary: "npm test",
     });
@@ -22,6 +25,10 @@ describe("tool-call-display", () => {
   it("builds display model from canonical read detail", () => {
     const display = buildToolCallDisplayModel({
       name: "read_file",
+      status: "completed",
+      input: { path: "/tmp/repo/src/index.ts" },
+      output: { content: "hello" },
+      error: null,
       detail: {
         type: "read",
         filePath: "/tmp/repo/src/index.ts",
@@ -30,7 +37,6 @@ describe("tool-call-display", () => {
     });
 
     expect(display).toEqual({
-      kind: "read",
       displayName: "Read",
       summary: "src/index.ts",
     });
@@ -39,13 +45,16 @@ describe("tool-call-display", () => {
   it("uses metadata summary for task tool calls", () => {
     const display = buildToolCallDisplayModel({
       name: "task",
+      status: "running",
+      input: null,
+      output: null,
+      error: null,
       metadata: {
         subAgentActivity: "Running tests",
       },
     });
 
     expect(display).toEqual({
-      kind: "agent",
       displayName: "Task",
       summary: "Running tests",
     });
@@ -54,15 +63,40 @@ describe("tool-call-display", () => {
   it("falls back to humanized tool name for unknown tools", () => {
     const display = buildToolCallDisplayModel({
       name: "custom_tool_name",
+      status: "completed",
+      input: null,
+      output: null,
+      error: null,
     });
 
     expect(display).toEqual({
-      kind: "tool",
       displayName: "Custom Tool Name",
     });
   });
 
-  it("formats non-string errors", () => {
-    expect(formatToolCallError({ message: "boom" })).toBe('{\n  "message": "boom"\n}');
+  it("does not derive command summary from raw input when detail is missing", () => {
+    const display = buildToolCallDisplayModel({
+      name: "exec_command",
+      status: "running",
+      input: { command: "npm run test" },
+      output: null,
+      error: null,
+    });
+
+    expect(display).toEqual({
+      displayName: "Exec Command",
+    });
+  });
+
+  it("returns formatted errorText from the same display pipeline", () => {
+    const display = buildToolCallDisplayModel({
+      name: "shell",
+      status: "failed",
+      input: { command: "false" },
+      output: null,
+      error: { message: "boom" },
+    });
+
+    expect(display.errorText).toBe('{\n  "message": "boom"\n}');
   });
 });