refactor: tighten canonical tool-call typing and display mapping

2026-02-09 08:53:27 +07:00
parent 0176614467
commit 6d4992b2f5
25 changed files with 2833 additions and 1764 deletions
@@ -0,0 +1,119 @@
+import type { ToolCallTimelineItem } from "../server/agent/agent-sdk-types.js";
+
+export type ToolCallDisplayInput = Pick<
+  ToolCallTimelineItem,
+  "name" | "status" | "input" | "output" | "error" | "metadata" | "detail"
+> & {
+  cwd?: string;
+};
+
+export type ToolCallDisplayModel = {
+  displayName: string;
+  summary?: string;
+  errorText?: string;
+};
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return typeof value === "object" && value !== null && !Array.isArray(value);
+}
+
+function readString(value: unknown): string | undefined {
+  return typeof value === "string" && value.length > 0 ? value : undefined;
+}
+
+function humanizeToolName(name: string): string {
+  const trimmed = name.trim();
+  if (!trimmed) {
+    return name;
+  }
+  if (/[:./]/.test(trimmed) || trimmed.includes("__")) {
+    return trimmed;
+  }
+
+  return trimmed
+    .replace(/[._-]+/g, " ")
+    .split(" ")
+    .filter((segment) => segment.length > 0)
+    .map((segment) => `${segment[0]?.toUpperCase() ?? ""}${segment.slice(1)}`)
+    .join(" ");
+}
+
+function stripCwdPrefix(filePath: string, cwd?: string): string {
+  if (!cwd || !filePath) {
+    return filePath;
+  }
+
+  const normalizedCwd = cwd.replace(/\\/g, "/").replace(/\/+$/, "");
+  const normalizedPath = filePath.replace(/\\/g, "/");
+  const prefix = `${normalizedCwd}/`;
+
+  if (normalizedPath.startsWith(prefix)) {
+    return normalizedPath.slice(prefix.length);
+  }
+  if (normalizedPath === normalizedCwd) {
+    return ".";
+  }
+  return filePath;
+}
+
+function formatErrorText(error: unknown): string | undefined {
+  if (error === null || error === undefined) {
+    return undefined;
+  }
+  if (typeof error === "string") {
+    return error;
+  }
+  if (isRecord(error) && typeof error.content === "string") {
+    return error.content;
+  }
+  try {
+    return JSON.stringify(error, null, 2);
+  } catch {
+    return String(error);
+  }
+}
+
+export function buildToolCallDisplayModel(input: ToolCallDisplayInput): ToolCallDisplayModel {
+  const lowerName = input.name.trim().toLowerCase();
+
+  let displayName = humanizeToolName(input.name);
+  let summary: string | undefined;
+
+  if (input.detail) {
+    switch (input.detail.type) {
+      case "shell":
+        displayName = "Shell";
+        summary = input.detail.command;
+        break;
+      case "read":
+        displayName = "Read";
+        summary = stripCwdPrefix(input.detail.filePath, input.cwd);
+        break;
+      case "edit":
+        displayName = "Edit";
+        summary = stripCwdPrefix(input.detail.filePath, input.cwd);
+        break;
+      case "write":
+        displayName = "Write";
+        summary = stripCwdPrefix(input.detail.filePath, input.cwd);
+        break;
+      case "search":
+        displayName = "Search";
+        summary = input.detail.query;
+        break;
+    }
+  } else if (lowerName === "task") {
+    displayName = "Task";
+    summary = isRecord(input.metadata) ? readString(input.metadata.subAgentActivity) : undefined;
+  } else if (lowerName === "thinking") {
+    displayName = "Thinking";
+  }
+
+  const errorText = input.status === "failed" ? formatErrorText(input.error) : undefined;
+
+  return {
+    displayName,
+    ...(summary ? { summary } : {}),
+    ...(errorText ? { errorText } : {}),
+  };
+}