jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove pinned launchers from workspace rows

Browse Source
This commit is contained in:
Mohamed Boudra
2026-06-15 15:02:38 +07:00
parent e84a3ff574
commit 754f6336c0
6 changed files with 1 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app/e2e/helpers/pins.ts
-4
View File
@@ -19,10 +19,6 @@ export function tabRowPin(page: Page, target: PinnedTabTarget) {
return page.getByTestId(`workspace-pinned-target-${pinnedTargetKey(target)}`);
}
export function sidebarPin(page: Page, target: PinnedTabTarget) {
return page.getByTestId(`sidebar-pinned-target-${pinnedTargetKey(target)}`);
}
export async function openNewTabMenu(page: Page): Promise<void> {
const trigger = page
.getByTestId("workspace-new-tab-menu-trigger")
packages/app/e2e/workspace-pins.spec.ts
+1 -22
View File
@@ -1,9 +1,7 @@
import { test, expect } from "./fixtures";
import { gotoWorkspace } from "./helpers/launcher";
import { gotoAppShell } from "./helpers/app";
import { getServerId } from "./helpers/server-id";
import { seedWorkspace, type SeededWorkspace } from "./helpers/seed-client";
import { togglePinFromMenu, tabRowPin, sidebarPin } from "./helpers/pins";
import { togglePinFromMenu, tabRowPin } from "./helpers/pins";
import { expectTerminalTabOpen } from "./helpers/workspace-tabs";
import type { PinnedTabTarget } from "../src/workspace-pins/target";
@@ -45,23 +43,4 @@ test.describe("Pinned tab targets", () => {
await expectTerminalTabOpen(page);
});
test("the pinned button is mirrored in the sidebar workspace row and launches a terminal in that workspace", async ({
page,
}) => {
test.setTimeout(45_000);
await gotoWorkspace(page, workspace.workspaceId);
await togglePinFromMenu(page, TERMINAL_TARGET);
await gotoAppShell(page);
const row = page.getByTestId(`sidebar-workspace-row-${getServerId()}:${workspace.workspaceId}`);
await expect(row).toBeVisible({ timeout: 30_000 });
await row.hover();
await expect(sidebarPin(page, TERMINAL_TARGET)).toBeVisible({ timeout: 10_000 });
await sidebarPin(page, TERMINAL_TARGET).click();
await expect(page).toHaveURL(/\/workspace\//, { timeout: 30_000 });
await expectTerminalTabOpen(page);
});
});