chore(app): clean up e2e helpers — delete duplicates, dead code, and redundant seeding (#723)

- Delete clickNewTabButton (duplicate of clickNewChat) and clickNewTerminalButton (duplicate of clickNewTerminal); update all call sites
- Rename clickTerminal → clickNewTerminal to match clickNewChat naming pattern
- Delete waitForLauncherPanel (deprecated no-op)
- Delete waitForAgentFinishUI and getToolCallCount (dead exports never imported)
- Remove ensureE2EStorageSeeded, assertE2EUsesSeededTestDaemon, and related helpers from app.ts — the paseoE2ESetup auto-fixture seeds via addInitScript on every navigation, making these redundant
- Simplify gotoAppShell to a one-liner; simplify gotoHome to use .or() instead of three-way if-else chain
- Strip try/catch self-heal from ensureHostSelected — the fixture guarantees preferences alignment, so the workaround is never needed

packages/app/e2e/launcher-tab.spec.ts

@@ -5,10 +5,9 @@ import {
   assertNewChatTileVisible,
   assertTerminalTileVisible,
   assertSingleNewTabButton,
-  clickNewTabButton,
   pressNewTabShortcut,
   clickNewChat,
-  clickTerminal,
+  clickNewTerminal,
   countTabsOfKind,
   getTabTestIds,
   waitForTabWithTitle,
@@ -77,7 +76,7 @@ test.describe("Tab creation", () => {
   test("clicking new agent tab creates a draft tab", async ({ page }) => {
     await gotoWorkspace(page, workspaceId);
 
-    await clickNewTabButton(page);
+    await clickNewChat(page);
 
     // Draft composer should appear (the agent message input)
     const composer = page.getByRole("textbox", { name: "Message agent..." });
@@ -92,7 +91,7 @@ test.describe("Tab creation", () => {
     test.setTimeout(45_000);
     await gotoWorkspace(page, workspaceId);
 
-    await clickTerminal(page);
+    await clickNewTerminal(page);
 
     // Terminal surface should appear
     const terminal = page.locator('[data-testid="terminal-surface"]');
@@ -141,7 +140,7 @@ test.describe("Terminal title propagation", () => {
     try {
       // Navigate to workspace and open a terminal
       await gotoWorkspace(page, workspaceId);
-      await clickTerminal(page);
+      await clickNewTerminal(page);
 
       const terminal = page.locator('[data-testid="terminal-surface"]');
       await expect(terminal.first()).toBeVisible({ timeout: 20_000 });
@@ -171,7 +170,7 @@ test.describe("Terminal title propagation", () => {
 
     try {
       await gotoWorkspace(page, workspaceId);
-      await clickTerminal(page);
+      await clickNewTerminal(page);
 
       const terminal = page.locator('[data-testid="terminal-surface"]');
       await expect(terminal.first()).toBeVisible({ timeout: 20_000 });
@@ -231,7 +230,7 @@ test.describe("Tab transitions (no flash)", () => {
     const terminal = page.locator('[data-testid="terminal-surface"]');
     const elapsed = await measureTileTransition(
       page,
-      () => clickTerminal(page),
+      () => clickNewTerminal(page),
       terminal.first(),
       20_000,
     );