chore(app): clean up e2e helpers — delete duplicates, dead code, and redundant seeding (#723)

- Delete clickNewTabButton (duplicate of clickNewChat) and clickNewTerminalButton (duplicate of clickNewTerminal); update all call sites
- Rename clickTerminal → clickNewTerminal to match clickNewChat naming pattern
- Delete waitForLauncherPanel (deprecated no-op)
- Delete waitForAgentFinishUI and getToolCallCount (dead exports never imported)
- Remove ensureE2EStorageSeeded, assertE2EUsesSeededTestDaemon, and related helpers from app.ts — the paseoE2ESetup auto-fixture seeds via addInitScript on every navigation, making these redundant
- Simplify gotoAppShell to a one-liner; simplify gotoHome to use .or() instead of three-way if-else chain
- Strip try/catch self-heal from ensureHostSelected — the fixture guarantees preferences alignment, so the workaround is never needed
This commit is contained in:
Mohamed Boudra
2026-05-05 19:58:55 +07:00
parent b2af00b037
commit 79dac91a7a
6 changed files with 33 additions and 311 deletions
+3 -3
View File
@@ -1,5 +1,5 @@
import { expect, test } from "./fixtures";
import { clickTerminal } from "./helpers/launcher";
import { clickNewTerminal } from "./helpers/launcher";
import { setupDeterministicPrompt, waitForTerminalContent } from "./helpers/terminal-perf";
test.describe("Workspace cwd correctness", () => {
@@ -11,7 +11,7 @@ test.describe("Workspace cwd correctness", () => {
const workspace = await withWorkspace({ prefix: "workspace-cwd-main-" });
await workspace.navigateTo();
await clickTerminal(page);
await clickNewTerminal(page);
const terminal = page.locator('[data-testid="terminal-surface"]');
await expect(terminal.first()).toBeVisible({ timeout: 20_000 });
@@ -31,7 +31,7 @@ test.describe("Workspace cwd correctness", () => {
const workspace = await withWorkspace({ worktree: true, prefix: "workspace-cwd-worktree-" });
await workspace.navigateTo();
await clickTerminal(page);
await clickNewTerminal(page);
const terminal = page.locator('[data-testid="terminal-surface"]');
await expect(terminal.first()).toBeVisible({ timeout: 20_000 });