jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Migrate image encoding to expo-file-system File API

Browse Source
This commit is contained in:
Mohamed Boudra
2025-12-29 10:51:06 +07:00
parent 1200bce7e3
commit 7a024ce7fd
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plan.md
+11
View File
@@ -191,3 +191,14 @@ Improvements to the new agent screen in the app.
- Ensure temp files are created under `/tmp/paseo-attachments` and prompt only references the file path.
- Add a lightweight regression test or log assertion if possible.
- **Done (2025-12-29 10:34)**: WHAT: `packages/server/src/server/agent/providers/codex-mcp-agent.ts:2333-2412` now normalizes inline data URLs, writes attachments under `/tmp/paseo-attachments`, and replaces embedded base64 in prompt strings/blocks with temp file paths (plus a log when replacements occur). RESULT: Codex prompt text no longer carries inline base64 data URLs and uses temp file references instead. EVIDENCE: Not run (not requested).
- [x] **Fix**: Migrate expo-file-system to new API for React Native image encoding.
- Error in RN: `Method readAsStringAsync imported from "expo-file-system" is deprecated`.
- The error occurs at `packages/app/src/contexts/session-context.tsx:1332` when encoding images on native platforms.
- Current code uses `FileSystem.readAsStringAsync(uri, { encoding: "base64" })` which is deprecated.
- Search the web for Expo's new filesystem API using `File` and `Directory` classes.
- Check the Expo documentation for the recommended migration path.
- Update `encodeImages` function to use the new API for native platforms while keeping web handling unchanged.
- Test image attachments on iOS/Android after the fix.
- **Done (2025-12-29 10:50)**: WHAT: `packages/app/src/contexts/session-context.tsx:22` swaps the import to `File` from the new expo-file-system API; `packages/app/src/contexts/session-context.tsx:1332-1333` uses `new File(uri).base64()` instead of `readAsStringAsync` for native image encoding. RESULT: Native image encoding no longer relies on deprecated `readAsStringAsync`. EVIDENCE: Not run (iOS/Android testing not requested).