fix(forge): preserve non-default port in forge web URLs (#2478)

"Open in browser" links for a self-hosted forge served on a non-standard
port (e.g. Forgejo/Gitea on :60443) dropped the port, producing
https://host/owner/repo/... instead of https://host:60443/owner/repo/...,
which 404s or hits the wrong service.

parseGitRemoteLocation discarded parsed.port (GitRemoteLocation had no
port field), and buildForgeBranchTreeUrl / buildForgeBlobUrl rebuilt the
origin from the portless host. Preserve the port on GitRemoteLocation and
reattach it in the web-URL builders, only for self-hosted http(s) origins
(an SSH port isn't the web port; a canonicalized cloud host uses the
default port). Host-identity matching (forge detection, cloud-host checks)
stays port-agnostic.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Li Mu Zhi
2026-07-28 04:00:46 +08:00
committed by GitHub
co-authored by Claude Opus 4.8
parent c596e058cd
commit 869edcbf11
4 changed files with 80 additions and 9 deletions
+30
View File
@@ -44,6 +44,24 @@ describe("buildForgeBranchTreeUrl", () => {
).toBe("https://codeberg.org/acme/repo/src/branch/main");
});
it("preserves a non-default port for a self-hosted https remote", () => {
expect(
buildForgeBranchTreeUrl("forgejo", {
remoteUrl: "https://home-git.example.com:60443/team/repo.git",
branch: "master",
}),
).toBe("https://home-git.example.com:60443/team/repo/src/branch/master");
});
it("omits the port for a self-hosted remote on the default port", () => {
expect(
buildForgeBranchTreeUrl("forgejo", {
remoteUrl: "https://home-git.example.com/team/repo.git",
branch: "master",
}),
).toBe("https://home-git.example.com/team/repo/src/branch/master");
});
it("returns null when the current branch is unavailable", () => {
expect(
buildForgeBranchTreeUrl("github", {
@@ -131,6 +149,18 @@ describe("buildForgeBlobUrl", () => {
).toBe("https://github.acme.internal/team/repo/blob/main/src/index.ts");
});
it("preserves a non-default port for a self-hosted https remote", () => {
expect(
buildForgeBlobUrl("forgejo", {
remoteUrl: "https://home-git.example.com:60443/team/repo.git",
branch: "master",
path: "src/index.ts",
lineStart: 12,
lineEnd: 20,
}),
).toBe("https://home-git.example.com:60443/team/repo/src/branch/master/src/index.ts#L12-L20");
});
it("canonicalizes the github.com SSH-alias host to the web host", () => {
expect(
buildForgeBlobUrl("github", {