Fix draft mode chip for non-thinking models

Keep the desktop controls row alive when desktop extras exist, so draft mode chips still render even when a model has no thinking options.\n\nRestore the replacement draft e2e assertion for the mode chip now that it renders again.
This commit is contained in:
Mohamed Boudra
2026-05-26 20:15:11 +07:00
parent f79101a1f0
commit 88914ccba6
2 changed files with 6 additions and 5 deletions
@@ -126,10 +126,7 @@ async function expectReplacementDraftMatchesPreviousSetup(page: Page): Promise<v
await expect( await expect(
page.getByRole("button", { name: "Select model (Ten second stream)" }), page.getByRole("button", { name: "Select model (Ten second stream)" }),
).toBeVisible(); ).toBeVisible();
// TODO(boudra): the replacement draft's mode picker stopped rendering after await expect(page.getByRole("button", { name: "Select agent mode (Load test)" })).toBeVisible();
// the composer refactor — the model carries over but modes aren't surfaced
// in the draft's provider snapshot. Restore this assertion once the draft
// mode picker is fixed.
} }
async function createAgentFromReplacementDraft(page: Page): Promise<void> { async function createAgentFromReplacementDraft(page: Page): Promise<void> {
@@ -195,17 +195,20 @@ function resolveHasAnyControl({
canSelectModel, canSelectModel,
thinkingOptions, thinkingOptions,
features, features,
hasDesktopExtras,
}: { }: {
providerOptions: AgentControlOption[] | undefined; providerOptions: AgentControlOption[] | undefined;
canSelectModel: boolean; canSelectModel: boolean;
thinkingOptions: AgentControlOption[] | undefined; thinkingOptions: AgentControlOption[] | undefined;
features: AgentFeature[] | undefined; features: AgentFeature[] | undefined;
hasDesktopExtras: boolean;
}) { }) {
return ( return (
Boolean(providerOptions?.length) || Boolean(providerOptions?.length) ||
canSelectModel || canSelectModel ||
Boolean(thinkingOptions?.length) || Boolean(thinkingOptions?.length) ||
Boolean(features?.length) Boolean(features?.length) ||
hasDesktopExtras
); );
} }
@@ -440,6 +443,7 @@ function ControlledAgentControls({
canSelectModel, canSelectModel,
thinkingOptions, thinkingOptions,
features, features,
hasDesktopExtras: desktopExtras !== null && desktopExtras !== undefined,
}); });
const modelDisabled = disabled; const modelDisabled = disabled;