From 89db6d31872b41757a81eb6e1098304687e87229 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Tue, 14 Apr 2026 17:27:23 +0700 Subject: [PATCH] fix(app): restore combobox flash prevention condition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `referenceAtOrigin` check in `hasResolvedDesktopPosition` was accidentally inverted during the provider profiles refactor (6f280276). `!referenceAtOrigin` made the condition trivially true for all normal triggers, letting the dropdown show at (0,0) before floating-ui resolved the real position — visible as a left-side flash on the very first open. --- packages/app/src/components/ui/combobox.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app/src/components/ui/combobox.tsx b/packages/app/src/components/ui/combobox.tsx index a646bac20..12138f4d7 100644 --- a/packages/app/src/components/ui/combobox.tsx +++ b/packages/app/src/components/ui/combobox.tsx @@ -440,7 +440,7 @@ export function Combobox({ ? clampedMeasuredTopStartLeft !== null && measuredTopStartBottom !== null : floatingLeft !== null && floatingTop !== null && - (hasNonZeroFloatingPosition || !referenceAtOrigin)); + (hasNonZeroFloatingPosition || referenceAtOrigin)); const shouldHideDesktopContent = desktopPreventInitialFlash && !hasResolvedDesktopPosition; const shouldUseDesktopFade = !desktopPreventInitialFlash;