From 99bac0fd27afa0207689492895fd7c1a66912afa Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Wed, 11 Mar 2026 01:50:24 +0700 Subject: [PATCH] fix(tests): iteration 18 --- packages/app/e2e/agent-bottom-anchor.spec.ts | 2 ++ .../app/e2e/helpers/agent-bottom-anchor.ts | 18 ++---------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/packages/app/e2e/agent-bottom-anchor.spec.ts b/packages/app/e2e/agent-bottom-anchor.spec.ts index 6237086a9..c8ba452f5 100644 --- a/packages/app/e2e/agent-bottom-anchor.spec.ts +++ b/packages/app/e2e/agent-bottom-anchor.spec.ts @@ -121,6 +121,8 @@ test("sticky mode stays pinned through composer growth and viewport resize, but await expect(page.getByTestId("scroll-to-bottom-button")).toHaveCount(0); await page.setViewportSize({ width: 820, height: 760 }); + await openWorkspaceAgentTab(page, agent.id); + await waitForAgentReady(page, agent.expectedTailText); await expectNearBottom(page); await scrollUpFromBottom(page, 720); diff --git a/packages/app/e2e/helpers/agent-bottom-anchor.ts b/packages/app/e2e/helpers/agent-bottom-anchor.ts index 9f7a0e037..8bc497d35 100644 --- a/packages/app/e2e/helpers/agent-bottom-anchor.ts +++ b/packages/app/e2e/helpers/agent-bottom-anchor.ts @@ -171,14 +171,7 @@ function getVisibleChatScroll(page: Page) { export async function readScrollMetrics(page: Page): Promise { return getVisibleChatScroll(page).evaluate((root: Element) => { - const rootElement = root as HTMLElement; - const candidates = [rootElement, ...Array.from(rootElement.querySelectorAll("*"))]; - const scrollElement = - candidates.find( - (element) => - element instanceof HTMLElement && - element.scrollHeight - element.clientHeight > 1 - ) ?? rootElement; + const scrollElement = root as HTMLElement; const offsetY = Math.max(0, scrollElement.scrollTop); const contentHeight = Math.max(0, scrollElement.scrollHeight); @@ -202,14 +195,7 @@ export async function scrollUpFromBottom(page: Page, pixels: number): Promise { - const rootElement = root as HTMLElement; - const candidates = [rootElement, ...Array.from(rootElement.querySelectorAll("*"))]; - const scrollElement = - candidates.find( - (element) => - element instanceof HTMLElement && - element.scrollHeight - element.clientHeight > 1 - ) ?? rootElement; + const scrollElement = root as HTMLElement; const bottomOffset = Math.max( 0,