From a6a533bc6a1989c291ab4c1e65fbb00c2b02c975 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Mon, 17 Aug 2026 23:18:55 +0200 Subject: [PATCH] fix(app): simplify workspace add-tab labels Use noun labels in the add-tab menu so creation targets read consistently alongside Changes, Files, and Pull request. Keep verb-oriented labels in shortcut and command surfaces. --- packages/app/e2e/browser/launcher-tab.spec.ts | 6 +++--- packages/app/e2e/support/helpers/launcher.ts | 2 +- .../src/screens/workspace/workspace-desktop-tabs-row.tsx | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/app/e2e/browser/launcher-tab.spec.ts b/packages/app/e2e/browser/launcher-tab.spec.ts index 31ef00c48..70a269ba8 100644 --- a/packages/app/e2e/browser/launcher-tab.spec.ts +++ b/packages/app/e2e/browser/launcher-tab.spec.ts @@ -61,7 +61,7 @@ test.describe("Tab creation", () => { await expect(page.getByRole("navigation", { name: "Settings" })).toBeVisible(); await page.keyboard.press(`${modifier}+t`); - await expect(page.getByRole("menuitem", { name: /New agent/ })).toHaveCount(0); + await expect(page.getByRole("menuitem", { name: /^Agent/ })).toHaveCount(0); await page.goto(workspaceUrl); await assertNewTabMenuTriggerVisible(page); @@ -101,8 +101,8 @@ test.describe("Tab creation", () => { await gotoWorkspace(page, workspace.workspaceId); await openNewTabMenuWithShortcut(page); - const agent = page.getByRole("menuitem", { name: /New agent/ }); - const terminal = page.getByRole("menuitem", { name: /New terminal/ }); + const agent = page.getByRole("menuitem", { name: /^Agent/ }); + const terminal = page.getByRole("menuitem", { name: /^Terminal/ }); const changes = page.getByRole("menuitem", { name: /Changes/ }); const files = page.getByRole("menuitem", { name: /Files/ }); const shortcutPrefix = process.platform === "darwin" ? /⇧⌘/ : /Ctrl.*Shift/; diff --git a/packages/app/e2e/support/helpers/launcher.ts b/packages/app/e2e/support/helpers/launcher.ts index c2a4fffc8..f1cdde984 100644 --- a/packages/app/e2e/support/helpers/launcher.ts +++ b/packages/app/e2e/support/helpers/launcher.ts @@ -70,7 +70,7 @@ export async function pressNewTabShortcut(page: Page): Promise { export async function openNewTabMenuWithShortcut(page: Page): Promise { await pressNewTabShortcut(page); - await expect(page.getByRole("menuitem", { name: /New agent/ })).toBeVisible(); + await expect(page.getByRole("menuitem", { name: /^Agent/ })).toBeVisible(); } export async function pressDirectNewTabShortcut(page: Page, key: string): Promise { diff --git a/packages/app/src/screens/workspace/workspace-desktop-tabs-row.tsx b/packages/app/src/screens/workspace/workspace-desktop-tabs-row.tsx index e8db0f14f..dde7085e6 100644 --- a/packages/app/src/screens/workspace/workspace-desktop-tabs-row.tsx +++ b/packages/app/src/screens/workspace/workspace-desktop-tabs-row.tsx @@ -381,7 +381,7 @@ function WorkspaceNewTabButton({ trailing={agentShortcut} onSelect={onCreateAgentTab} > - {t("workspace.tabs.actions.newAgent")} + {t("workspace.tabs.fallback.agent")} - {t("workspace.tabs.actions.newTerminal")} + {t("workspace.tabs.fallback.terminal")} {showCreateBrowserTab ? ( - {t("workspace.tabs.actions.newBrowser")} + {t("workspace.tabs.fallback.browser")} ) : null} {isGit ? (