feat(forge): pluggable forge abstraction + GitLab and Gitea/Forgejo/Codeberg (#1913)
* refactor(forge): forge-neutral foundation (GitHub-only) Decouple git-hosting from GitHub behind a neutral abstraction (issue #1616), GitHub-only for now; existing GitHub behaviour is unchanged. - Forge manifest, neutral ForgeService contract, forge registry + resolver, and a client forge-module registry. - GitHub code renamed to the neutral shape; PR/Issue attachment wording preserved. - forge.search.response enums parse tolerantly (unknown kind/auth state degrade instead of breaking the client). - createPullRequest reports typed CLI/auth errors instead of a generic message. - forge-resolver host/remote caches are LRU-bounded. - Forge host trust is explicit: only a known cloud host or a CLI-authenticated host is ever talked to; an unauthenticated GitHub Enterprise host fails resolution instead of routing to github.com. - Docs: forge-providers guide, glossary and i18n forge-copy conventions, architecture and rpc-namespacing terminology. - Vitest React Native mocks (unistyles, svg, linking, lucide) consolidated into shared aliased test-stubs. * feat(forge): GitLab adapter, forge-aware UI, pipelines and approvals GitLab adapter over the glab CLI on the neutral contracts: MR status, forge-aware UI, pipeline tree, and N-of-M approvals. - threadIsResolved is part of the neutral timeline item. - Pipeline load failures show an error instead of an empty section. - Manual pipeline jobs render as pending. - Fork/detached MR head pipelines are fetched by MR iid (glab ci get --merge-request). * feat(forge): Gitea family adapter (Gitea, Forgejo, Codeberg) One adapter over the tea CLI serving Gitea, Forgejo, and Codeberg on the neutral contracts. - CI status aggregates commit statuses and Actions runs together. - Gitea's terminal "warning" state maps to failure on server and client. - Gitea Actions check details are reachable from the PR pane by workflowRunId. * refactor(forge): localize compatibility handling * test(forge): expect normalized GitLab facts --------- Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
This commit is contained in:
co-authored by
Mohamed Boudra
parent
04d1ebdce0
commit
a8ebd390fa
@@ -0,0 +1,132 @@
|
||||
import { FORGE_IDS } from "@getpaseo/protocol/forge-manifest";
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { createForgeService, defaultForgeRegistry, ForgeRegistry } from "./forge-registry.js";
|
||||
import { createGitHubService } from "./github-service.js";
|
||||
|
||||
describe("forge registry", () => {
|
||||
it("builds the registered adapters", () => {
|
||||
const github = createForgeService("github");
|
||||
const gitlab = createForgeService("gitlab");
|
||||
const gitea = createForgeService("gitea");
|
||||
const forgejo = createForgeService("forgejo");
|
||||
expect(github?.getCurrentPullRequestStatus).toBeTypeOf("function");
|
||||
expect(gitlab?.getCurrentPullRequestStatus).toBeTypeOf("function");
|
||||
expect(gitea?.getCurrentPullRequestStatus).toBeTypeOf("function");
|
||||
expect(forgejo?.getCurrentPullRequestStatus).toBeTypeOf("function");
|
||||
});
|
||||
|
||||
it("returns null for an unregistered forge", () => {
|
||||
expect(createForgeService("bitbucket")).toBeNull();
|
||||
});
|
||||
|
||||
it("keeps the built-in registry in sync with the forge manifest", () => {
|
||||
expect([...defaultForgeRegistry.ids()].sort()).toEqual([...FORGE_IDS].sort());
|
||||
});
|
||||
|
||||
it("knows which forges are registered", () => {
|
||||
expect(defaultForgeRegistry.has("github")).toBe(true);
|
||||
expect(defaultForgeRegistry.has("gitlab")).toBe(true);
|
||||
expect(defaultForgeRegistry.has("gitea")).toBe(true);
|
||||
expect(defaultForgeRegistry.has("forgejo")).toBe(true);
|
||||
expect(defaultForgeRegistry.has("bitbucket")).toBe(false);
|
||||
expect(defaultForgeRegistry.ids()).toEqual(
|
||||
expect.arrayContaining(["github", "gitlab", "gitea", "forgejo"]),
|
||||
);
|
||||
});
|
||||
|
||||
it("registers a third-party adapter without changing the registry implementation", () => {
|
||||
const unregister = defaultForgeRegistry.register("bitbucket", {
|
||||
createService: createGitHubService,
|
||||
matchesHost: (host) => host === "bitbucket.org",
|
||||
});
|
||||
try {
|
||||
expect(defaultForgeRegistry.has("bitbucket")).toBe(true);
|
||||
expect(createForgeService("bitbucket")?.getCurrentPullRequestStatus).toBeTypeOf("function");
|
||||
} finally {
|
||||
unregister();
|
||||
}
|
||||
expect(defaultForgeRegistry.has("bitbucket")).toBe(false);
|
||||
});
|
||||
|
||||
it("lets adapters own heuristic and asynchronous host detection", async () => {
|
||||
const registry = new ForgeRegistry([
|
||||
[
|
||||
"bitbucket",
|
||||
{
|
||||
createService: createGitHubService,
|
||||
matchesHost: (host) => host === "bitbucket.org",
|
||||
probeHost: async (host) => host === "git.acme.internal",
|
||||
},
|
||||
],
|
||||
]);
|
||||
|
||||
expect(registry.matchHost("bitbucket.org")).toBe("bitbucket");
|
||||
await expect(registry.probeHost("git.acme.internal")).resolves.toBe("bitbucket");
|
||||
});
|
||||
|
||||
it("does not infer self-managed forges from host substrings", () => {
|
||||
expect(defaultForgeRegistry.matchHost("gitea-forgejo.example.org")).toBeNull();
|
||||
expect(defaultForgeRegistry.matchHost("gitlab.example.org")).toBeNull();
|
||||
expect(defaultForgeRegistry.matchHost("notgitlab.example.org")).toBeNull();
|
||||
});
|
||||
|
||||
it("treats a probe that throws as 'not this forge' rather than crashing detection", async () => {
|
||||
const registry = new ForgeRegistry([
|
||||
[
|
||||
"flaky",
|
||||
{
|
||||
createService: createGitHubService,
|
||||
probeHost: async () => {
|
||||
throw new Error("CLI not installed");
|
||||
},
|
||||
},
|
||||
],
|
||||
[
|
||||
"reachable",
|
||||
{
|
||||
createService: createGitHubService,
|
||||
probeHost: async (host) => host === "git.acme.internal",
|
||||
},
|
||||
],
|
||||
]);
|
||||
|
||||
await expect(registry.probeHost("git.acme.internal")).resolves.toBe("reachable");
|
||||
await expect(registry.probeHost("git.unknown.internal")).resolves.toBeNull();
|
||||
});
|
||||
|
||||
it("degrades ambiguous host detection to no forge instead of depending on registration order", async () => {
|
||||
const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
|
||||
try {
|
||||
const registry = new ForgeRegistry([
|
||||
[
|
||||
"first",
|
||||
{
|
||||
createService: createGitHubService,
|
||||
matchesHost: () => true,
|
||||
probeHost: async () => true,
|
||||
},
|
||||
],
|
||||
[
|
||||
"second",
|
||||
{
|
||||
createService: createGitHubService,
|
||||
matchesHost: () => true,
|
||||
probeHost: async () => true,
|
||||
},
|
||||
],
|
||||
]);
|
||||
|
||||
expect(registry.matchHost("git.acme.internal")).toBeNull();
|
||||
await expect(registry.probeHost("git.acme.internal")).resolves.toBeNull();
|
||||
expect(warn).toHaveBeenCalledWith(
|
||||
expect.stringMatching(/Multiple forge adapters matched host/),
|
||||
);
|
||||
expect(warn).toHaveBeenCalledWith(
|
||||
expect.stringMatching(/Multiple forge adapters recognized host/),
|
||||
);
|
||||
} finally {
|
||||
warn.mockRestore();
|
||||
}
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user