Add toast provider, agent details sheet, and remote-based grouping

This commit is contained in:
Mohamed Boudra
2026-01-25 09:41:17 +07:00
parent ccd175b4b7
commit aa979f5230
8 changed files with 731 additions and 25 deletions
@@ -0,0 +1,69 @@
import { describe, expect, it } from "vitest";
import { deriveRemoteProjectKey, groupAgents } from "./agent-grouping";
import type { AggregatedAgent } from "@/hooks/use-aggregated-agents";
function makeAgent(overrides: Partial<AggregatedAgent> = {}): AggregatedAgent {
const now = new Date();
return {
id: overrides.id ?? "a1",
serverId: overrides.serverId ?? "s1",
serverLabel: (overrides as any).serverLabel ?? "server",
title: overrides.title ?? null,
status: overrides.status ?? ("running" as AggregatedAgent["status"]),
lastActivityAt: overrides.lastActivityAt ?? now,
cwd: overrides.cwd ?? "/tmp/repo",
provider: overrides.provider ?? ("openai" as any),
requiresAttention: overrides.requiresAttention ?? false,
attentionReason: overrides.attentionReason ?? null,
attentionTimestamp: overrides.attentionTimestamp ?? null,
parentAgentId: overrides.parentAgentId ?? null,
} as AggregatedAgent;
}
describe("deriveRemoteProjectKey", () => {
it("normalizes GitHub SSH and HTTPS to the same key", () => {
const ssh = "git@github.com:owner/repo.git";
const https = "https://github.com/owner/repo";
expect(deriveRemoteProjectKey(ssh)).toBe("remote:github.com/owner/repo");
expect(deriveRemoteProjectKey(https)).toBe("remote:github.com/owner/repo");
});
it("includes host for non-GitHub remotes", () => {
const gitlab = "git@gitlab.example.com:group/repo.git";
expect(deriveRemoteProjectKey(gitlab)).toBe(
"remote:gitlab.example.com/group/repo"
);
});
});
describe("groupAgents", () => {
it("groups active agents by remote URL when available", () => {
const agents = [
makeAgent({ id: "a1", cwd: "/Users/me/dev/paseo" }),
makeAgent({ id: "a2", cwd: "/Users/me/dev/paseo-fix/worktree" }),
];
const { activeGroups } = groupAgents(agents, {
getRemoteUrl: () => "git@github.com:moboudra/paseo.git",
});
expect(activeGroups).toHaveLength(1);
expect(activeGroups[0]?.agents.map((a) => a.id).sort()).toEqual([
"a1",
"a2",
]);
});
it("falls back to cwd grouping when remote URL is unavailable", () => {
const agents = [
makeAgent({ id: "a1", cwd: "/Users/me/dev/paseo" }),
makeAgent({ id: "a2", cwd: "/Users/me/dev/paseo-fix/worktree" }),
];
const { activeGroups } = groupAgents(agents, {
getRemoteUrl: () => null,
});
expect(activeGroups).toHaveLength(2);
});
});
+81 -2
View File
@@ -15,6 +15,71 @@ export function deriveProjectKey(cwd: string): string {
return cwd;
}
/**
* Produces a stable grouping key from a git remote URL.
*
* Waterfall:
* - Prefer a GitHub key (normalizes SSH/HTTPS to the same key).
* - Fallback to a generic host/path key (still normalized across SSH/HTTPS).
*/
export function deriveRemoteProjectKey(remoteUrl: string | null): string | null {
if (!remoteUrl) {
return null;
}
const trimmed = remoteUrl.trim();
if (!trimmed) {
return null;
}
// Support the common forms:
// - git@github.com:owner/repo.git
// - https://github.com/owner/repo(.git)
// - ssh://git@github.com/owner/repo(.git)
let host: string | null = null;
let path: string | null = null;
// SSH scp-like form: user@host:owner/repo(.git)
const scpLike = trimmed.match(/^[^@]+@([^:]+):(.+)$/);
if (scpLike) {
host = scpLike[1] ?? null;
path = scpLike[2] ?? null;
} else if (trimmed.includes("://")) {
try {
const parsed = new URL(trimmed);
host = parsed.hostname || null;
path = parsed.pathname ? parsed.pathname.replace(/^\//, "") : null;
} catch {
// Fall through to best-effort parsing below.
}
}
if (!host || !path) {
return null;
}
let cleanedPath = path.trim().replace(/^\/+/, "").replace(/\/+$/, "");
if (cleanedPath.endsWith(".git")) {
cleanedPath = cleanedPath.slice(0, -4);
}
// Best-effort: owner/repo is the common case.
// If the path is longer (e.g. groups/subgroups/repo), still keep it.
if (!cleanedPath.includes("/")) {
return null;
}
const cleanedHost = host.toLowerCase();
// GitHub normalization: treat github.com as a special "well-known" host to
// match the intended UX: group by repo even across different local worktrees.
if (cleanedHost === "github.com") {
return `remote:github.com/${cleanedPath}`;
}
return `remote:${cleanedHost}/${cleanedPath}`;
}
/**
* Extracts the repo name from a git remote URL.
* Examples:
@@ -137,11 +202,22 @@ export interface GroupedAgents {
const ACTIVE_GRACE_PERIOD_MS = 5 * 60 * 1000; // 5 minutes
interface GroupAgentsOptions {
/**
* Optional function to read a remote URL for an agent.
* If present and a remote URL is available, agents are grouped by remote.
*/
getRemoteUrl?: (agent: AggregatedAgent) => string | null;
}
/**
* Groups agents into active (by project) and inactive (by date) sections.
* Active = running, requires attention, or had activity within the last 5 minutes.
*/
export function groupAgents(agents: AggregatedAgent[]): GroupedAgents {
export function groupAgents(
agents: AggregatedAgent[],
options?: GroupAgentsOptions
): GroupedAgents {
const activeAgents: AggregatedAgent[] = [];
const inactiveAgents: AggregatedAgent[] = [];
const now = Date.now();
@@ -163,7 +239,10 @@ export function groupAgents(agents: AggregatedAgent[]): GroupedAgents {
// Group active agents by project
const projectMap = new Map<string, AggregatedAgent[]>();
for (const agent of activeAgents) {
const projectKey = deriveProjectKey(agent.cwd);
const remoteKey = deriveRemoteProjectKey(
options?.getRemoteUrl?.(agent) ?? null
);
const projectKey = remoteKey ?? deriveProjectKey(agent.cwd);
const existing = projectMap.get(projectKey) || [];
existing.push(agent);
projectMap.set(projectKey, existing);