From b090b4d2371ec60c756af0d599686dc2a87a39bc Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Mon, 27 Apr 2026 20:43:01 +0700 Subject: [PATCH] fix(server): align tests with SSH alias resolver and Windows rm flake - session.test.ts: drop stale 4th workspaceGitService arg from createPullRequest assertion (signature changed in ee5a23d9). - workspace-git-service.test.ts: bump local flushPromises microtask count to cover the extra await resolveGitHubRemoteForTarget step added by the GitHub remote resolver. - provider-windows-launch.test.ts: retry rmSync in afterEach to ride out Windows file locks from the spawned claude.cmd. --- .../server/agent/providers/provider-windows-launch.test.ts | 2 +- packages/server/src/server/session.test.ts | 3 --- packages/server/src/server/workspace-git-service.test.ts | 5 +++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/server/src/server/agent/providers/provider-windows-launch.test.ts b/packages/server/src/server/agent/providers/provider-windows-launch.test.ts index b3af30ff4..29b6221e0 100644 --- a/packages/server/src/server/agent/providers/provider-windows-launch.test.ts +++ b/packages/server/src/server/agent/providers/provider-windows-launch.test.ts @@ -141,7 +141,7 @@ function withPathEntry(dir: string, run: () => Promise): Promise { afterEach(() => { for (const dir of tempDirs.splice(0)) { - rmSync(dir, { recursive: true, force: true }); + rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 }); } }); diff --git a/packages/server/src/server/session.test.ts b/packages/server/src/server/session.test.ts index 3f20388e1..046f2b1e8 100644 --- a/packages/server/src/server/session.test.ts +++ b/packages/server/src/server/session.test.ts @@ -1180,9 +1180,6 @@ describe("session checkout pull request creation", () => { base: "main", }, expect.anything(), - expect.objectContaining({ - getCheckoutDiff: workspaceGitService.getCheckoutDiff, - }), ); expect(messages).toContainEqual({ type: "checkout_pr_create_response", diff --git a/packages/server/src/server/workspace-git-service.test.ts b/packages/server/src/server/workspace-git-service.test.ts index 966f3f91e..6d6c5a992 100644 --- a/packages/server/src/server/workspace-git-service.test.ts +++ b/packages/server/src/server/workspace-git-service.test.ts @@ -136,8 +136,9 @@ function createDirent(name: string, isDirectory: boolean) { } async function flushPromises(): Promise { - await Promise.resolve(); - await Promise.resolve(); + for (let i = 0; i < 6; i++) { + await Promise.resolve(); + } } function createDeferred() {