From bb55e5bc0dcd7c2ec03f5ff4381b890fa9118cbd Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Thu, 6 Aug 2026 15:40:57 +0200 Subject: [PATCH] fix(app): align needs-input alert sizes Keep the filled needs-input alert at one shared size across sidebar badges, workspace rows, and tab descriptors. --- .../app/src/components/sidebar/project-leading-visual.tsx | 4 ++-- packages/app/src/utils/status-indicator-geometry.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/app/src/components/sidebar/project-leading-visual.tsx b/packages/app/src/components/sidebar/project-leading-visual.tsx index b2932117c..9e43d301e 100644 --- a/packages/app/src/components/sidebar/project-leading-visual.tsx +++ b/packages/app/src/components/sidebar/project-leading-visual.tsx @@ -12,6 +12,7 @@ import { } from "@/utils/project-status-badge-content"; import { projectIconPlaceholderLabelFromDisplayName } from "@/utils/project-display-name"; import { getStatusDotColor } from "@/utils/status-dot-color"; +import { STATUS_INDICATOR_ALERT_SIZE } from "@/utils/status-indicator-geometry"; import type { SurfaceBackdrop } from "@/styles/surface-backdrop"; // Every surfaced status shares one badge shell, so the badge never changes size or position @@ -29,7 +30,6 @@ const STATUS_BADGE_OFFSET = -4; // The filled alert occupies the full badge shell so needs-input remains more prominent than // the passive status dots. const STATUS_BADGE_DOT_SIZE = 6; -const STATUS_BADGE_ALERT_SIZE = 12; // Matches the workspace title's lineHeight (sidebar-workspace-row-content's // workspaceBranchText) so the icon centers on the title rather than floating above it. const LEADING_SLOT_HEIGHT = 20; @@ -174,7 +174,7 @@ function ProjectStatusBadge({ testID="project-status-badge" > {content.kind === "alert" ? ( - + ) : ( )} diff --git a/packages/app/src/utils/status-indicator-geometry.ts b/packages/app/src/utils/status-indicator-geometry.ts index 87526f61f..c6bd876f7 100644 --- a/packages/app/src/utils/status-indicator-geometry.ts +++ b/packages/app/src/utils/status-indicator-geometry.ts @@ -1,2 +1,2 @@ export const STATUS_INDICATOR_DOT_SIZE = 8; -export const STATUS_INDICATOR_ALERT_SIZE = 14; +export const STATUS_INDICATOR_ALERT_SIZE = 12;