Fix shortcut capture ignoring - = ; ' keys (#2047)

* Fix shortcut capture ignoring - = ; ' keys

KEY_MAP was missing Minus/Equal/Semicolon/Quote, so
keyboardEventToComboString returned null for those physical keys and
the capture UI silently dropped them. Add the four entries with their
shifted variants.

Also suppress the Electron View > Zoom accelerators (Cmd+-/=/0) while
capturing, so those combos reach the renderer instead of zooming the
window. Driven by the existing capturingShortcut flag via a new
paseo:menu:set-capturing-shortcut IPC.

* fix: address review feedback from PR #2047

Trim the capturing useEffect so it only fires when capture is active
(removes the redundant on-mount false and the double-fire on true->false),
and reset the main-process capturingShortcut flag on renderer reload via
browser-window-created + did-finish-load so a Cmd+R mid-capture can't
leave the zoom accelerators disabled.

---------

Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
This commit is contained in:
OnCloud
2026-07-14 13:30:32 +02:00
committed by GitHub
co-authored by Mohamed Boudra
parent 9ea58aae0c
commit c0b801b805
6 changed files with 127 additions and 2 deletions
+2
View File
@@ -72,6 +72,8 @@ contextBridge.exposeInMainWorld("paseoDesktop", {
menu: {
showContextMenu: (input?: Record<string, unknown>) =>
ipcRenderer.invoke("paseo:menu:showContextMenu", input),
setCapturingShortcut: (capturing: boolean) =>
ipcRenderer.invoke("paseo:menu:set-capturing-shortcut", capturing),
},
browser: {
registerWorkspaceBrowser: (input: { browserId: string; workspaceId: string }) =>