fix(release): harden desktop recovery workflows

.github/workflows/desktop-release.yml

@@ -136,6 +136,12 @@ jobs:
         env:
           NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Patch Metro loader for Windows absolute paths
+        shell: pwsh
+        run: |
+          $patchPath = (Get-Item "$env:GITHUB_WORKSPACE/scripts/metro-config-windows-loader-patch.cjs").FullName
+          "NODE_OPTIONS=--require=$patchPath" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+
       - name: Build web app for Tauri
         run: npm run build:web --workspace=@getpaseo/app
 
@@ -371,16 +377,42 @@ jobs:
 
       - name: Build Linux Tauri release
         if: env.IS_SMOKE_TAG != 'true'
+        id: linux_tauri
+        continue-on-error: true
         env:
           TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
           TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
-          NO_STRIP: "true"
+          NO_STRIP: "1"
           APPIMAGE_EXTRACT_AND_RUN: "1"
         shell: bash
         run: |
           set -euo pipefail
           npm run tauri --workspace=@getpaseo/desktop build -- --bundles appimage
 
+      - name: Inspect failed Linux AppImage build
+        if: env.IS_SMOKE_TAG != 'true' && steps.linux_tauri.outcome == 'failure'
+        shell: bash
+        run: |
+          set -euxo pipefail
+          appimage_dir="packages/desktop/src-tauri/target/release/bundle/appimage"
+          ls -R "$appimage_dir" || true
+          script_path="$(find "$appimage_dir" -maxdepth 2 -type f -name 'build_appimage.sh' | head -n 1)"
+          if [ -z "$script_path" ]; then
+            echo "::error::build_appimage.sh was not generated"
+            exit 1
+          fi
+          sed -n '1,240p' "$script_path"
+          env | sort | grep -E '^(APPIMAGE|DESKTOP_VERSION|NO_STRIP|RELEASE_TAG|SOURCE_TAG|TAURI_)' || true
+          (
+            cd "$(dirname "$script_path")"
+            bash -x "./$(basename "$script_path")"
+          ) || true
+
+      - name: Fail Linux release when AppImage bundling fails
+        if: env.IS_SMOKE_TAG != 'true' && steps.linux_tauri.outcome == 'failure'
+        shell: bash
+        run: exit 1
+
       - name: Upload Linux release assets
         if: env.IS_SMOKE_TAG != 'true'
         env:

scripts/metro-config-windows-loader-patch.cjs

@@ -0,0 +1,20 @@
+const fs = require("fs");
+const path = require("path");
+const Module = require("module");
+
+const metroPackageRoot = path.dirname(require.resolve("metro-config/package.json"));
+const metroLoadConfigPath = path.join(metroPackageRoot, "src", "loadConfig.js");
+const originalJsLoader = Module._extensions[".js"];
+
+Module._extensions[".js"] = function patchedMetroConfigLoader(module, filename) {
+  if (filename === metroLoadConfigPath) {
+    let source = fs.readFileSync(filename, "utf8");
+    source = source.replace(
+      "const configModule = await import(absolutePath);",
+      "const { pathToFileURL } = require('node:url');\n        const configModule = await import(pathToFileURL(absolutePath).href);",
+    );
+    return module._compile(source, filename);
+  }
+
+  return originalJsLoader(module, filename);
+};