Fix hidden workspace file suggestions (#1609)

This commit is contained in:
Mohamed Boudra
2026-06-19 11:56:22 +08:00
committed by GitHub
parent ccb8714a71
commit e73b1c4724
2 changed files with 101 additions and 4 deletions
@@ -90,6 +90,7 @@ const IGNORED_SUGGESTION_DIRECTORY_NAMES = new Set([
"coverage",
"vendor",
"__pycache__",
".git",
]);
export async function searchHomeDirectories(
@@ -318,6 +319,9 @@ async function searchWorkspaceWithinParentDirectory(input: {
if (entry.kind === "file" && !input.includeFiles) {
continue;
}
if (isHiddenWorkspaceSuggestion(entry)) {
continue;
}
const rankedEntry = rankWorkspaceEntry({
absolutePath: entry.absolutePath,
kind: entry.kind,
@@ -385,6 +389,10 @@ async function searchWorkspaceAcrossTree(input: {
if (entry.kind === "directory" && !input.includeDirectories) {
continue;
}
// Hidden directories are traversed, but not offered as suggestions.
if (isHiddenWorkspaceSuggestion(entry)) {
continue;
}
if (entry.kind === "file" && !input.includeFiles) {
continue;
}
@@ -867,10 +875,19 @@ async function listWorkspaceChildEntries(input: {
const dirents = await readdir(input.directory, { withFileTypes: true }).catch(
() => [] as Dirent[],
);
const candidates = dirents.filter(
(dirent) =>
!isHiddenDirectoryName(dirent.name) && !isIgnoredSuggestionDirectoryName(dirent.name),
);
const candidates = dirents.filter((dirent) => {
if (isIgnoredSuggestionDirectoryName(dirent.name)) {
return false;
}
// Hidden directories must remain traversable so file links like
// `.claude/settings.local.json` can resolve, but hidden files (e.g.
// `.DS_Store`) should never be suggested.
if (dirent.isFile() && isHiddenDirectoryName(dirent.name)) {
return false;
}
return true;
});
const resolved = await Promise.all(
candidates.map(async (dirent) => {
const candidatePath = path.join(input.directory, dirent.name);
@@ -960,6 +977,10 @@ function isHiddenDirectoryName(name: string): boolean {
return name.startsWith(".");
}
function isHiddenWorkspaceSuggestion(entry: ChildWorkspaceEntry): boolean {
return isHiddenDirectoryName(entry.name);
}
function isIgnoredSuggestionDirectoryName(name: string): boolean {
return IGNORED_SUGGESTION_DIRECTORY_NAMES.has(name);
}