From ee4d72c706390638a13d0acd3f2fa6d8b3d298ab Mon Sep 17 00:00:00 2001
From: Mohamed Boudra <boudra.moha@gmail.com>
Date: Fri, 8 May 2026 21:25:41 +0700
Subject: [PATCH] fix(fastlane): use version: kwarg for Spaceship Build.all
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The submit_review lane was crashing with "unknown keyword: :filter"
because Spaceship::ConnectAPI::Build.all doesn't accept a filter hash;
it takes specific kwargs (app_id, version, build_number, etc.) and
constructs the JSON:API filter internally.

Also drop includes: "preReleaseVersion" — it's part of ESSENTIAL_INCLUDES
by default.

Add resubmit-ios-review.yml workflow so we can re-run only the
fastlane submit_review lane (no rebuild) against an existing
TestFlight build via workflow_dispatch.
---
 .../.eas/workflows/resubmit-ios-review.yml    | 21 +++++++++++++++++++
 packages/app/fastlane/Fastfile                |  3 +--
 2 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 packages/app/.eas/workflows/resubmit-ios-review.yml

diff --git a/packages/app/.eas/workflows/resubmit-ios-review.yml b/packages/app/.eas/workflows/resubmit-ios-review.yml
new file mode 100644
index 000000000..0b203de2c
--- /dev/null
+++ b/packages/app/.eas/workflows/resubmit-ios-review.yml
@@ -0,0 +1,21 @@
+name: Resubmit iOS for App Store review
+
+# Standalone re-trigger for the App Store review submission step. The iOS
+# binary is already uploaded to TestFlight via the main release-mobile flow;
+# this workflow just runs the fastlane submit_review lane against the latest
+# TestFlight build, without rebuilding or re-uploading.
+
+on:
+  workflow_dispatch: {}
+
+jobs:
+  submit_ios_for_review:
+    name: Submit iOS for App Store review
+    environment: production
+    runs_on: macos-medium
+    steps:
+      - uses: eas/checkout
+      - name: Install fastlane
+        run: bundle install
+      - name: Submit for review
+        run: bundle exec fastlane ios submit_review
diff --git a/packages/app/fastlane/Fastfile b/packages/app/fastlane/Fastfile
index acc757672..e0182370b 100644
--- a/packages/app/fastlane/Fastfile
+++ b/packages/app/fastlane/Fastfile
@@ -29,8 +29,7 @@ platform :ios do
     loop do
       builds = Spaceship::ConnectAPI::Build.all(
         app_id: app.id,
-        filter: { "version" => build_number.to_s },
-        includes: "preReleaseVersion",
+        version: build_number.to_s,
       )
       build = builds.find { |b| b.pre_release_version&.platform == "IOS" }
       state = build&.processing_state