Remove casts from Claude agent
This commit is contained in:
@@ -577,9 +577,10 @@ Build a new Codex MCP provider side‑by‑side with the existing Codex SDK prov
|
||||
- `packages/server/src/server/agent/stt-openai.ts:127`
|
||||
- **Done (2025-12-25 10:55)**: WHAT: replaced Record/cast usage with type guards and index signatures in `packages/server/src/server/agent/model-catalog.ts:75`, `packages/server/src/server/agent/activity-curator.ts:27`, `packages/server/src/server/agent/agent-projections.ts:31`, `packages/server/src/server/agent/stt-openai.ts:29`. RESULT: core agent files now parse model list responses, tool-call outputs, JSON sanitization, and STT logprobs/language without `Record<string, unknown>` or casted access. EVIDENCE: `rg -n "Record<string, unknown>|\\bas\\b" packages/server/src/server/agent/model-catalog.ts packages/server/src/server/agent/activity-curator.ts packages/server/src/server/agent/agent-projections.ts packages/server/src/server/agent/stt-openai.ts` (no matches).
|
||||
|
||||
- [ ] **Fix**: Remove `Record<string, unknown>`/`as` usage in Claude agent files:
|
||||
- [x] **Fix**: Remove `Record<string, unknown>`/`as` usage in Claude agent files:
|
||||
- `packages/server/src/server/agent/providers/claude-agent.test.ts:99`, `packages/server/src/server/agent/providers/claude-agent.test.ts:109`, `packages/server/src/server/agent/providers/claude-agent.test.ts:110`, `packages/server/src/server/agent/providers/claude-agent.test.ts:456`, `packages/server/src/server/agent/providers/claude-agent.test.ts:463`, `packages/server/src/server/agent/providers/claude-agent.test.ts:1279`
|
||||
- `packages/server/src/server/agent/providers/claude-agent.ts:159`, `packages/server/src/server/agent/providers/claude-agent.ts:164`, `packages/server/src/server/agent/providers/claude-agent.ts:784`, `packages/server/src/server/agent/providers/claude-agent.ts:785`, `packages/server/src/server/agent/providers/claude-agent.ts:874`, `packages/server/src/server/agent/providers/claude-agent.ts:1120`, `packages/server/src/server/agent/providers/claude-agent.ts:1138`, `packages/server/src/server/agent/providers/claude-agent.ts:1162`, `packages/server/src/server/agent/providers/claude-agent.ts:1163`, `packages/server/src/server/agent/providers/claude-agent.ts:1249`, `packages/server/src/server/agent/providers/claude-agent.ts:1343`, `packages/server/src/server/agent/providers/claude-agent.ts:1347`, `packages/server/src/server/agent/providers/claude-agent.ts:1350`, `packages/server/src/server/agent/providers/claude-agent.ts:1364`, `packages/server/src/server/agent/providers/claude-agent.ts:1375`, `packages/server/src/server/agent/providers/claude-agent.ts:1392`
|
||||
- **Done (2025-12-25 11:12)**: WHAT: replaced casted command/output handling with key-value type guards in `packages/server/src/server/agent/providers/claude-agent.test.ts:99`, `packages/server/src/server/agent/providers/claude-agent.test.ts:467`, `packages/server/src/server/agent/providers/claude-agent.test.ts:1157` and normalized Claude event/input parsing without casts in `packages/server/src/server/agent/providers/claude-agent.ts:112`, `packages/server/src/server/agent/providers/claude-agent.ts:1355`, `packages/server/src/server/agent/providers/claude-agent.ts:1463`, `packages/server/src/server/agent/providers/claude-agent.ts:1651`. RESULT: Claude agent/provider tests no longer use `Record<string, unknown>` or `as` assertions while preserving tool input/output and history parsing. EVIDENCE: `rg -n "Record<string, unknown>|\\bas\\b" packages/server/src/server/agent/providers/claude-agent.ts packages/server/src/server/agent/providers/claude-agent.test.ts` (no matches).
|
||||
|
||||
- [x] **SKIP**: Codex SDK agent files (`codex-agent.ts`, `codex-agent.test.ts`) - DEPRECATED.
|
||||
- `codex-agent.ts` is the old SDK provider, replaced by `codex-mcp-agent.ts`
|
||||
|
||||
Reference in New Issue
Block a user