Reduce redundant runtime updates

This commit is contained in:
Mohamed Boudra
2026-04-22 14:03:59 +07:00
parent 2706d5e934
commit f422dabf1e
13 changed files with 58 additions and 49 deletions
@@ -32,7 +32,6 @@ const ELIGIBLE_WORKTREE_SNAPSHOT: WorkspaceGitRuntimeSnapshot = {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
};
@@ -296,7 +296,6 @@ function createWorkspaceGitSnapshot(cwd: string): WorkspaceGitRuntimeSnapshot {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
};
}
@@ -237,7 +237,6 @@ function createWorkspaceGitSnapshot(
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
...overrides?.github,
},
};
-1
View File
@@ -5837,7 +5837,6 @@ export class Session {
featuresEnabled: snapshot.github.featuresEnabled,
pullRequest: snapshot.github.pullRequest,
error: snapshot.github.error,
refreshedAt: snapshot.github.refreshedAt,
};
}
@@ -38,7 +38,6 @@ function createWorkspaceRuntimeSnapshot(
featuresEnabled: true,
pullRequest: null,
error: null,
refreshedAt: "2026-04-12T00:00:00.000Z",
},
};
@@ -477,7 +476,6 @@ describe("workspace git watch targets", () => {
headRefName: "workspace-git-service",
isMerged: true,
},
refreshedAt: "2026-04-12T00:05:00.000Z",
},
}),
);
@@ -134,7 +134,6 @@ function createNoopWorkspaceGitService() {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
},
unsubscribe: () => {},
@@ -159,7 +158,6 @@ function createNoopWorkspaceGitService() {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
}),
resolveRepoRemoteUrl: async () => null,
@@ -210,7 +208,6 @@ function createWorkspaceRuntimeSnapshot(
isMerged: false,
},
error: null,
refreshedAt: "2026-04-12T00:00:00.000Z",
},
};
@@ -2592,7 +2589,6 @@ describe("workspace aggregation", () => {
headRefName: "runtime-branch",
isMerged: false,
},
refreshedAt: "2026-04-12T00:05:00.000Z",
},
});
const workspaceGitService = createNoopWorkspaceGitService();
@@ -2674,7 +2670,6 @@ describe("workspace aggregation", () => {
isMerged: false,
},
error: null,
refreshedAt: "2026-04-12T00:05:00.000Z",
},
}),
]);
@@ -2696,7 +2691,6 @@ describe("workspace aggregation", () => {
headRefName: "feature/runtime-payloads",
isMerged: true,
},
refreshedAt: "2026-04-12T00:10:00.000Z",
},
});
const workspaceGitService = createNoopWorkspaceGitService();
@@ -2770,7 +2764,6 @@ describe("workspace aggregation", () => {
title: "Updated runtime payloads",
isMerged: true,
}),
refreshedAt: "2026-04-12T00:10:00.000Z",
}),
}),
},
@@ -89,7 +89,6 @@ function createFallbackWorkspaceGitService(): WorkspaceGitServiceImpl {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
},
unsubscribe: () => {},
@@ -114,7 +113,6 @@ function createFallbackWorkspaceGitService(): WorkspaceGitServiceImpl {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
}),
refresh: async () => {},
@@ -137,7 +137,6 @@ function createSnapshot(
isMerged: false,
},
error: null,
refreshedAt: "2026-04-12T00:00:00.000Z",
},
};
@@ -412,9 +411,6 @@ describe("WorkspaceGitServiceImpl primitive refresh entrypoint", () => {
currentBranch: "feature",
diffStat: { additions: 4, deletions: 2 },
},
github: {
refreshedAt: "2026-04-12T00:00:16.000Z",
},
});
await expect(Promise.all([first, second])).resolves.toEqual([freshSnapshot, freshSnapshot]);
expect(getCheckoutStatus).toHaveBeenCalledTimes(2);
@@ -51,7 +51,6 @@ function createSnapshot(
isMerged: false,
},
error: null,
refreshedAt: "2026-04-12T00:00:00.000Z",
},
};
@@ -267,7 +266,6 @@ describe("WorkspaceGitServiceImpl", () => {
headRefName: "workspace-git-service",
isMerged: false,
},
refreshedAt: "2026-04-12T02:03:04.000Z",
},
}),
);
@@ -276,6 +274,26 @@ describe("WorkspaceGitServiceImpl", () => {
service.dispose();
});
test("non-forced GitHub refresh does not emit when pull request state is unchanged", async () => {
let nowMs = Date.parse("2026-04-12T00:00:00.000Z");
const getPullRequestStatus = vi.fn(async () => createPullRequestStatusResult());
const service = createService({
getPullRequestStatus,
now: () => new Date(nowMs),
});
const listener = vi.fn();
const subscription = await service.subscribe({ cwd: "/tmp/repo" }, listener);
nowMs += 3_000;
await service.refresh("/tmp/repo");
expect(getPullRequestStatus).toHaveBeenCalledTimes(2);
expect(listener).not.toHaveBeenCalled();
subscription.unsubscribe();
service.dispose();
});
test("cold getSnapshot calls share one workspace target setup and cache the snapshot", async () => {
const checkoutStatusDeferred = createDeferred<CheckoutStatusGit>();
const getCheckoutStatus = vi.fn(async () => checkoutStatusDeferred.promise);
@@ -361,13 +379,7 @@ describe("WorkspaceGitServiceImpl", () => {
nowMs += 3_000;
await service.refresh("/tmp/repo");
await expect(service.getSnapshot("/tmp/repo/.")).resolves.toEqual(
createSnapshot("/tmp/repo", {
github: {
refreshedAt: "2026-04-12T00:00:03.000Z",
},
}),
);
await expect(service.getSnapshot("/tmp/repo/.")).resolves.toEqual(createSnapshot("/tmp/repo"));
expect(getPullRequestStatus).toHaveBeenCalledTimes(2);
expect(resolveAbsoluteGitDir).toHaveBeenCalledTimes(1);
@@ -460,7 +472,6 @@ describe("WorkspaceGitServiceImpl", () => {
headRefName: "feature",
isMerged: true,
},
refreshedAt: "2026-04-12T00:05:00.000Z",
},
}),
);
@@ -534,7 +545,6 @@ describe("WorkspaceGitServiceImpl", () => {
github: {
featuresEnabled: false,
pullRequest: null,
refreshedAt: null,
},
}),
);
@@ -79,7 +79,6 @@ export type WorkspaceGitRuntimeSnapshot = {
reviewDecision?: "approved" | "changes_requested" | "pending" | null;
} | null;
error: { message: string } | null;
refreshedAt: string | null;
};
};
@@ -1499,7 +1498,6 @@ async function loadGitHubSnapshot(options: {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
};
}
@@ -1510,7 +1508,6 @@ async function loadGitHubSnapshot(options: {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
};
}
@@ -1523,7 +1520,6 @@ async function loadGitHubSnapshot(options: {
featuresEnabled: true,
pullRequest: result.status,
error: null,
refreshedAt: options.now.toISOString(),
};
} catch (error) {
return {
@@ -1532,7 +1528,6 @@ async function loadGitHubSnapshot(options: {
error: {
message: error instanceof Error ? error.message : String(error),
},
refreshedAt: options.now.toISOString(),
};
}
}
@@ -1607,7 +1602,6 @@ function buildNotGitSnapshot(cwd: string): WorkspaceGitRuntimeSnapshot {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
};
}
@@ -32,7 +32,6 @@ function createNoopWorkspaceGitService(): WorkspaceGitService {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
},
unsubscribe: () => {},
@@ -57,7 +56,6 @@ function createNoopWorkspaceGitService(): WorkspaceGitService {
featuresEnabled: false,
pullRequest: null,
error: null,
refreshedAt: null,
},
}),
resolveRepoRemoteUrl: async () => null,